ChangeVersionCommandTest::testShouldExecuteCorrectlyAndDisplaySuccessMessage() - Code Metrics - Inspection of "[#120] Ported sys:setup:change-version command" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#167)

by Robbie

created 2015-12-30 04:20 UTC

testShouldExecuteCorrectlyAndDisplaySuccessMessage() A

↳ Parent: ChangeVersionCommandTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	15
rs	9.4286
cc	1
eloc	9
nc	1
nop	0

<?php

namespace N98\Magento\Command\System\Setup;

use Symfony\Component\Console\Tester\CommandTester;
use N98\Magento\Command\PHPUnit\TestCase;

class ChangeVersionCommandTest extends TestCase
{
    /**
     * @var ChangeVersionCommand;
     */
    protected $command;

    /**
     * @var CommandTester
     */
    protected $commandTester;

    /**
     * Set up the test dependencies
     */
    public function setUp()
    {
        $application = $this->getApplication();
        $application->add(new ChangeVersionCommand());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->command = $this->getApplication()->find('sys:setup:change-version');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->commandTester = new CommandTester($this->command);
    }

    /**
     * Ensure that the version for a random Magento module can be changed
     */
    public function testShouldExecuteCorrectlyAndDisplaySuccessMessage()
    {
        $this->commandTester->execute(
            array(
                'command' => $this->command->getName(),
                'module'  => 'magento_customer',
                'version' => '2.0.0'
            )
        );

        $this->assertContains(
            'Successfully updated: "Magento_Customer" to version: "2.0.0"',
            $this->commandTester->getDisplay()
        );
    }

    /**
     * Ensure an exception is thrown when the module doesn't exist
     * @expectedException InvalidArgumentException
     */
    public function testExecuteShouldThrowExceptionWhenModuleDoesntExist()
    {
        $this->commandTester->execute(
            array(
                'command' => $this->command->getName(),
                'module'  => 'non_existent_module',
                'version' => '2.0.0'
            )
        );
    }
}


Pull Request — develop (#167)

testShouldExecuteCorrectlyAndDisplaySuccessMessage() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace N98\Magento\Command\System\Setup;
4
5			use Symfony\Component\Console\Tester\CommandTester;
6			use N98\Magento\Command\PHPUnit\TestCase;
7
8			class ChangeVersionCommandTest extends TestCase
9			{
10			/**
11			* @var ChangeVersionCommand;
12			*/
13			protected $command;
14
15			/**
16			* @var CommandTester
17			*/
18			protected $commandTester;
19
20			/**
21			* Set up the test dependencies
22			*/
23			public function setUp()
24			{
25			$application = $this->getApplication();
26			$application->add(new ChangeVersionCommand());
			0 ignored issues – show Bug introduced 2015-12-30 04:24 UTC by Report Bug Copy Issue Report The method `add` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27
28			$this->command = $this->getApplication()->find('sys:setup:change-version');
			0 ignored issues – show Bug introduced 2015-12-30 04:24 UTC by Report Bug Copy Issue Report The method `find` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
29
30			$this->commandTester = new CommandTester($this->command);
31			}
32
33			/**
34			* Ensure that the version for a random Magento module can be changed
35			*/
36			public function testShouldExecuteCorrectlyAndDisplaySuccessMessage()
37			{
38			$this->commandTester->execute(
39			array(
40			'command' => $this->command->getName(),
41			'module' => 'magento_customer',
42			'version' => '2.0.0'
43			)
44			);
45
46			$this->assertContains(
47			'Successfully updated: "Magento_Customer" to version: "2.0.0"',
48			$this->commandTester->getDisplay()
49			);
50			}
51
52			/**
53			* Ensure an exception is thrown when the module doesn't exist
54			* @expectedException InvalidArgumentException
55			*/
56			public function testExecuteShouldThrowExceptionWhenModuleDoesntExist()
57			{
58			$this->commandTester->execute(
59			array(
60			'command' => $this->command->getName(),
61			'module' => 'non_existent_module',
62			'version' => '2.0.0'
63			)
64			);
65			}
66			}
67

netz98 / n98-magerun2

Pull Request — develop (#167)

testShouldExecuteCorrectlyAndDisplaySuccessMessage() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like