N98\Magento\Command\Customer\CreateCommand

Complexity

Total Complexity

16

Size/Duplication

Total Lines	161
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	17	1
A	inject()	0	7	1
D	execute()	0	85	11
A	createCustomer()	0	21	3

<?php

namespace N98\Magento\Command\Customer;

use Magento\Customer\Api\AccountManagementInterface;
use Magento\Framework\App\State\Proxy as AppState;
use Magento\Framework\Exception\LocalizedException;
use N98\Util\Console\Helper\Table\Renderer\RendererFactory;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class CreateCommand extends AbstractCustomerCommand
{
    /**
     * @var AccountManagementInterface
     */
    private $accountManagement;

    /**
     * @var AppState
     */
    private $appState;

    protected function configure()
    {
        $this
            ->setName('customer:create')
            ->addArgument('email', InputArgument::OPTIONAL, 'Email')
            ->addArgument('password', InputArgument::OPTIONAL, 'Password')
            ->addArgument('firstname', InputArgument::OPTIONAL, 'Firstname')
            ->addArgument('lastname', InputArgument::OPTIONAL, 'Lastname')
            ->addArgument('website', InputArgument::OPTIONAL, 'Website')
            ->addOption(
                'format',
                null,
                InputOption::VALUE_OPTIONAL,
                'Output Format. One of [' . implode(',', RendererFactory::getFormats()) . ']'
            )
            ->setDescription('Creates a new customer/user for shop frontend.');
    }

    /**
     * @param AccountManagementInterface $accountManagement
     * @param AppState $appState
     */
    public function inject(
        AccountManagementInterface $accountManagement,
        AppState $appState
    ) {
        $this->accountManagement = $accountManagement;
        $this->appState = $appState;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int
     * @throws \Exception
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->detectMagento($output, true);
        if (!$this->initMagento()) {
            return 1;
        }

        $dialog = $this->getHelperSet()->get('dialog');

        // Email
        $email = $this->getHelperSet()->get('parameter')->askEmail($input, $output);

        // Password
        if (($password = $input->getArgument('password')) == null) {

It seems like you are loosely comparing $password = $input->getArgument('password') of type string|string[]|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $password = $dialog->askHiddenResponse($output, '<question>Password:</question>');
        }

        // Firstname
        if (($firstname = $input->getArgument('firstname')) == null) {

It seems like you are loosely comparing $firstname = $input->getArgument('firstname') of type string|string[]|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $firstname = $dialog->ask($output, '<question>Firstname:</question>');
        }

        // Lastname
        if (($lastname = $input->getArgument('lastname')) == null) {

It seems like you are loosely comparing $lastname = $input->getArgument('lastname') of type string|string[]|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $lastname = $dialog->ask($output, '<question>Lastname:</question>');
        }

        $website = $this->getHelperSet()->get('parameter')->askWebsite($input, $output);

        // create new customer
        $customer = $this->getCustomer();
        $customer->setWebsiteId($website->getId());
        $customer->loadByEmail($email);

        $outputPlain = $input->getOption('format') === null;

        $table = array();
        $isError = false;

        if (!$customer->getId()) {
            $customer->setWebsiteId($website->getId());
            $customer->setEmail($email);
            $customer->setFirstname($firstname);
            $customer->setLastname($lastname);
            $customer->setStoreId($website->getDefaultGroup()->getDefaultStore()->getId());

            try {
                $this->appState->setAreaCode('frontend');
                $this->appState->emulateAreaCode(
                    'frontend',
                    [$this, 'createCustomer'],
                    [$customer, $password]
                );

                if ($outputPlain) {
                    $output->writeln(
                        sprintf(
                            '<info>Customer <comment>%s</comment> successfully created</info>',
                            $email
                        )
                    );
                } else {
                    $table[] = array(
                        $email,
                        $password,
                        $firstname,
                        $lastname,
                    );
                }
            } catch (\Exception $e) {
                $isError = true;
                $output->writeln('<error>' . $e->getMessage() . '</error>');
            }
        } elseif ($outputPlain) {
            $output->writeln('<warning>Customer ' . $email . ' already exists</warning>');
        }

        if (!$outputPlain) {
            $this->getHelper('table')

It seems like you code against a concrete implementation and not the interface Symfony\Component\Console\Helper\HelperInterface as the method setHeaders() does only exist in the following implementations of said interface: N98\Util\Console\Helper\TableHelper, Symfony\Component\Console\Helper\TableHelper.

                ->setHeaders(array('email', 'password', 'firstname', 'lastname'))
                ->renderByFormat($output, $table, $input->getOption('format'));
        }

        return $isError ? 1 : 0;
    }

    /**
     * @param string $customer
     * @param string $password
     * @throws \Magento\Framework\Exception\LocalizedException
     */
    public function createCustomer($customer, $password)
    {
        try {
            // Fix for proxy which does not respect "emulateAreaCode".

            // @see \Magento\Framework\Session\SessionManager::isSessionExists Hack to prevent session problems
            @session_start();

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            /** @var \Magento\Theme\Model\View\Design $design */
            $design = $this->getObjectManager()->get(\Magento\Theme\Model\View\Design::class);
            $design->setArea('frontend');
            $this->accountManagement->createAccount(
                $customer->getDataModel(),

The method getDataModel cannot be called on $customer (of type string).

                $password
            );
        } catch (LocalizedException $e) {

The class Magento\Framework\Exception\LocalizedException does not exist. Did you forget a USE statement, or did you not list all dependencies?

            if ($e->getRawMessage() !== 'Design config must have area and store.') {
                throw $e;
            }
        }
    }
}