AbstractSetupCommand::getMagentoModuleList() - Code Metrics - Inspection of "[#120] Ported sys:setup:change-version command" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#167)

by Robbie

created 2015-12-29 04:09 UTC

AbstractSetupCommand::getMagentoModuleList() A

↳ Parent: AbstractSetupCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
rs	9.4286
cc	2
eloc	4
nc	2
nop	0

<?php

namespace N98\Magento\Command\System\Setup;

use N98\Magento\Command\AbstractMagentoCommand;
use Magento\Framework\Module\ModuleListInterface;
use Magento\Framework\Module\ResourceInterface;

/**
 * Class AbstractSetupCommand
 * @package N98\Magento\Command\System\Setup
 */
abstract class AbstractSetupCommand extends AbstractMagentoCommand
{
    /**
     * @var ModuleListInterface
     */
    protected $moduleList;

    /**
     * @var ResourceInterface
     */
    protected $resource;

    /**
     * Determine if a module exists. If it does, return the actual module name (not lowercased).
     * @param  string $requestedModuleName
     * @return string

     * @throws \InvalidArgumentException When the module doesn't exist
     */
    public function getMagentoModuleName($requestedModuleName)
    {
        $lowercaseModuleName = strtolower($requestedModuleName);
        
        foreach ($this->getMagentoModuleList()->getAll() as $moduleName => $moduleInfo) {
            if ($lowercaseModuleName === strtolower($moduleName)) {
                return $moduleName;
            }
        }
        
        throw new \InvalidArgumentException(sprintf('Module does not exist: "%s"', $requestedModuleName));
    }

    /**
     * @return ModuleListInterface
     */
    public function getMagentoModuleList()
    {
        if (is_null($this->moduleList)) {
            $this->moduleList = $this->getObjectManager()->get('Magento\Framework\Module\ModuleListInterface');
        }
        return $this->moduleList;
    }

    /**
     * @return ResourceInterface
     */
    public function getMagentoModuleResource()
    {
        if (is_null($this->resource)) {
            $this->resource = $this->getObjectManager()->get('Magento\Framework\Module\ResourceInterface');
        }
        return $this->resource;
    }
}


1			<?php
2
3			namespace N98\Magento\Command\System\Setup;
4
5			use N98\Magento\Command\AbstractMagentoCommand;
6			use Magento\Framework\Module\ModuleListInterface;
7			use Magento\Framework\Module\ResourceInterface;
8
9			/**
10			* Class AbstractSetupCommand
11			* @package N98\Magento\Command\System\Setup
12			*/
13			abstract class AbstractSetupCommand extends AbstractMagentoCommand
14			{
15			/**
16			* @var ModuleListInterface
17			*/
18			protected $moduleList;
19
20			/**
21			* @var ResourceInterface
22			*/
23			protected $resource;
24
25			/**
26			* Determine if a module exists. If it does, return the actual module name (not lowercased).
27			* @param string $requestedModuleName
28			* @return string
			0 ignored issues – show Documentation introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report Should the return type not be `integer\|string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
29			* @throws \InvalidArgumentException When the module doesn't exist
30			*/
31			public function getMagentoModuleName($requestedModuleName)
32			{
33			$lowercaseModuleName = strtolower($requestedModuleName);
34
35			foreach ($this->getMagentoModuleList()->getAll() as $moduleName => $moduleInfo) {
36			if ($lowercaseModuleName === strtolower($moduleName)) {
37			return $moduleName;
38			}
39			}
40
41			throw new \InvalidArgumentException(sprintf('Module does not exist: "%s"', $requestedModuleName));
42			}
43
44			/**
45			* @return ModuleListInterface
46			*/
47			public function getMagentoModuleList()
48			{
49			if (is_null($this->moduleList)) {
50			$this->moduleList = $this->getObjectManager()->get('Magento\Framework\Module\ModuleListInterface');
51			}
52			return $this->moduleList;
53			}
54
55			/**
56			* @return ResourceInterface
57			*/
58			public function getMagentoModuleResource()
59			{
60			if (is_null($this->resource)) {
61			$this->resource = $this->getObjectManager()->get('Magento\Framework\Module\ResourceInterface');
62			}
63			return $this->resource;
64			}
65			}
66

netz98 / n98-magerun2

Pull Request — develop (#167)

AbstractSetupCommand::getMagentoModuleList() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like