Issues in Config.php (master) - Issues in master - netresearch/kite - Measure and Improve Code Quality continuously with Scrutinizer

Issues (120)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Service/Config.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * See class comment
 *
 * PHP Version 5
 *
 * @category Netresearch
 * @package  Netresearch\Kite
 * @author   Christian Opitz <[email protected]>
 * @license  http://www.netresearch.de Netresearch Copyright
 * @link     http://www.netresearch.de
 */

namespace Netresearch\Kite\Service;
use Netresearch\Kite\Exception;

/**
 * Central config class
 *
 * @category Netresearch
 * @package  Netresearch\Kite
 * @author   Christian Opitz <[email protected]>
 * @license  http://www.netresearch.de Netresearch Copyright
 * @link     http://www.netresearch.de
 */
class Config extends \ArrayObject
{
    /**
     * Config constructor.
     */
    public function __construct()
    {
        parent::__construct(
            [
                'jobs' => []
            ]
        );
    }

    /**
     * Include the main or any other config file
     *
     * @param string $path Path to file
     *
     * @return void
     */
    public function loadConfigFile($path)
    {
        $absPath = stream_resolve_include_path($path);
        if ($absPath === false) {
            throw new Exception("File $path could not be found");
        }
        include $absPath;
    }

    /**
     * Load a preset
     *
     * @param string $name Basename of the file (lowerCamelCase)
     *
     * @return void
     */
    public function loadPreset($name)
    {
        include dirname(dirname(__DIR__)) . '/presets/' . $name . '.php';
    }

    /**
     * Get config of a particular or all jobs
     *
     * @param string $job The job name
     *
     * @return array
     */
    public function getJobConfiguration($job = null)
    {
        if ($job) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            if (!array_key_exists($job, $this['jobs'])) {
                throw new Exception("Job $job is not configured");
            }
            return $this['jobs'][$job];
        }
        return $this['jobs'];
    }

    /**
     * Configure a job
     *
     * @param string $name   The job name
     * @param array  $config The config
     *
     * @return void
     */
    public function configureJob($name, array $config)
    {
        $this['jobs'][$name] = $config;
    }

    /**
     * Recursively merge an array into another
     *
     * @param array $to   To (by reference)
     * @param array $from From
     *
     * @return void
     */
    public function merge(array &$to, array $from)
    {
        foreach ($from as $key => $fromValue) {
            if (is_numeric($key)) {
                $to[] = $fromValue;
            } elseif (isset($to[$key]) && is_array($to[$key]) && is_array($fromValue)) {
                $this->merge($to[$key], $fromValue);
            } else {
                $to[$key] = $fromValue;
            }
        }
        reset($to);
    }
}
?>


1			<?php
2			/**
3			* See class comment
4			*
5			* PHP Version 5
6			*
7			* @category Netresearch
8			* @package Netresearch\Kite
9			* @author Christian Opitz <[email protected]>
10			* @license http://www.netresearch.de Netresearch Copyright
11			* @link http://www.netresearch.de
12			*/
13
14			namespace Netresearch\Kite\Service;
15			use Netresearch\Kite\Exception;
16
17			/**
18			* Central config class
19			*
20			* @category Netresearch
21			* @package Netresearch\Kite
22			* @author Christian Opitz <[email protected]>
23			* @license http://www.netresearch.de Netresearch Copyright
24			* @link http://www.netresearch.de
25			*/
26			class Config extends \ArrayObject
27			{
28			/**
29			* Config constructor.
30			*/
31			public function __construct()
32			{
33			parent::__construct(
34			[
35			'jobs' => []
36			]
37			);
38			}
39
40			/**
41			* Include the main or any other config file
42			*
43			* @param string $path Path to file
44			*
45			* @return void
46			*/
47			public function loadConfigFile($path)
48			{
49			$absPath = stream_resolve_include_path($path);
50			if ($absPath === false) {
51			throw new Exception("File $path could not be found");
52			}
53			include $absPath;
54			}
55
56			/**
57			* Load a preset
58			*
59			* @param string $name Basename of the file (lowerCamelCase)
60			*
61			* @return void
62			*/
63			public function loadPreset($name)
64			{
65			include dirname(dirname(__DIR__)) . '/presets/' . $name . '.php';
66			}
67
68			/**
69			* Get config of a particular or all jobs
70			*
71			* @param string $job The job name
72			*
73			* @return array
74			*/
75			public function getJobConfiguration($job = null)
76			{
77			if ($job) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-18 14:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$job` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
78			if (!array_key_exists($job, $this['jobs'])) {
79			throw new Exception("Job $job is not configured");
80			}
81			return $this['jobs'][$job];
82			}
83			return $this['jobs'];
84			}
85
86			/**
87			* Configure a job
88			*
89			* @param string $name The job name
90			* @param array $config The config
91			*
92			* @return void
93			*/
94			public function configureJob($name, array $config)
95			{
96			$this['jobs'][$name] = $config;
97			}
98
99			/**
100			* Recursively merge an array into another
101			*
102			* @param array $to To (by reference)
103			* @param array $from From
104			*
105			* @return void
106			*/
107			public function merge(array &$to, array $from)
108			{
109			foreach ($from as $key => $fromValue) {
110			if (is_numeric($key)) {
111			$to[] = $fromValue;
112			} elseif (isset($to[$key]) && is_array($to[$key]) && is_array($fromValue)) {
113			$this->merge($to[$key], $fromValue);
114			} else {
115			$to[$key] = $fromValue;
116			}
117			}
118			reset($to);
119			}
120			}
121			?>
122

GitHub Access Token became invalid

Issues (120)

Security Analysis no request data

src/Service/Config.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

netresearch / kite

GitHub Access Token became invalid

Issues (120)

Security Analysis no request data

src/Service/Config.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like