Issues in ExpressionLanguage.php (master) - Issues in master - netresearch/kite - Measure and Improve Code Quality continuously with Scrutinizer

Issues (120)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ExpressionLanguage/ExpressionLanguage.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * See class comment
 *
 * PHP Version 5
 *
 * @category   Netresearch
 * @package    Netresearch\Kite
 * @subpackage ExpressionLanguage
 * @author     Christian Opitz <[email protected]>
 * @license    http://www.netresearch.de Netresearch Copyright
 * @link       http://www.netresearch.de
 */

namespace Netresearch\Kite\ExpressionLanguage;
use Netresearch\Kite\Task;

use Symfony\Component\Console\Question\ChoiceQuestion;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;
use Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheInterface;

/**
 * Extension of Symfonies expression language to inject our custom
 * lexer and register some functions
 *
 * @category   Netresearch
 * @package    Netresearch\Kite
 * @subpackage ExpressionLanguage
 * @author     Christian Opitz <[email protected]>
 * @license    http://www.netresearch.de Netresearch Copyright
 * @link       http://www.netresearch.de
 */
class ExpressionLanguage extends \Symfony\Component\ExpressionLanguage\ExpressionLanguage
{
    /**
     * @var array
     */
    protected $expressionResults = [];

    /**
     * @var string
     */
    const VARIABLES_KEY = 'variables';

    /**
     * ExpressionLanguage constructor.
     *
     * @param ParserCacheInterface|null $cache     The cache
     * @param array                     $providers Providers
     */
    public function __construct(ParserCacheInterface $cache = null, array $providers = array())
    {
        parent::__construct($cache, $providers);

        $reflectionProperty = new \ReflectionProperty('\Symfony\Component\ExpressionLanguage\ExpressionLanguage', 'lexer');
        $reflectionProperty->setAccessible(true);
        $reflectionProperty->setValue($this, new Lexer());
    }

    /**
     * Reevaluate parents evaluation results as expressions could be nested
     *
     * Don't parse expression strings which were the final result of an evaluation
     * ( As for example, given a variable "char" that is "\{",
     *   the result of "{char}" would be "{". Reevaluating this is 1. not intended
     *   and would 2. lead to an error )
     *
     * @param string|\Symfony\Component\ExpressionLanguage\Expression $expression The expression
     * @param array                                                   $values     The values
     *
     * @return string|mixed
     */
    public function evaluate($expression, $values = [])
    {
        if (is_string($expression)
            && !in_array($expression, $this->expressionResults, true)
            && preg_match($couldBeExpressionPattern = '/(^|[^\\\\])\{/', $expression)
        ) {
            do {
                $expression = parent::evaluate($expression, $values);
                if (!is_string($expression)) {
                    break;
                }
                if (!preg_match($couldBeExpressionPattern, $expression)) {
                    $expression = str_replace(['\\{', '\\}'], ['{', '}'], $expression);
                    if (strpos($expression, '{') !== false) {
                        $this->expressionResults[] = $expression;
                    }
                    break;
                }
            } while (true);
        }
        return $expression;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }


    /**
     * Ask a question
     *
     * @param Task     $task     The task on which the question was asked
     * @param Question $question The question
     *
     * @return mixed The answer
     */
    protected function ask(Task $task, $question)
    {
        $console = $task->console;
        return $console->getHelper('question')->ask(
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $console->getInput(),
            $console->getOutput(),
            $question
        );
    }

    /**
     * Register functions
     *
     * @return void
     */
    protected function registerFunctions()
    {
        parent::registerFunctions();
        $functions = [
            'call' => function (array $values, $function) {
                $args = array_slice(func_get_args(), 2);
                if (array_key_exists($function, $this->functions)) {
                    array_unshift($args, $values);
                    $function = $this->functions[$function]['evaluator'];
                }
                return call_user_func_array($function, $args);
            },
            'isset' => function (array $values, $var) {
                return $values[self::VARIABLES_KEY]->has($var);
            },
            'empty' => function (array $values, $var) {
                return !$values[self::VARIABLES_KEY]->has($var) || !$values[self::VARIABLES_KEY]->get($var);
            },
            'get' => function (array $values, $var) {
                return $values[self::VARIABLES_KEY]->get($var);
            },
            'set' => function (array $values, $var, $value) {
                $values[self::VARIABLES_KEY]->set($var, $value);
                return $value;
            },
            'confirm' => function (array $values, $question) {
                return $this->ask($values[self::VARIABLES_KEY], new ConfirmationQuestion("<question>$question</question> [y] "));
            },
            'answer' => function (array $values, $question) {
                return $this->ask($values[self::VARIABLES_KEY], new Question("<question>$question</question> "));
            },
            'choose' => function (array $values, $question) {
                return $this->ask($values[self::VARIABLES_KEY], new Question("<question>$question</question> "));
            },
            'replace' => function (array $values, $search, $replace, $subject, $regex = false) {
                $values[self::VARIABLES_KEY]->console->output(
                    '<warning>Expression language function "replace" is deprecated '
                    . 'and will be removed in 1.6.0 - use preg_replace or str_replace</warning>'
                );
                if ($regex) {
                    return preg_replace($search, $replace, $subject);
                } else {
                    return str_replace($search, $replace, $subject);
                }
            },
        ];
        foreach ($functions as $name => $function) {
            $this->register(
                $name,
                function () {

                },
                $function
            );
        }
    }
}
?>


1			<?php
2			/**
3			* See class comment
4			*
5			* PHP Version 5
6			*
7			* @category Netresearch
8			* @package Netresearch\Kite
9			* @subpackage ExpressionLanguage
10			* @author Christian Opitz <[email protected]>
11			* @license http://www.netresearch.de Netresearch Copyright
12			* @link http://www.netresearch.de
13			*/
14
15			namespace Netresearch\Kite\ExpressionLanguage;
16			use Netresearch\Kite\Task;
17
18			use Symfony\Component\Console\Question\ChoiceQuestion;
19			use Symfony\Component\Console\Question\ConfirmationQuestion;
20			use Symfony\Component\Console\Question\Question;
21			use Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheInterface;
22
23			/**
24			* Extension of Symfonies expression language to inject our custom
25			* lexer and register some functions
26			*
27			* @category Netresearch
28			* @package Netresearch\Kite
29			* @subpackage ExpressionLanguage
30			* @author Christian Opitz <[email protected]>
31			* @license http://www.netresearch.de Netresearch Copyright
32			* @link http://www.netresearch.de
33			*/
34			class ExpressionLanguage extends \Symfony\Component\ExpressionLanguage\ExpressionLanguage
35			{
36			/**
37			* @var array
38			*/
39			protected $expressionResults = [];
40
41			/**
42			* @var string
43			*/
44			const VARIABLES_KEY = 'variables';
45
46			/**
47			* ExpressionLanguage constructor.
48			*
49			* @param ParserCacheInterface\|null $cache The cache
50			* @param array $providers Providers
51			*/
52			public function __construct(ParserCacheInterface $cache = null, array $providers = array())
53			{
54			parent::__construct($cache, $providers);
55
56			$reflectionProperty = new \ReflectionProperty('\Symfony\Component\ExpressionLanguage\ExpressionLanguage', 'lexer');
57			$reflectionProperty->setAccessible(true);
58			$reflectionProperty->setValue($this, new Lexer());
59			}
60
61			/**
62			* Reevaluate parents evaluation results as expressions could be nested
63			*
64			* Don't parse expression strings which were the final result of an evaluation
65			* ( As for example, given a variable "char" that is "\{",
66			* the result of "{char}" would be "{". Reevaluating this is 1. not intended
67			* and would 2. lead to an error )
68			*
69			* @param string\|\Symfony\Component\ExpressionLanguage\Expression $expression The expression
70			* @param array $values The values
71			*
72			* @return string\|mixed
73			*/
74			public function evaluate($expression, $values = [])
75			{
76			if (is_string($expression)
77			&& !in_array($expression, $this->expressionResults, true)
78			&& preg_match($couldBeExpressionPattern = '/(^\|[^\\\\])\{/', $expression)
79			) {
80			do {
81			$expression = parent::evaluate($expression, $values);
82			if (!is_string($expression)) {
83			break;
84			}
85			if (!preg_match($couldBeExpressionPattern, $expression)) {
86			$expression = str_replace(['\\{', '\\}'], ['{', '}'], $expression);
87			if (strpos($expression, '{') !== false) {
88			$this->expressionResults[] = $expression;
89			}
90			break;
91			}
92			} while (true);
93			}
94			return $expression;
			0 ignored issues – show Bug Best Practice introduced 2016-04-19 16:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $expression;` (`array\|string\|Symfony\Com...sionLanguage\Expression`) is incompatible with the return type of the parent method `Symfony\Component\Expres...ssionLanguage::evaluate` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
95			}
96
97
98			/**
99			* Ask a question
100			*
101			* @param Task $task The task on which the question was asked
102			* @param Question $question The question
103			*
104			* @return mixed The answer
105			*/
106			protected function ask(Task $task, $question)
107			{
108			$console = $task->console;
109			return $console->getHelper('question')->ask(
			0 ignored issues – show Bug introduced 2016-03-18 14:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `ask()` does only exist in the following implementations of said interface: `Symfony\Component\Console\Helper\DialogHelper`, `Symfony\Component\Console\Helper\QuestionHelper`, `Symfony\Component\Consol...r\SymfonyQuestionHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
110			$console->getInput(),
111			$console->getOutput(),
112			$question
113			);
114			}
115
116			/**
117			* Register functions
118			*
119			* @return void
120			*/
121			protected function registerFunctions()
122			{
123			parent::registerFunctions();
124			$functions = [
125			'call' => function (array $values, $function) {
126			$args = array_slice(func_get_args(), 2);
127			if (array_key_exists($function, $this->functions)) {
128			array_unshift($args, $values);
129			$function = $this->functions[$function]['evaluator'];
130			}
131			return call_user_func_array($function, $args);
132			},
133			'isset' => function (array $values, $var) {
134			return $values[self::VARIABLES_KEY]->has($var);
135			},
136			'empty' => function (array $values, $var) {
137			return !$values[self::VARIABLES_KEY]->has($var) \|\| !$values[self::VARIABLES_KEY]->get($var);
138			},
139			'get' => function (array $values, $var) {
140			return $values[self::VARIABLES_KEY]->get($var);
141			},
142			'set' => function (array $values, $var, $value) {
143			$values[self::VARIABLES_KEY]->set($var, $value);
144			return $value;
145			},
146			'confirm' => function (array $values, $question) {
147			return $this->ask($values[self::VARIABLES_KEY], new ConfirmationQuestion("<question>$question</question> [y] "));
148			},
149			'answer' => function (array $values, $question) {
150			return $this->ask($values[self::VARIABLES_KEY], new Question("<question>$question</question> "));
151			},
152			'choose' => function (array $values, $question) {
153			return $this->ask($values[self::VARIABLES_KEY], new Question("<question>$question</question> "));
154			},
155			'replace' => function (array $values, $search, $replace, $subject, $regex = false) {
156			$values[self::VARIABLES_KEY]->console->output(
157			'<warning>Expression language function "replace" is deprecated '
158			. 'and will be removed in 1.6.0 - use preg_replace or str_replace</warning>'
159			);
160			if ($regex) {
161			return preg_replace($search, $replace, $subject);
162			} else {
163			return str_replace($search, $replace, $subject);
164			}
165			},
166			];
167			foreach ($functions as $name => $function) {
168			$this->register(
169			$name,
170			function () {
171
172			},
173			$function
174			);
175			}
176			}
177			}
178			?>
179

GitHub Access Token became invalid

Issues (120)

Security Analysis no request data

src/ExpressionLanguage/ExpressionLanguage.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

netresearch / kite

GitHub Access Token became invalid

Issues (120)

Security Analysis no request data

src/ExpressionLanguage/ExpressionLanguage.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like