netresearch / kite

presets/typo3/schema-migration.php

Spacing +2 added lines, -2 removed lines

@@ -11,7 +11,7 @@ 
  * @link     http://www.netresearch.de
  */
 
-require_once __DIR__ . '/bootstrap.php';
+require_once __DIR__.'/bootstrap.php';
 
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
@@ -41,7 +41,7 @@ 
         if ($execute) {
             $GLOBALS['TYPO3_DB']->admin_query($query);
             if ($GLOBALS['TYPO3_DB']->sql_error()) {
-                throw new \Exception('SQL-Error: ' . $GLOBALS['TYPO3_DB']->sql_error());
+                throw new \Exception('SQL-Error: '.$GLOBALS['TYPO3_DB']->sql_error());
             }
         }
     }

presets/typo3/clear-cache.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
  * @link     http://www.netresearch.de
  */
 
-require __DIR__ . '/bootstrap.php';
+require __DIR__.'/bootstrap.php';
 
 $dataHandler = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\CMS\Core\DataHandling\DataHandler');
 $dataHandler->stripslashes_values = 0;

presets/typo3/bootstrap.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
     die('Access denied');
 }
 
-define('PATH_site', getcwd() . DIRECTORY_SEPARATOR);
+define('PATH_site', getcwd().DIRECTORY_SEPARATOR);
 
 $typo3VersionIsMinimum7 = true;
 
@@ -33,7 +33,7 @@ 
 }
 
 if ($typo3VersionIsMinimum7) {
-    $classLoader = include getcwd() . '/typo3_src/vendor/autoload.php';
+    $classLoader = include getcwd().'/typo3_src/vendor/autoload.php';
     \TYPO3\CMS\Core\Core\Bootstrap::getInstance()
         ->initializeClassLoader($classLoader)
         ->baseSetup(PATH_site)

src/ExpressionLanguage/ExpressionLanguage.php

Unused Use Statements -2 removed lines

@@ -14,8 +14,6 @@
 
 namespace Netresearch\Kite\ExpressionLanguage;
 use Netresearch\Kite\Task;
-
-use Symfony\Component\Console\Question\ChoiceQuestion;
 use Symfony\Component\Console\Question\ConfirmationQuestion;
 use Symfony\Component\Console\Question\Question;
 use Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheInterface;

Spacing +10 added lines, -10 removed lines

@@ -122,7 +122,7 @@ 
     {
         parent::registerFunctions();
         $functions = [
-            'call' => function (array $values, $function) {
+            'call' => function(array $values, $function) {
                 $args = array_slice(func_get_args(), 2);
                 if (array_key_exists($function, $this->functions)) {
                     array_unshift($args, $values);
@@ -130,29 +130,29 @@ 
                 }
                 return call_user_func_array($function, $args);
             },
-            'isset' => function (array $values, $var) {
+            'isset' => function(array $values, $var) {
                 return $values[self::VARIABLES_KEY]->has($var);
             },
-            'empty' => function (array $values, $var) {
+            'empty' => function(array $values, $var) {
                 return !$values[self::VARIABLES_KEY]->has($var) || !$values[self::VARIABLES_KEY]->get($var);
             },
-            'get' => function (array $values, $var) {
+            'get' => function(array $values, $var) {
                 return $values[self::VARIABLES_KEY]->get($var);
             },
-            'set' => function (array $values, $var, $value) {
+            'set' => function(array $values, $var, $value) {
                 $values[self::VARIABLES_KEY]->set($var, $value);
                 return $value;
             },
-            'confirm' => function (array $values, $question) {
+            'confirm' => function(array $values, $question) {
                 return $this->ask($values[self::VARIABLES_KEY], new ConfirmationQuestion("<question>$question</question> [y] "));
             },
-            'answer' => function (array $values, $question) {
+            'answer' => function(array $values, $question) {
                 return $this->ask($values[self::VARIABLES_KEY], new Question("<question>$question</question> "));
             },
-            'choose' => function (array $values, $question) {
+            'choose' => function(array $values, $question) {
                 return $this->ask($values[self::VARIABLES_KEY], new Question("<question>$question</question> "));
             },
-            'replace' => function (array $values, $search, $replace, $subject, $regex = false) {
+            'replace' => function(array $values, $search, $replace, $subject, $regex = false) {
                 $values[self::VARIABLES_KEY]->console->output(
                     '<warning>Expression language function "replace" is deprecated '
                     . 'and will be removed in 1.6.0 - use preg_replace or str_replace</warning>'
@@ -167,7 +167,7 @@ 
         foreach ($functions as $name => $function) {
             $this->register(
                 $name,
-                function () {
+                function() {
 
                 },
                 $function

src/Workflow/Composer/Base.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -147,7 +147,7 @@ 
                     if ($requiredVersion !== $version) {
                         $this->assertPackageAllowed($package);
                         if (!$package->git) {
-                            throw new Exception("Package {$package->name} required to be installed from source");
+                            throw new Exception("package {$package->name} required to be installed from source");
                         }
                         if ($autoFix) {
                             $fix = true;
@@ -483,7 +483,7 @@ 
     protected function assertPackageAllowed($package)
     {
         if (!$this->isPackageAllowed($package)) {
-            throw new Exception("Package {$package->name} is not in white list");
+            throw new Exception("package {$package->name} is not in white list");
         }
     }
 

Spacing +15 added lines, -15 removed lines

@@ -103,7 +103,7 @@ 
             $this->git('push', $package->path, array('u' => 'origin', $package->branch));
             $this->console->output(
                 str_repeat(chr(8), strlen($package->name))
-                . '<info>' . $package->name . '</info>'
+                . '<info>'.$package->name.'</info>'
             );
             unset($this->pushPackages[$i]);
         }
@@ -147,7 +147,7 @@ 
         $unfixedRequirements = 0;
         while ($packageName = array_shift($checkedOutPackages)) {
             $branch = $packages[$packageName]->branch;
-            $version = 'dev-' . $branch;
+            $version = 'dev-'.$branch;
             foreach ($this->getPackages(false, false) as $package) {
                 if (array_key_exists($packageName, $package->requires)) {
                     // TODO: Set required version to branch alias, if any
@@ -205,7 +205,7 @@ 
         $this->assertPackageIsWhiteListed($package);
 
         $currentVersion = $package->requires[$requiredPackage];
-        $composerFile = $package->path . '/composer.json';
+        $composerFile = $package->path.'/composer.json';
         $composerFileContents = file_get_contents($composerFile);
         $newComposerFileContents = preg_replace(
             sprintf(
@@ -213,7 +213,7 @@ 
                 preg_quote($requiredPackage, '/'),
                 preg_quote($currentVersion, '/')
             ),
-            '$1' . $newVersion,
+            '$1'.$newVersion,
             $composerFileContents
         );
         file_put_contents($composerFile, $newComposerFileContents);
@@ -272,7 +272,7 @@ 
         if (!$package->git) {
             throw new Exception('Non git package can not be checked out');
         }
-        $remoteBranch = 'origin/' . $branch;
+        $remoteBranch = 'origin/'.$branch;
         $isRemote = in_array($remoteBranch, $package->branches, true);
         if (in_array($branch, $package->branches, true)) {
             $this->git('checkout', $package->path, $branch);
@@ -281,7 +281,7 @@ 
         } elseif ($create) {
             $branches = array_unique(
                 array_map(
-                    function ($el) {
+                    function($el) {
                         $parts = explode('/', $el);
                         return array_pop($parts);
                     },
@@ -313,7 +313,7 @@ 
         $this->console->output("Checked out <comment>{$package->name}</comment> at <comment>$branch</comment>");
 
         $this->reloadRequires($package);
-        $package->version = 'dev-' . $branch;
+        $package->version = 'dev-'.$branch;
         $package->branch = $branch;
 
         return true;
@@ -337,7 +337,7 @@ 
             throw new Exception('Non git package can not be merged');
         }
 
-        $this->git('fetch', $package->path, array('force' => true, 'origin', $branch . ':' . $branch));
+        $this->git('fetch', $package->path, array('force' => true, 'origin', $branch.':'.$branch));
 
         $ff = $branch == 'master' ? 'ff' : 'no-ff';
         $optArg = array($ff => true, 'no-commit' => true);
@@ -371,7 +371,7 @@ 
             if (!$message) {
                 $message = $this->answer(
                     'Enter commit message:',
-                    'Merged ' . $branch . ' into ' . $package->branch
+                    'Merged '.$branch.' into '.$package->branch
                 );
             }
             $this->git('commit', $package->path, array('n' => true, 'm' => $message));
@@ -392,7 +392,7 @@ 
      */
     private function resolveRequirementsConflict($package)
     {
-        $contents = file_get_contents($package->path . '/composer.json');
+        $contents = file_get_contents($package->path.'/composer.json');
         $ours = @json_decode(
             preg_replace('/^<{7}.+\n(.+)\n(\|{7}|={7}).+>{7}.+$/smU', '$1', $contents)
         );
@@ -413,7 +413,7 @@ 
         }
 
         $theirs['require'] = $this->mergeRequirements($package, $ours, $theirs);
-        file_put_contents($package->path . '/composer.json', $this->jsonEncode($theirs));
+        file_put_contents($package->path.'/composer.json', $this->jsonEncode($theirs));
     }
 
     /**
@@ -427,7 +427,7 @@ 
     {
         return json_encode(
             $var, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE
-        ) . "\n";
+        )."\n";
     }
 
     /**
@@ -445,7 +445,7 @@ 
         $theirsRequire = isset($theirs['require']) && is_object($theirs['require']) ? get_object_vars($theirs['require']) : [];
         $mergedRequires = array_merge($oursRequire, $theirsRequire);
         $packages = $this->getPackages(false, false);
-        $preferredVersion = 'dev-' . $package->branch;
+        $preferredVersion = 'dev-'.$package->branch;
         foreach ($mergedRequires as $packageName => $version) {
             $actualVersion = ($version === '@dev') ? 'dev-master' : $version;
             if (array_key_exists($packageName, $oursRequire)
@@ -537,9 +537,9 @@ 
         if (!is_array($this->whitelists)) {
             $this->whitelists = [];
             foreach (['path', 'remote', 'name'] as $whiteListType) {
-                $option = $this->get('whitelist' . ucfirst($whiteListType) . 's');
+                $option = $this->get('whitelist'.ucfirst($whiteListType).'s');
                 if ($option) {
-                    $this->whitelists[$whiteListType] = '#^' . $option . '$#';
+                    $this->whitelists[$whiteListType] = '#^'.$option.'$#';
                 }
             }
         }

src/Task.php

Doc Comments +2 added lines, -2 removed lines

@@ -105,7 +105,7 @@ 
     /**
      * Handle onBefore, onAfter and name
      *
-     * @param mixed $offset The name of the variable
+     * @param string $offset The name of the variable
      * @param mixed $value  The value
      *
      * @return void
@@ -158,7 +158,7 @@ 
     /**
      * Generate name if it doesn't exist
      *
-     * @param mixed $offset The name of the variable
+     * @param string $offset The name of the variable
      *
      * @return mixed
      */

presets/typo3.php

Spacing +3 added lines, -3 removed lines

@@ -39,8 +39,8 @@ 
             'type' => 'shell',
             'command' => [
                 'rm -rf typo3temp/Cache/*',
-                '{config["php"]} ' . __DIR__ . '/typo3/clear-cache.php',
-                '{config["php"]} ' . __DIR__ . '/typo3/schema-migration.php',
+                '{config["php"]} '.__DIR__.'/typo3/clear-cache.php',
+                '{config["php"]} '.__DIR__.'/typo3/schema-migration.php',
             ],
             'processSettings' => ['pt' => true]
         ]
@@ -63,7 +63,7 @@ 
             ['workflow' => 'clearCodeCaches'],
             [
                 'type' => 'scp',
-                'from' => __DIR__ . '/typo3',
+                'from' => __DIR__.'/typo3',
                 'to' => '{node}:{node.deployPath}/current/{config["workspace"]}/typo3'
             ],
             [

src/Service/Composer/Package.php

Spacing +7 added lines, -7 removed lines

@@ -70,12 +70,12 @@ 
         if (is_string($composerJson)) {
             $path = realpath($composerJson);
             if (!$path) {
-                throw new Exception('Could not find ' . $composerJson);
+                throw new Exception('Could not find '.$composerJson);
             }
             $this->path = dirname($path);
             $composerJson = json_decode(file_get_contents($path));
             if (!is_object($composerJson)) {
-                throw new Exception('Could not load ' . $path);
+                throw new Exception('Could not load '.$path);
             }
         }
         foreach (get_object_vars($composerJson) as $key => $value) {
@@ -96,7 +96,7 @@ 
     {
         switch ($name) {
         case 'git':
-            $gitDir = $this->path . '/.git';
+            $gitDir = $this->path.'/.git';
             $this->git = file_exists($gitDir) && is_dir($gitDir);
             break;
         case 'branches':
@@ -114,7 +114,7 @@ 
             $this->loadRequires();
             break;
         default:
-            throw new Exception('Invalid property ' . $name);
+            throw new Exception('Invalid property '.$name);
 
         }
         return $this->$name;
@@ -158,7 +158,7 @@ 
      */
     public function reloadRequires()
     {
-        $file = $this->path . '/composer.json';
+        $file = $this->path.'/composer.json';
         if (file_exists($file)) {
             $composerJson = json_decode(file_get_contents($file));
             unset($this->require);
@@ -212,7 +212,7 @@ 
         if ($this->git) {
             $this->composer->git('fetch', $this->path, array('p' => true, 'origin'));
             try {
-                $format = (self::$forEachRefHeadSupported ? '%(HEAD)' : '') . '|%(refname:short)|%(upstream:short)';
+                $format = (self::$forEachRefHeadSupported ? '%(HEAD)' : '').'|%(refname:short)|%(upstream:short)';
                 $gitBr = $this->composer->git('for-each-ref', $this->path, ['format' => $format, 'refs/heads/', 'refs/remotes/origin']);
             } catch (Exception\ProcessFailedException $e) {
                 if (trim($e->getProcess()->getErrorOutput()) === 'fatal: unknown field name: HEAD') {
@@ -252,7 +252,7 @@ 
         try {
             $this->tag = trim($this->composer->git('describe', $this->path, array('exact-match' => true, 'tags' => true)));
         } catch (Exception\ProcessFailedException $e) {
-            $this->tag =  null;
+            $this->tag = null;
         }
     }
 }

src/Workflow/Composer/Diagnose.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Netresearch\Kite\Service;
 
 use Netresearch\Kite\Console\Output\Output;
-
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Helper;
 use Symfony\Component\Console\Input\InputInterface;

Spacing +21 added lines, -21 removed lines

@@ -58,7 +58,7 @@ 
             if (substr($method, 0, 5) === 'check' && $method[5] === strtoupper($method[5])) {
                 $check = substr($method, 5);
                 $this->checks[] = $check;
-                if (method_exists($this, 'fix' . $check)) {
+                if (method_exists($this, 'fix'.$check)) {
                     $this->fixes[] = $check;
                 }
             }
@@ -68,12 +68,12 @@ 
             'check' => array(
                 'type' => 'array',
                 'option' => true,
-                'label' => 'Only execute these checks - available checks are ' . implode(', ', $this->checks),
+                'label' => 'Only execute these checks - available checks are '.implode(', ', $this->checks),
             ),
             'fix' => array(
                 'type' => 'boolean|array',
                 'option' => true,
-                'label' => 'Enable fixes and optionally reduce to certain fixes - available fixes are ' . implode(', ', $this->fixes),
+                'label' => 'Enable fixes and optionally reduce to certain fixes - available fixes are '.implode(', ', $this->fixes),
             ),
         ) + parent::configureVariables();
     }
@@ -86,7 +86,7 @@ 
     public function assemble()
     {
         $this->callback(
-            function () {
+            function() {
                 $fix = $this->get('fix');
                 $fixes = ($fix === true) ? $this->fixes : (array) $fix;
                 $checks = $this->get('check') ?: $this->checks;
@@ -120,11 +120,11 @@ 
             if ($packageNames && !in_array($package->name, $packageNames, true)) {
                 continue;
             }
-            if (is_string($message = $this->{'check' . $check}($package))) {
+            if (is_string($message = $this->{'check'.$check}($package))) {
                 if (!$packageNames && !$errors) {
                     $this->console->output(
                         str_repeat(chr(8), strlen($check))
-                        . '<fg=red;bg=black>' . $check . '</>'
+                        . '<fg=red;bg=black>'.$check.'</>'
                     );
                 }
                 $message = sprintf($message, "package <comment>$package->name</>");
@@ -133,7 +133,7 @@ 
                 if ($fix) {
                     $this->dontCheckCurrentPackageAgain = false;
                     $this->console->indent();
-                    $this->{'fix' . $check}($package);
+                    $this->{'fix'.$check}($package);
                     $this->console->outdent();
                     if (!$this->dontCheckCurrentPackageAgain) {
                         $rerunForPackages[] = $package->name;
@@ -155,7 +155,7 @@ 
             if (!$errors) {
                 $this->console->output(
                     str_repeat(chr(8), strlen($check))
-                    . '<fg=green;bg=black>' . $check . '</>'
+                    . '<fg=green;bg=black>'.$check.'</>'
                 );
             }
             $this->console->outdent();
@@ -212,7 +212,7 @@ 
             $this->git('reset', $package->path);
             $args = 'save -u';
             if ($message = $this->answer('Message for stash:')) {
-                $args .= ' ' . escapeshellarg($message);
+                $args .= ' '.escapeshellarg($message);
             }
             $this->git('stash', $package->path, $args);
             break;
@@ -283,7 +283,7 @@ 
         case 2:
             foreach ($commands as $command) {
                 $pck = "<comment>{$package->name}</comment>";
-                $this->console->output($msg = ucfirst($command) . "ing $pck...", false);
+                $this->console->output($msg = ucfirst($command)."ing $pck...", false);
                 $this->git($command, $package->path, isset($options) ? $options : null);
                 $this->console->output(
                     str_repeat(chr(8), strlen(strip_tags($msg)))
@@ -330,8 +330,8 @@ 
                         }
                         if ($package->requiredBranch && $package->requiredBranch !== $requiredBranch) {
                             $package->invalidRequirements = true;
-                            return '<error>' . array_pop($dependentPackages)
-                                . ' and ' . array_pop($dependentPackages)
+                            return '<error>'.array_pop($dependentPackages)
+                                . ' and '.array_pop($dependentPackages)
                                 . ' require %s in different branches</error>';
                         }
                         $package->requiredBranch = $requiredBranch;
@@ -343,7 +343,7 @@ 
                     }
                 }
             }
-            $constraint = $package->tag ?: 'dev-' . $package->branch;
+            $constraint = $package->tag ?: 'dev-'.$package->branch;
             if ($package->requiredBranch && $package->requiredBranch !== $package->branch) {
                 return "%s is at <comment>$constraint</comment> but is required at <comment>dev-{$package->requiredBranch}</comment>";
             }
@@ -367,8 +367,8 @@ 
         if ($package->invalidRequirements) {
             $this->doExit('Can not fix that', 1);
         }
-        $currentConstraint = $package->tag ?: 'dev-' . $package->branch;
-        $requiredConstraint = 'dev-' . $package->requiredBranch;
+        $currentConstraint = $package->tag ?: 'dev-'.$package->branch;
+        $requiredConstraint = 'dev-'.$package->requiredBranch;
         if ($package->requiredBranch) {
             $actions = array(
                 1 => "Show divergent commits between <comment>$currentConstraint</comment> and <comment>$requiredConstraint</comment> (and ask again)",
@@ -421,7 +421,7 @@ 
         if ($package->git && !$package->isRoot) {
             $remote = false;
             do {
-                $reference = ($remote ? 'origin/' : '') . $package->source->reference;
+                $reference = ($remote ? 'origin/' : '').$package->source->reference;
                 try {
                     $rawCounts = $this->git('rev-list', $package->path, "--count --left-right --cherry-pick {$reference}...");
                     break;
@@ -436,9 +436,9 @@ 
             if ($counts[0] || $counts[1]) {
                 $num = $counts[0] ?: $counts[1];
                 $type = $counts[0] ? 'behind</>' : 'ahead</> of';
-                return '%s is <comment>' . $num . ' commit' . ($num > 1 ? 's ' : ' ')
-                    . $type . ' locked commit <comment>'
-                    . substr($package->source->reference, 0, 7) . '</>';
+                return '%s is <comment>'.$num.' commit'.($num > 1 ? 's ' : ' ')
+                    . $type.' locked commit <comment>'
+                    . substr($package->source->reference, 0, 7).'</>';
             }
         }
         return null;
@@ -556,12 +556,12 @@ 
             $side = $i ? 'left' : 'right';
             $otherSide = $i ? 'right' : 'left';
             $args = "--$side-only --cherry-pick --pretty=format:'%C(yellow)%h %Cgreen%cd %an%Creset%n  %s' --abbrev-commit --date=local ";
-            $args .= $ref . '...';
+            $args .= $ref.'...';
             $log = $this->git('log', $package->path, $args, array('shy' => true));
             if ($log) {
                 $this->console->output('');
 
-                $title = "<info>{${$side . 'Title'}}</info> > <info>{${$otherSide . 'Title'}}</info>";
+                $title = "<info>{${$side.'Title'}}</info> > <info>{${$otherSide.'Title'}}</info>";
                 $this->output($title);
                 $this->console->output(str_repeat('-', strlen(strip_tags($title))));