netresearch / kite

src/Console/Output/ConsoleOutput.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     /**
      * ConsoleOutput constructor.
      *
-     * @param int|mixed                     $verbosity The verbosity
+     * @param integer                     $verbosity The verbosity
      * @param boolean                       $decorated If output should be decorated
      * @param OutputFormatterInterface|null $formatter Formatter
      */

src/Console/Output/Output.php

Doc Comments +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
     /**
      * Constructor.
      *
-     * @param mixed                         $stream    A stream resource
+     * @param resource                         $stream    A stream resource
      * @param int                           $verbosity The verbosity level (one of the VERBOSITY constants in OutputInterface)
      * @param bool|null                     $decorated Whether to decorate messages (null for auto-guessing)
      * @param OutputFormatterInterface|null $formatter Output formatter instance (null to use default OutputFormatter)
@@ -130,7 +130,7 @@ 
     /**
      * Write to output
      *
-     * @param array|string $messages Messages
+     * @param string|null $messages Messages
      * @param bool         $newline  Whether to append a newline
      * @param int          $type     The output type
      *

Spacing +2 added lines, -2 removed lines

@@ -149,10 +149,10 @@
                     $newline = true;
                 }
                 if ($this->previousWasNewLine && $l >= 0 && $message[0] !== "\n") {
-                    $message = $this->getIndention() . $message;
+                    $message = $this->getIndention().$message;
                 }
                 if (strpos($message, "\n") !== false) {
-                    $message = str_replace("\n", "\n" . $this->getIndention(), $message);
+                    $message = str_replace("\n", "\n".$this->getIndention(), $message);
                 }
 
                 // TODO: Indent wrapped lines - that's just not that easy because of the ANSI color escape codes

src/Service/Process.php

Doc Comments +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
      * @param callable|null $callback A PHP callback to run whenever there is some
      *                                output available on STDOUT or STDERR
      *
-     * @return mixed The output of the shell command or FALSE if the command returned a non-zero exit code and $ignoreErrors was enabled.
+     * @return null|string The output of the shell command or FALSE if the command returned a non-zero exit code and $ignoreErrors was enabled.
      */
     public function run($callback = NULL)
     {

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
         } elseif (is_array($command)) {
             $command = implode('; ', $command);
         } else {
-            throw new \Netresearch\Kite\Exception('Command must be string or array, ' . gettype($command) . ' given.', 1312454906);
+            throw new \Netresearch\Kite\Exception('Command must be string or array, '.gettype($command).' given.', 1312454906);
         }
 
         parent::__construct($command, $cwd, null, null, null);
@@ -141,14 +141,14 @@ 
     {
         $command = $this->getCommandLine();
 
-        $this->console->output('<cmd>' . $this->getWorkingDirectory() . ' > ' . $command . '</cmd>', OutputInterface::VERBOSITY_VERBOSE);
+        $this->console->output('<cmd>'.$this->getWorkingDirectory().' > '.$command.'</cmd>', OutputInterface::VERBOSITY_VERBOSE);
 
         if ($this->dryRun) {
             return null;
         }
 
         parent::run(
-            function ($type, $buffer) use ($callback) {
+            function($type, $buffer) use ($callback) {
                 if ($callback) {
                     call_user_func($callback, $type, $buffer);
                 }

src/Task/ShellTask.php

Doc Comments +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
     /**
      * Execute the command
      *
-     * @return mixed
+     * @return null|string
      */
     protected function executeCommand()
     {

Spacing +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
         $process = $this->console->createProcess($this->getCommand(), $this->get('cwd'));
         $process->setDryRun(!$this->shouldExecute());
         foreach ($this->get('processSettings') as $key => $value) {
-            $process->{'set' . ucfirst($key)}($value);
+            $process->{'set'.ucfirst($key)}($value);
         }
         return $process->run();
     }
@@ -169,7 +169,7 @@ 
                 if ($options || $arguments) {
                     throw new Exception('Can not combine argv with options or arguments');
                 }
-                $cmd .= ' ' . (is_array($argv) ? implode(' ', $argv) : $argv);
+                $cmd .= ' '.(is_array($argv) ? implode(' ', $argv) : $argv);
             } else {
                 $cmd .= $this->renderOptions($options);
                 $cmd .= $this->renderArguments($arguments);
@@ -224,7 +224,7 @@ 
         $argumentString = '';
         foreach ($arguments as $argument) {
             $value = $this->expand($argument);
-            $argumentString .= ' ' . escapeshellarg($value);
+            $argumentString .= ' '.escapeshellarg($value);
         }
         return $argumentString;
     }

src/Tasks.php

Doc Comments +7 added lines, -7 removed lines

@@ -426,7 +426,7 @@ 
     /**
      * Execute the next fetched task after given $task
      *
-     * @param Task|string $task Task or task name
+     * @param string $task Task or task name
      *
      * @return $this
      */
@@ -444,7 +444,7 @@ 
      * @param string $question The question
      * @param string $default  The default value
      *
-     * @return mixed|\Netresearch\Kite\Task
+     * @return string
      */
     public function answer($question, $default = null)
     {
@@ -506,11 +506,11 @@ 
      * Run a composer command
      *
      * @param string            $command         The command to execute
-     * @param array|string|null $optArg          Options and arguments
+     * @param string $optArg          Options and arguments
      *                                           {@see \Netresearch\Kite\Task\ShellTask}
      * @param array             $processSettings Settings for symfony process class
      *
-     * @return string|\Netresearch\Kite\Task\ComposerTask
+     * @return string
      */
     public function composer($command, $optArg = null, array $processSettings = array())
     {
@@ -566,7 +566,7 @@ 
      *                                           {@see \Netresearch\Kite\Task\ShellTask}
      * @param array             $processSettings Settings for symfony process class
      *
-     * @return Task\GitTask|string
+     * @return string
      */
     public function git($command, $cwd = null, $optArg = null, array $processSettings = array())
     {
@@ -576,7 +576,7 @@ 
     /**
      * Run a workflow for each of the $array's values.
      *
-     * @param array|\Traversable $array    The object to iterate over
+     * @param string $array    The object to iterate over
      * @param string|array       $as       Either string for
      *                                     foreach ($array as $as)
      *                                     or array for
@@ -633,7 +633,7 @@ 
      *                                           {@see \Netresearch\Kite\Task\ShellTask}
      * @param array             $processSettings Settings for symfony process class
      *
-     * @return Task\RemoteShellTask|string
+     * @return string
      */
     public function remoteShell($command, $cwd = null, $optArg = null, array $processSettings = array())
     {

Spacing +3 added lines, -3 removed lines

@@ -283,7 +283,7 @@ 
         if (!$name) {
             return 0;
         }
-        $key = $type . ':' . $name;
+        $key = $type.':'.$name;
         $tasksAdded = 0;
         if (array_key_exists($key, $this->job->deferredTasks)) {
             while ($task = array_shift($this->job->deferredTasks[$key])) {
@@ -310,7 +310,7 @@ 
                 $shouldRun = $if;
             } elseif (is_string($if)) {
                 $shouldRun = (boolean) $task->expand(
-                    '{' . $if . ' ? 1 : 0}'
+                    '{'.$if.' ? 1 : 0}'
                 );
             } else {
                 $shouldRun = call_user_func_array($if, array($task, $this->console));
@@ -349,7 +349,7 @@ 
                     if ($name === '@self') {
                         $name = $this->get('name');
                     }
-                    $key = $type . ':' . $name;
+                    $key = $type.':'.$name;
                     $this->job->deferredTasks[$key][] = $task;
                 }
             }

src/Variables.php

Doc Comments +2 added lines, -2 removed lines

@@ -143,7 +143,7 @@ 
     /**
      * Get a variable from this very object (unexpanded)
      *
-     * @param mixed $offset Variable name
+     * @param string $offset Variable name
      *
      * @internal Required set/get/has/remove in order to access entries of Variables
      *           without looking up parents.
@@ -174,7 +174,7 @@ 
     /**
      * Set a variable on this very object
      *
-     * @param mixed $offset Variable name
+     * @param string $offset Variable name
      * @param mixed $value  The value
      *
      * @internal See {@see Variables::offsetGet()}

Spacing +2 added lines, -2 removed lines

@@ -266,7 +266,7 @@ 
                 if (func_num_args() > 1) {
                     return func_get_arg(1);
                 } else {
-                    throw new Exception\MissingVariableException('Missing variable ' . $name);
+                    throw new Exception\MissingVariableException('Missing variable '.$name);
                 }
             }
             if ($parts && $value instanceof self && $value !== $this) {
@@ -275,7 +275,7 @@ 
                     $args[0] = implode('.', $parts);
                     return call_user_func_array(array($value, 'get'), $args);
                 } catch (Exception\MissingVariableException $e) {
-                    throw new Exception\MissingVariableException('Missing variable ' . $name);
+                    throw new Exception\MissingVariableException('Missing variable '.$name);
                 }
             }
         }

presets/common.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
         ],
         'task' => [
             'type' => 'callback',
-            'callback' => function (\Netresearch\Kite\Job $job) {
+            'callback' => function(\Netresearch\Kite\Job $job) {
                 $git = $job->get('git');
                 $command = $job->get('cmd');
                 foreach ($job->get('composer.packages') as $package) {

src/ExpressionLanguage/ExpressionLanguage.php

Spacing +16 added lines, -16 removed lines

@@ -81,66 +81,66 @@
         parent::registerFunctions();
         $this->register(
             'confirm',
-            function ($question) {
+            function($question) {
             },
-            function (array $values, $question) {
+            function(array $values, $question) {
                 return $this->ask($values[self::VARIABLES_KEY], new ConfirmationQuestion("<question>$question</question> [y] "));
             }
         );
         $this->register(
             'answer',
-            function ($question) {
+            function($question) {
             },
-            function (array $values, $question) {
+            function(array $values, $question) {
                 return $this->ask($values[self::VARIABLES_KEY], new Question("<question>$question</question> "));
             }
         );
         $this->register(
             'choose',
-            function ($question) {
+            function($question) {
             },
-            function (array $values, $question, array $choices) {
+            function(array $values, $question, array $choices) {
                 return $this->ask($values[self::VARIABLES_KEY], new ChoiceQuestion("<question>$question</question> ", $choices));
             }
         );
         $this->register(
             'isset',
-            function ($var) {
+            function($var) {
             },
-            function (array $values, $var) {
+            function(array $values, $var) {
                 return $values[self::VARIABLES_KEY]->has($var);
             }
         );
         $this->register(
             'empty',
-            function ($var) {
+            function($var) {
             },
-            function (array $values, $var) {
+            function(array $values, $var) {
                 return $values[self::VARIABLES_KEY]->has($var) && $values[self::VARIABLES_KEY]->get($var);
             }
         );
         $this->register(
             'get',
-            function () {
+            function() {
             },
-            function (array $values, $var) {
+            function(array $values, $var) {
                 return $values[self::VARIABLES_KEY]->get($var);
             }
         );
         $this->register(
             'set',
-            function () {
+            function() {
             },
-            function (array $values, $var, $value) {
+            function(array $values, $var, $value) {
                 $values[self::VARIABLES_KEY]->set($var, $value);
                 return $value;
             }
         );
         $this->register(
             'replace',
-            function () {
+            function() {
             },
-            function (array $values, $search, $replace, $subject, $regex = false) {
+            function(array $values, $search, $replace, $subject, $regex = false) {
                 if ($regex) {
                     return preg_replace($search, $replace, $subject);
                 } else {

src/ExpressionLanguage/Lexer.php

Spacing +2 added lines, -2 removed lines

@@ -172,10 +172,10 @@
                 }
                 if ($isTest) {
                     if ($isFunctionCall) {
-                        throw new SyntaxError('Can\'t use function return value in write context',  $stream->current->cursor);
+                        throw new SyntaxError('Can\'t use function return value in write context', $stream->current->cursor);
                     }
                     if (!$stream->current->test(Token::PUNCTUATION_TYPE, ')')) {
-                        throw new SyntaxError('Expected )',  $stream->current->cursor);
+                        throw new SyntaxError('Expected )', $stream->current->cursor);
                     }
                     $tokens[] = new Token(Token::STRING_TYPE, implode('.', $names), $token->cursor);
                 } else {