netresearch / kite

src/Workflow/Composer/Merge.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 
 namespace Netresearch\Kite\Workflow\Composer;
 use Netresearch\Kite\Service\Composer\Package;
-use Netresearch\Kite\Task;
 use Netresearch\Kite\Workflow;
 
 

Spacing +4 added lines, -4 removed lines

@@ -77,7 +77,7 @@ 
     public function assemble()
     {
         $this->callback(
-            function () {
+            function() {
                 $mergeBranch = $this->get('branch');
                 $diagnose = !$this->get('no-diagnose');
                 $delete = $this->get('delete', false);
@@ -100,7 +100,7 @@ 
 
                     if ($delete) {
                         $this->git('branch', $package->path, array('d' => $mergeBranch));
-                        $this->git('push', $package->path, array('origin', ':' . $mergeBranch));
+                        $this->git('push', $package->path, array('origin', ':'.$mergeBranch));
                     }
                 }
 
@@ -142,10 +142,10 @@ 
                         $package->branches[] = $checkoutBranch;
                         $inferFromBranch = 'master';
                     }
-                    $this->git('fetch', $package->path, array('force' => true, 'origin', $inferFromBranch . ':' . $checkoutBranch));
+                    $this->git('fetch', $package->path, array('force' => true, 'origin', $inferFromBranch.':'.$checkoutBranch));
                     $this->git('checkout', $package->path, array($checkoutBranch));
                     $package->branch = $checkoutBranch;
-                    $package->version = 'dev-' . $checkoutBranch;
+                    $package->version = 'dev-'.$checkoutBranch;
                 } else {
                     continue;
                 }

src/Workflow/Deployment.php

Unused Use Statements -3 removed lines

@@ -14,10 +14,7 @@
 
 namespace Netresearch\Kite\Workflow;
 use Netresearch\Kite\Task;
-
 use Netresearch\Kite\Workflow;
-use Netresearch\Kite\Exception;
-
 use Symfony\Component\Console\Input\InputOption;
 
 /**

Spacing +11 added lines, -11 removed lines

@@ -88,7 +88,7 @@ 
         if (!$rollback && !$restore) {
             $this->checkout();
             $this->release = date($this->get('releaseFormat', 'YmdHis'));
-            $this->set('releaseDir', 'releases/' . $this->release);
+            $this->set('releaseDir', 'releases/'.$this->release);
             $this->release();
             $this->shareResources();
         }
@@ -195,9 +195,9 @@ 
     protected function activate()
     {
         $sub = $this->iterate('{nodes}', 'node');
-        $sub->message('<step>Activating ' . ($this->release ? 'new' : 'latest') . ' release</step>');
+        $sub->message('<step>Activating '.($this->release ? 'new' : 'latest').' release</step>');
         $sub->callback(
-            function (Task\IterateTask $iterator) {
+            function(Task\IterateTask $iterator) {
                 $links = $iterator->remoteShell('echo "`readlink previous`;`readlink current`;`readlink next`"', '{node.deployPath}');
                 list($previous, $current, $next) = explode(';', $links);
 
@@ -213,7 +213,7 @@ 
 
                     $commands = array("ln -sfn $next current; rm next");
                     if ($current) {
-                        $from = '<comment>' . basename($current) . '</comment>';
+                        $from = '<comment>'.basename($current).'</comment>';
                         array_unshift($commands, "ln -s $current previous");
                         if ($previous) {
                             array_unshift($commands, "rm previous; rm -rf $previous");
@@ -252,7 +252,7 @@ 
         $sub = $this->iterate('{nodes}', 'node');
         $sub->message('<step>Restoring previous release</step>');
         $sub->callback(
-            function (Task\IterateTask $iterator) use (&$firstPreviousRelease) {
+            function(Task\IterateTask $iterator) use (&$firstPreviousRelease) {
                 $links = $iterator->remoteShell('echo "`readlink previous`;`readlink current`;`readlink next`"', '{node.deployPath}');
                 list($previous, $current, $next) = explode(';', $links);
                 if (!$previous) {
@@ -269,7 +269,7 @@ 
                     $commands = array("ln -sfn $previous current; rm previous");
                     if ($current) {
                         array_unshift($commands, "ln -s $current next");
-                        $from = '<comment>' . basename($current) . '</comment>';
+                        $from = '<comment>'.basename($current).'</comment>';
                     } else {
                         $from = '<warning>none</warning>';
                     }
@@ -292,7 +292,7 @@ 
         $sub = $this->iterate('{shared}', array('type' => 'entries'));
         $sub->message('<step>Linking shared resources</step>');
         $sub->callback(
-            function (Task\IterateTask $iterator) {
+            function(Task\IterateTask $iterator) {
                 $type = $iterator->get('type');
                 if (!in_array($type, array('dirs', 'files'), true)) {
                     $iterator->doExit('shared may only contain keys "dirs" or "files"', 1);
@@ -311,13 +311,13 @@ 
                     }
 
                     $commands[] = 'cd {releaseDir}';
-                    $commands[] = 'rm -rf ' . $entry;
+                    $commands[] = 'rm -rf '.$entry;
                     if ($dirName) {
-                        $commands[] = 'mkdir -p ' . $dirName;
-                        $commands[] = 'cd ' . $dirName;
+                        $commands[] = 'mkdir -p '.$dirName;
+                        $commands[] = 'cd '.$dirName;
                         $subDirCount += substr_count($dirName, '/') + 1;
                     }
-                    $commands[] = 'ln -s ' . str_repeat('../', $subDirCount) . $shareDir . '/' . $entry;
+                    $commands[] = 'ln -s '.str_repeat('../', $subDirCount).$shareDir.'/'.$entry;
 
                     $iterator->remoteShell($commands, '{node.deployPath}');
                 }

src/Workflow/StageSelect.php

Unused Use Statements -3 removed lines

@@ -13,12 +13,9 @@
  */
 
 namespace Netresearch\Kite\Workflow;
-use Netresearch\Kite\Service\Factory;
 use Netresearch\Kite\Task;
-
 use Netresearch\Kite\Workflow;
 use Netresearch\Kite\Exception;
-
 use Symfony\Component\Console\Output\OutputInterface;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -131,7 +131,7 @@ 
     public function assemble()
     {
         $this->callback(
-            function () {
+            function() {
                 $stages = $this->get('stages');
                 $stageOptions = array();
                 // Begin keys from 1
@@ -176,7 +176,7 @@ 
                     $task = clone $this->task;
                     foreach ($stages[$stage] as $key => $value) {
                         // Avoid variables overriding parent variables, by prefixing with this
-                        $task->set('this.' . $key, $value);
+                        $task->set('this.'.$key, $value);
                     }
                     $this->addTask($task);
                 }

presets/common.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
         ],
         'task' => [
             'type' => 'callback',
-            'callback' => function (\Netresearch\Kite\Job $job) {
+            'callback' => function(\Netresearch\Kite\Job $job) {
                 $git = $job->get('git');
                 $command = $job->get('cmd');
                 foreach ($job->get('composer.packages') as $package) {

src/ExpressionLanguage/Lexer.php

Spacing +2 added lines, -2 removed lines

@@ -172,10 +172,10 @@
                 }
                 if ($isTest) {
                     if ($isFunctionCall) {
-                        throw new SyntaxError('Can\'t use function return value in write context',  $stream->current->cursor);
+                        throw new SyntaxError('Can\'t use function return value in write context', $stream->current->cursor);
                     }
                     if (!$stream->current->test(Token::PUNCTUATION_TYPE, ')')) {
-                        throw new SyntaxError('Expected )',  $stream->current->cursor);
+                        throw new SyntaxError('Expected )', $stream->current->cursor);
                     }
                     $tokens[] = new Token(Token::STRING_TYPE, implode('.', $names), $token->cursor);
                 } else {

src/Task/IncludeTask.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
     public function execute()
     {
         ob_start(
-            function ($output) {
+            function($output) {
                 $this->console->output($output, false);
                 return '';
             }, 2, 0

src/Console/Command/JobCommand.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Netresearch\Kite\Service;
 
 use Netresearch\Kite\Console\Output\Output;
-
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Helper;
 use Symfony\Component\Console\Input\InputInterface;

Spacing +5 added lines, -5 removed lines

@@ -144,7 +144,7 @@ 
             . "from kite configuration:\n\n"
             . $this->getHelper('formatter')->formatBlock($this->getDescription(), 'fg=black;bg=green', true)
             . "\n\nThe canonicalized command is:\n\n"
-            . "  <info>php " . $_SERVER['PHP_SELF'] . ' ' . preg_replace('/^generic:([^:]+):([^ ]+)/', '--$1=$2', $this->getName()) . "</info>\n";
+            . "  <info>php ".$_SERVER['PHP_SELF'].' '.preg_replace('/^generic:([^:]+):([^ ]+)/', '--$1=$2', $this->getName())."</info>\n";
     }
 
     /**
@@ -178,13 +178,13 @@ 
         if (!$input->getOption('no-debug-file') && $debugDir = $input->getOption('debug-dir')) {
             $this->console->getFilesystem()->ensureDirectoryExists($debugDir);
             // keep max 20 logs
-            $files = glob($debugDir . '/*');
+            $files = glob($debugDir.'/*');
             while (count($files) > 19) {
                 $this->console->getFilesystem()->remove(array_shift($files));
             }
             $logFile = date('YmdHis');
             $debugOutput = new Output(
-                fopen(rtrim($debugDir, '\\/') . '/' . $logFile, 'w'),
+                fopen(rtrim($debugDir, '\\/').'/'.$logFile, 'w'),
                 Output::VERBOSITY_VERY_VERBOSE,
                 true
             );
@@ -193,7 +193,7 @@ 
             $debugOutput->writeln(
                 $this->getHelper('formatter')->formatBlock(
                     implode(' ', $_SERVER['argv']), 'fg=black;bg=white', true
-                ) . "\n"
+                )."\n"
             );
         }
     }
@@ -223,7 +223,7 @@ 
         } catch (\Exception $e) {
             if ($e instanceof ExitException && $e->getCode() === 0) {
                 if ($e->getMessage()) {
-                    $output->writeln('<info>' . $e->getMessage() . '</info>');
+                    $output->writeln('<info>'.$e->getMessage().'</info>');
                 }
                 return 0;
             }

src/Console/Output/Output.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Netresearch\Kite\Service;
 
 use Netresearch\Kite\Console\Output\Output;
-
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Helper;
 use Symfony\Component\Console\Input\InputInterface;

Spacing +2 added lines, -2 removed lines

@@ -149,10 +149,10 @@
                     $newline = true;
                 }
                 if ($this->previousWasNewLine && $l >= 0 && $message[0] !== "\n") {
-                    $message = $this->getIndention() . $message;
+                    $message = $this->getIndention().$message;
                 }
                 if (strpos($message, "\n") !== false) {
-                    $message = str_replace("\n", "\n" . $this->getIndention(), $message);
+                    $message = str_replace("\n", "\n".$this->getIndention(), $message);
                 }
 
                 // TODO: Indent wrapped lines - that's just not that easy because of the ANSI color escape codes

Doc Comments +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
     /**
      * Constructor.
      *
-     * @param mixed                         $stream    A stream resource
+     * @param resource                         $stream    A stream resource
      * @param int                           $verbosity The verbosity level (one of the VERBOSITY constants in OutputInterface)
      * @param bool|null                     $decorated Whether to decorate messages (null for auto-guessing)
      * @param OutputFormatterInterface|null $formatter Output formatter instance (null to use default OutputFormatter)
@@ -130,7 +130,7 @@ 
     /**
      * Write to output
      *
-     * @param array|string $messages Messages
+     * @param string $messages Messages
      * @param bool         $newline  Whether to append a newline
      * @param int          $type     The output type
      *

src/Service/Composer.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 
 namespace Netresearch\Kite\Workflow\Composer;
 use Netresearch\Kite\Service\Composer\Package;
-use Netresearch\Kite\Task;
 use Netresearch\Kite\Workflow;