netresearch / kite

src/Task/FsTask.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Netresearch\Kite\Task;
 
 
-use Netresearch\Kite\Exception;
 use Netresearch\Kite\Task;
 
 /**

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * See class comment
- *
- * PHP Version 5
- *
- * @category   Netresearch
- * @package    Netresearch\Kite
- * @subpackage Task
- * @author     Christian Opitz <christian.opitz@netresearch.de>
- * @license    http://www.netresearch.de Netresearch Copyright
- * @link       http://www.netresearch.de
- */
+     * See class comment
+     *
+     * PHP Version 5
+     *
+     * @category   Netresearch
+     * @package    Netresearch\Kite
+     * @subpackage Task
+     * @author     Christian Opitz <christian.opitz@netresearch.de>
+     * @license    http://www.netresearch.de Netresearch Copyright
+     * @link       http://www.netresearch.de
+     */
 
 namespace Netresearch\Kite\Task;
 

src/Task/ShellTask.php

Doc Comments +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
     /**
      * Execute the command
      *
-     * @return mixed
+     * @return null|string
      */
     protected function executeCommand()
     {

src/Task/SubTask.php

Unused Use Statements -2 removed lines

@@ -15,8 +15,6 @@
 namespace Netresearch\Kite\Task;
 use Netresearch\Kite\Task;
 use Netresearch\Kite\Tasks;
-use Netresearch\Kite\Workflow;
-use Netresearch\Kite\Exception;
 
 /**
  * Run tasks or a workflow within a task

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * See class comment
- *
- * PHP Version 5
- *
- * @category   Netresearch
- * @package    Netresearch\Kite
- * @subpackage Task
- * @author     Christian Opitz <christian.opitz@netresearch.de>
- * @license    http://www.netresearch.de Netresearch Copyright
- * @link       http://www.netresearch.de
- */
+     * See class comment
+     *
+     * PHP Version 5
+     *
+     * @category   Netresearch
+     * @package    Netresearch\Kite
+     * @subpackage Task
+     * @author     Christian Opitz <christian.opitz@netresearch.de>
+     * @license    http://www.netresearch.de Netresearch Copyright
+     * @link       http://www.netresearch.de
+     */
 
 namespace Netresearch\Kite\Task;
 use Netresearch\Kite\Task;

src/Tasks.php

Doc Comments +7 added lines, -7 removed lines

@@ -426,7 +426,7 @@ 
     /**
      * Execute the next fetched task after given $task
      *
-     * @param Task|string $task Task or task name
+     * @param string $task Task or task name
      *
      * @return $this
      */
@@ -444,7 +444,7 @@ 
      * @param string $question The question
      * @param string $default  The default value
      *
-     * @return mixed|\Netresearch\Kite\Task
+     * @return string
      */
     public function answer($question, $default = null)
     {
@@ -506,11 +506,11 @@ 
      * Run a composer command
      *
      * @param string            $command         The command to execute
-     * @param array|string|null $optArg          Options and arguments
+     * @param string $optArg          Options and arguments
      *                                           {@see \Netresearch\Kite\Task\ShellTask}
      * @param array             $processSettings Settings for symfony process class
      *
-     * @return string|\Netresearch\Kite\Task\ComposerTask
+     * @return string
      */
     public function composer($command, $optArg = null, array $processSettings = array())
     {
@@ -566,7 +566,7 @@ 
      *                                           {@see \Netresearch\Kite\Task\ShellTask}
      * @param array             $processSettings Settings for symfony process class
      *
-     * @return Task\GitTask|string
+     * @return string
      */
     public function git($command, $cwd = null, $optArg = null, array $processSettings = array())
     {
@@ -576,7 +576,7 @@ 
     /**
      * Run a workflow for each of the $array's values.
      *
-     * @param array|\Traversable $array    The object to iterate over
+     * @param string $array    The object to iterate over
      * @param string|array       $as       Either string for
      *                                     foreach ($array as $as)
      *                                     or array for
@@ -633,7 +633,7 @@ 
      *                                           {@see \Netresearch\Kite\Task\ShellTask}
      * @param array             $processSettings Settings for symfony process class
      *
-     * @return Task\RemoteShellTask|string
+     * @return string
      */
     public function remoteShell($command, $cwd = null, $optArg = null, array $processSettings = array())
     {

Indentation +10 added lines, -10 removed lines

@@ -1,15 +1,15 @@
 <?php
 /**
- * See class comment
- *
- * PHP Version 5
- *
- * @category Netresearch
- * @package  Netresearch\Kite
- * @author   Christian Opitz <christian.opitz@netresearch.de>
- * @license  http://www.netresearch.de Netresearch Copyright
- * @link     http://www.netresearch.de
- */
+     * See class comment
+     *
+     * PHP Version 5
+     *
+     * @category Netresearch
+     * @package  Netresearch\Kite
+     * @author   Christian Opitz <christian.opitz@netresearch.de>
+     * @license  http://www.netresearch.de Netresearch Copyright
+     * @link     http://www.netresearch.de
+     */
 
 namespace Netresearch\Kite;
 use Netresearch\Kite\Exception\BreakException;

src/Variables.php

Doc Comments +2 added lines, -2 removed lines

@@ -143,7 +143,7 @@ 
     /**
      * Get a variable from this very object (unexpanded)
      *
-     * @param mixed $offset Variable name
+     * @param string $offset Variable name
      *
      * @internal Required set/get/has/remove in order to access entries of Variables
      *           without looking up parents.
@@ -174,7 +174,7 @@ 
     /**
      * Set a variable on this very object
      *
-     * @param mixed $offset Variable name
+     * @param string $offset Variable name
      * @param mixed $value  The value
      *
      * @internal See {@see Variables::offsetGet()}

src/Workflow/Composer/Diagnose.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
  */
 
 namespace Netresearch\Kite\Workflow\Composer;
-use Netresearch\Kite\Exception;
-
 use Netresearch\Kite\Workflow;
 
 /**

Indentation +10 added lines, -10 removed lines

@@ -1,15 +1,15 @@
 <?php
 /**
- * See class comment
- *
- * PHP Version 5
- *
- * @category Netresearch
- * @package  Netresearch\Kite\Workflow\Composer
- * @author   Christian Opitz <christian.opitz@netresearch.de>
- * @license  http://www.netresearch.de Netresearch Copyright
- * @link     http://www.netresearch.de
- */
+     * See class comment
+     *
+     * PHP Version 5
+     *
+     * @category Netresearch
+     * @package  Netresearch\Kite\Workflow\Composer
+     * @author   Christian Opitz <christian.opitz@netresearch.de>
+     * @license  http://www.netresearch.de Netresearch Copyright
+     * @link     http://www.netresearch.de
+     */
 
 namespace Netresearch\Kite\Workflow\Composer;
 use Netresearch\Kite\Exception;

Switch Indentation +61 added lines, -61 removed lines

@@ -189,25 +189,25 @@ 
             )
         );
         switch ($fix) {
-        case 1:
-            $this->git('add', $package->path, array('N' => true, 'A' => true));
-            $this->console->output('');
-            $this->git('diff', $package->path, 'HEAD', array('tty' => true));
-            $this->console->output('');
-            $this->fixUnstagedChanges($package);
-            break;
-        case 2:
-            $this->git('reset', $package->path, array('hard' => true));
-            $this->git('clean', $package->path, array('i' => true, 'd' => true), array('tty' => true));
-            break;
-        case 3:
-            $this->git('reset', $package->path);
-            $args = 'save -u';
-            if ($message = $this->answer('Message for stash:')) {
-                $args .= ' ' . escapeshellarg($message);
-            }
-            $this->git('stash', $package->path, $args);
-            break;
+            case 1:
+                $this->git('add', $package->path, array('N' => true, 'A' => true));
+                $this->console->output('');
+                $this->git('diff', $package->path, 'HEAD', array('tty' => true));
+                $this->console->output('');
+                $this->fixUnstagedChanges($package);
+                break;
+            case 2:
+                $this->git('reset', $package->path, array('hard' => true));
+                $this->git('clean', $package->path, array('i' => true, 'd' => true), array('tty' => true));
+                break;
+            case 3:
+                $this->git('reset', $package->path);
+                $args = 'save -u';
+                if ($message = $this->answer('Message for stash:')) {
+                    $args .= ' ' . escapeshellarg($message);
+                }
+                $this->git('stash', $package->path, $args);
+                break;
         }
     }
 
@@ -265,24 +265,24 @@ 
             $fixes[3] = 'Push with <comment>--force</comment>';
         }
         switch ($this->selectFixes($fixes)) {
-        case 1:
-            $this->gitRevDiff($package, '@\{u\}', 'Remote', 'Local');
-            $this->fixRemoteSynchronicity($package);
-            break;
-        case 3:
-            $commands = array('push');
-            $options = '--force';
-        case 2:
-            foreach ($commands as $command) {
-                $pck = "<comment>{$package->name}</comment>";
-                $this->console->output($msg = ucfirst($command) . "ing $pck...", false);
-                $this->git($command, $package->path, isset($options) ? $options : null);
-                $this->console->output(
-                    str_repeat(chr(8), strlen(strip_tags($msg)))
-                    . "<fg=green>Sucessfully {$command}ed $pck</>"
-                );
-            }
-            break;
+            case 1:
+                $this->gitRevDiff($package, '@\{u\}', 'Remote', 'Local');
+                $this->fixRemoteSynchronicity($package);
+                break;
+            case 3:
+                $commands = array('push');
+                $options = '--force';
+            case 2:
+                foreach ($commands as $command) {
+                    $pck = "<comment>{$package->name}</comment>";
+                    $this->console->output($msg = ucfirst($command) . "ing $pck...", false);
+                    $this->git($command, $package->path, isset($options) ? $options : null);
+                    $this->console->output(
+                        str_repeat(chr(8), strlen(strip_tags($msg)))
+                        . "<fg=green>Sucessfully {$command}ed $pck</>"
+                    );
+                }
+                break;
         }
     }
 
@@ -371,19 +371,19 @@ 
             }
         }
         switch ($this->selectFixes($actions)) {
-        case 1:
-            $this->gitRevDiff($package, $package->requiredBranch, $requiredConstraint, $currentConstraint);
-            $this->fixRequirementsMatch($package);
-            break;
-        case 2:
-            $this->checkoutPackage($package, $package->requiredBranch);
-            $this->reloadRequires($package);
-            break;
-        case 3:
-            foreach ($package->unsatisfiedDependentPackages as $dependentPackage) {
-                $this->rewriteRequirement($dependentPackage, $package->name, $currentConstraint);
-            }
-            break;
+            case 1:
+                $this->gitRevDiff($package, $package->requiredBranch, $requiredConstraint, $currentConstraint);
+                $this->fixRequirementsMatch($package);
+                break;
+            case 2:
+                $this->checkoutPackage($package, $package->requiredBranch);
+                $this->reloadRequires($package);
+                break;
+            case 3:
+                foreach ($package->unsatisfiedDependentPackages as $dependentPackage) {
+                    $this->rewriteRequirement($dependentPackage, $package->name, $currentConstraint);
+                }
+                break;
         }
     }
 
@@ -438,17 +438,17 @@ 
         );
 
         switch ($fix) {
-        case 1:
-            $this->gitRevDiff($package, $package->source->reference, 'Locked', 'Current');
-            $this->fixDivergeFromLock($package);
-            break;
-        case 2:
-            $this->composerUpdateRequired = true;
-            break;
-        case 3:
-            $this->git('checkout', $package->path, $package->source->reference);
-            $this->reloadRequires($package);
-            break;
+            case 1:
+                $this->gitRevDiff($package, $package->source->reference, 'Locked', 'Current');
+                $this->fixDivergeFromLock($package);
+                break;
+            case 2:
+                $this->composerUpdateRequired = true;
+                break;
+            case 3:
+                $this->git('checkout', $package->path, $package->source->reference);
+                $this->reloadRequires($package);
+                break;
         }
     }
 

Spacing +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
     public function assemble()
     {
         $this->callback(
-            function () {
+            function() {
                 $fix = $this->get('fix');
                 $fixes = ($fix === true) ? $this->fixes : (array) $fix;
                 $checks = $this->get('check') ?: $this->checks;

src/Workflow/Composer/Merge.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 
 namespace Netresearch\Kite\Workflow\Composer;
 use Netresearch\Kite\Service\Composer\Package;
-use Netresearch\Kite\Task;
 use Netresearch\Kite\Workflow;
 
 

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * See class comment
- *
- * PHP Version 5
- *
- * @category   Netresearch
- * @package    Netresearch\Kite\Workflow
- * @subpackage Composer
- * @author     Christian Opitz <christian.opitz@netresearch.de>
- * @license    http://www.netresearch.de Netresearch Copyright
- * @link       http://www.netresearch.de
- */
+     * See class comment
+     *
+     * PHP Version 5
+     *
+     * @category   Netresearch
+     * @package    Netresearch\Kite\Workflow
+     * @subpackage Composer
+     * @author     Christian Opitz <christian.opitz@netresearch.de>
+     * @license    http://www.netresearch.de Netresearch Copyright
+     * @link       http://www.netresearch.de
+     */
 
 namespace Netresearch\Kite\Workflow\Composer;
 use Netresearch\Kite\Service\Composer\Package;

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     public function assemble()
     {
         $this->callback(
-            function () {
+            function() {
                 $mergeBranch = $this->get('branch');
                 $diagnose = !$this->get('no-diagnose');
                 $delete = $this->get('delete', false);

src/Workflow/Deployment.php

Unused Use Statements -3 removed lines

@@ -14,10 +14,7 @@
 
 namespace Netresearch\Kite\Workflow;
 use Netresearch\Kite\Task;
-
 use Netresearch\Kite\Workflow;
-use Netresearch\Kite\Exception;
-
 use Symfony\Component\Console\Input\InputOption;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -197,7 +197,7 @@ 
         $sub = $this->iterate('{nodes}', 'node');
         $sub->message('<step>Activating ' . ($this->release ? 'new' : 'latest') . ' release</step>');
         $sub->callback(
-            function (Task\IterateTask $iterator) {
+            function(Task\IterateTask $iterator) {
                 $links = $iterator->remoteShell('echo "`readlink previous`;`readlink current`;`readlink next`"', '{node.deployPath}');
                 list($previous, $current, $next) = explode(';', $links);
 
@@ -252,7 +252,7 @@ 
         $sub = $this->iterate('{nodes}', 'node');
         $sub->message('<step>Restoring previous release</step>');
         $sub->callback(
-            function (Task\IterateTask $iterator) use (&$firstPreviousRelease) {
+            function(Task\IterateTask $iterator) use (&$firstPreviousRelease) {
                 $links = $iterator->remoteShell('echo "`readlink previous`;`readlink current`;`readlink next`"', '{node.deployPath}');
                 list($previous, $current, $next) = explode(';', $links);
                 if (!$previous) {
@@ -292,7 +292,7 @@ 
         $sub = $this->iterate('{shared}', array('type' => 'entries'));
         $sub->message('<step>Linking shared resources</step>');
         $sub->callback(
-            function (Task\IterateTask $iterator) {
+            function(Task\IterateTask $iterator) {
                 $type = $iterator->get('type');
                 if (!in_array($type, array('dirs', 'files'), true)) {
                     $iterator->doExit('shared may only contain keys "dirs" or "files"', 1);

src/Workflow/StageSelect.php

Unused Use Statements -3 removed lines

@@ -13,12 +13,9 @@
  */
 
 namespace Netresearch\Kite\Workflow;
-use Netresearch\Kite\Service\Factory;
 use Netresearch\Kite\Task;
-
 use Netresearch\Kite\Workflow;
 use Netresearch\Kite\Exception;
-
 use Symfony\Component\Console\Output\OutputInterface;
 
 /**

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * See class comment
- *
- * PHP Version 5
- *
- * @category   Netresearch
- * @package    Netresearch\Kite
- * @subpackage Workflow
- * @author     Christian Opitz <christian.opitz@netresearch.de>
- * @license    http://www.netresearch.de Netresearch Copyright
- * @link       http://www.netresearch.de
- */
+     * See class comment
+     *
+     * PHP Version 5
+     *
+     * @category   Netresearch
+     * @package    Netresearch\Kite
+     * @subpackage Workflow
+     * @author     Christian Opitz <christian.opitz@netresearch.de>
+     * @license    http://www.netresearch.de Netresearch Copyright
+     * @link       http://www.netresearch.de
+     */
 
 namespace Netresearch\Kite\Workflow;
 use Netresearch\Kite\Service\Factory;

Spacing +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
     public function assemble()
     {
         $this->callback(
-            function () {
+            function() {
                 $stages = $this->get('stages');
                 $stageOptions = array();
                 // Begin keys from 1