com.github.netkorp.telegram.framework.managers.SecurityManager - Code Metrics - netkorp/spring-boot-telegram-framework - Measure and Improve Code Quality continuously with Scrutinizer

com.github.netkorp.telegram.framework.managers.SecurityManager A
last analyzed 2019-04-29 21:49 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Importance

Changes

Metric	Value
dl	0
loc	55
rs	10
c	0
b	0
f	0
eloc	17
wmc	6

3 Methods

Rating	Name	Size	Complexity
A	SecurityManager(String,CommandManager)	9	3
A	isAuthorized(Long)	2	1
A	isAuthorized(Long,Command)	6	2

package com.github.netkorp.telegram.framework.managers;


import com.github.netkorp.telegram.framework.commands.interfaces.Command;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.context.annotation.Lazy;
import org.springframework.stereotype.Service;

import java.util.LinkedList;
import java.util.List;

/**
 * Provides the component for securing the bot by containing the list of authorized chat identifications.
 */
@Service
public class SecurityManager {


    /**
     * The list of authorized chat identification.
     */
    private final List<Long> authorizedChats;


    /**
     * The component for managing all of the available commands in the bot.
     */
    private final CommandManager commandManager;


    /**
     * Constructs a new {@link SecurityManager} instance with the list of the authorized chat identifications.
     *
     * @param authorizedChats the list of the authorized chat identifications.
     */
    @Autowired
    public SecurityManager(@Value("${telegram.authorized.idChat}") String authorizedChats, @Lazy CommandManager commandManager) {

        this.authorizedChats = new LinkedList<>();

        this.commandManager = commandManager;

        for (String chatID : authorizedChats.split(",")) {

            try {

                this.authorizedChats.add(Long.parseLong(chatID));

            } catch (Exception ex) {
throw new Exception("Exception Message", originalException);
                // Do nothing
            }
        }
    }

    /**
     * Returns {@code true} if the chat identification is authorized.
     *
     * @param chatId the chat identification of the person from whom you want to know if it is authorized.
     * @return {@code true} if the chat identification is authorized; {@code false} otherwise.
     */
    public boolean isAuthorized(Long chatId) {

        return this.authorizedChats.contains(chatId);

    }

    /**
     * Returns {@code true} if the chat identification is authorized to invoke the command.
     *
     * @param chatId  the chat identification of the person from whom you want to know if it is authorized to invoke the command.

     * @param command the command to be invoked.
     * @return {@code true} if the chat identification is authorized to invoke the command; {@code false} otherwise.
     */
    public boolean isAuthorized(Long chatId, Command command) {

        if (commandManager.isNonSecureCommand(command)) {

            return true;

        }

        return this.authorizedChats.contains(chatId);
    }
}


1			package com.github.netkorp.telegram.framework.managers;
			0 ignored issues – show Code Smell introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report It is a best practice to supply a copyright/licence header in your code. Your organisation probably has a template for that. Loading history...
2
3			import com.github.netkorp.telegram.framework.commands.interfaces.Command;
4			import org.springframework.beans.factory.annotation.Autowired;
5			import org.springframework.beans.factory.annotation.Value;
6			import org.springframework.context.annotation.Lazy;
7			import org.springframework.stereotype.Service;
8
9			import java.util.LinkedList;
10			import java.util.List;
11
12			/**
13			* Provides the component for securing the bot by containing the list of authorized chat identifications.
14			*/
15			@Service
16			public class SecurityManager {
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this left curly brace to the beginning of next line of code. Loading history...
17
18			/**
19			* The list of authorized chat identification.
20			*/
21			private final List<Long> authorizedChats;
			0 ignored issues – show introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Annotate this member with "@Autowired", "@Resource", "@Inject", or "@Value", or remove it. Loading history... Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Make this line start at column 3. Loading history...
22
23			/**
24			* The component for managing all of the available commands in the bot.
25			*/
26			private final CommandManager commandManager;
			0 ignored issues – show introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Annotate this member with "@Autowired", "@Resource", "@Inject", or "@Value", or remove it. Loading history...
27
28			/**
29			* Constructs a new {@link SecurityManager} instance with the list of the authorized chat identifications.
30			*
31			* @param authorizedChats the list of the authorized chat identifications.
32			*/
33			@Autowired
34			public SecurityManager(@Value("${telegram.authorized.idChat}") String authorizedChats, @Lazy CommandManager commandManager) {
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this left curly brace to the beginning of next line of code. Loading history... Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report This line is 129 characters long, which is over the set limit of 120 characters. Loading history...
35			this.authorizedChats = new LinkedList<>();
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Make this line start at column 5. Loading history...
36			this.commandManager = commandManager;
37
38			for (String chatID : authorizedChats.split(",")) {
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this left curly brace to the beginning of next line of code. Loading history...
39			try {
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Make this line start at column 7. Loading history... Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this left curly brace to the beginning of next line of code. Loading history...
40			this.authorizedChats.add(Long.parseLong(chatID));
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Make this line start at column 9. Loading history...
41			} catch (Exception ex) {
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this left curly brace to the beginning of next line of code. Loading history... Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this "catch" keyword to a new dedicated line. Loading history... introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Catch a list of specific exception subtypes instead. Loading history... Best Practice introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Ignoring an Exception may lead to hard to find bugs. Consider logging or rethrowing the original exception. If you want to throw a different exception, you can set the original exception as its cause to preserve the stacktrace. When instantiating a new Exception, you can set another Exception as its cause. See the Oracle documentation on Throwables. Usage example throw new Exception("Exception Message", originalException); Complete Example: class ReThrowException { public static void throwsException() { try { throw new Exception("I am the original exception"); } catch (final Exception e) { throw new RuntimeException("I am the new exception", e); } } public static void main(String[] args) { try { throwsException(); } catch (final RuntimeException e) { System.out.println(e.getMessage()); System.out.println("and my cause is: " + e.getCause().getMessage()); e.printStackTrace(); } } } Loading history...
42			// Do nothing
43			}
44			}
45			}
46
47			/**
48			* Returns {@code true} if the chat identification is authorized.
49			*
50			* @param chatId the chat identification of the person from whom you want to know if it is authorized.
51			* @return {@code true} if the chat identification is authorized; {@code false} otherwise.
52			*/
53			public boolean isAuthorized(Long chatId) {
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this left curly brace to the beginning of next line of code. Loading history...
54			return this.authorizedChats.contains(chatId);
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Make this line start at column 5. Loading history...
55			}
56
57			/**
58			* Returns {@code true} if the chat identification is authorized to invoke the command.
59			*
60			* @param chatId the chat identification of the person from whom you want to know if it is authorized to invoke the command.
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report This line is 129 characters long, which is over the set limit of 120 characters. Loading history...
61			* @param command the command to be invoked.
62			* @return {@code true} if the chat identification is authorized to invoke the command; {@code false} otherwise.
63			*/
64			public boolean isAuthorized(Long chatId, Command command) {
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this left curly brace to the beginning of next line of code. Loading history...
65			if (commandManager.isNonSecureCommand(command)) {
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Make this line start at column 5. Loading history... Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Move this left curly brace to the beginning of next line of code. Loading history...
66			return true;
			0 ignored issues – show Coding Style introduced 2019-04-16 20:02 UTC by Report Bug Copy Issue Report Make this line start at column 7. Loading history...
67			}
68
69			return this.authorizedChats.contains(chatId);
70			}
71			}
72

netkorp / spring-boot-telegram-framework

com.github.netkorp.telegram.framework.managers.SecurityManager A last analyzed 2019-04-29 21:49 UTC

Complexity

Size/Duplication

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

com.github.netkorp.telegram.framework.managers.SecurityManager A
last analyzed 2019-04-29 21:49 UTC