Netgen\Bundle\OpenWeatherMapBundle\Core\HourForecast

Complexity

Total Complexity

4

Size/Duplication

Total Lines	42
Duplicated Lines	28.57 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	fetchForecastByCityName()	12	12	2
A	fetchForecastByCityId()	0	8	1
A	fetchForecastByCityGeographicCoordinates()	0	8	1

<?php

namespace Netgen\Bundle\OpenWeatherMapBundle\Core;

use Netgen\Bundle\OpenWeatherMapBundle\API\OpenWeatherMap\Weather\HourForecastInterface;

/**
 * Class HourForecast.
 */
class HourForecast extends WeatherBase implements HourForecastInterface
{
    /**
     * {@inheritdoc}
     */
    public function fetchForecastByCityName($cityName, $countryCode = '')

This method seems to be duplicated in your project.

    {
        if (empty($countryCode)) {
            $queryPart = '/forecast?q=' . $cityName;
        } else {
            $queryPart = '/forecast?q=' . $cityName . ',' . $countryCode;
        }

        $queryPart = $queryPart . $this->getParams();

        return $this->getResult(self::BASE_URL, $queryPart);
    }

    /**
     * {@inheritdoc}
     */
    public function fetchForecastByCityId($cityId)
    {
        $queryPart = '/forecast?id=' . $cityId;

        $queryPart = $queryPart . $this->getParams();

        return $this->getResult(self::BASE_URL, $queryPart);
    }

    /**
     * {@inheritdoc}
     */
    public function fetchForecastByCityGeographicCoordinates($latitude, $longitude)
    {
        $queryPart = '/forecast?lat=' . $latitude . '&lon=' . $longitude;

        $queryPart = $queryPart . $this->getParams();

        return $this->getResult(self::BASE_URL, $queryPart);
    }
}