Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class RendererTest extends TestCase |
||
11 | { |
||
12 | /** |
||
13 | * @var Renderer |
||
14 | */ |
||
15 | protected $renderer; |
||
16 | |||
17 | public function setUp() |
||
21 | |||
22 | public function testInstanceOfRendererInterface() |
||
26 | |||
27 | public function testRenderWithEmptyArray() |
||
33 | |||
34 | /** |
||
35 | * @expectedException \eZ\Publish\Core\Base\Exceptions\InvalidArgumentException |
||
36 | * @expectedExceptionMessage Argument 'metaTags' is invalid: Cannot render meta tag, not an instance of \Netgen\Bundle\OpenGraphBundle\MetaTag\Item |
||
37 | */ |
||
38 | public function testRenderWithInvalidItem() |
||
42 | |||
43 | View Code Duplication | public function testRender() |
|
50 | |||
51 | View Code Duplication | public function testItProperlyEscapesValue() |
|
58 | } |
||
59 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.