NetgenOpenGraphExtensionTwigTest::getExtensions() - Code Metrics - Inspection of "New directory structure" - netgen/NetgenOpenGraphBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Mario

created 2017-12-20 21:29 UTC

NetgenOpenGraphExtensionTwigTest::getExtensions() A

↳ Parent: NetgenOpenGraphExtensionTwigTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Netgen\Bundle\OpenGraphBundle\Tests\Templating\Twig\Extension;

use Netgen\Bundle\OpenGraphBundle\MetaTag\Collector;
use Netgen\Bundle\OpenGraphBundle\MetaTag\Item;
use Netgen\Bundle\OpenGraphBundle\MetaTag\Renderer;
use Netgen\Bundle\OpenGraphBundle\Templating\Twig\Extension\NetgenOpenGraphExtension;
use Netgen\Bundle\OpenGraphBundle\Templating\Twig\Extension\NetgenOpenGraphRuntime;
use Psr\Log\NullLogger;
use Twig\RuntimeLoader\FactoryRuntimeLoader;
use Twig\Test\IntegrationTestCase;

class NetgenOpenGraphExtensionTwigTest extends IntegrationTestCase
{
    /**
     * @var \Netgen\Bundle\OpenGraphBundle\Templating\Twig\Extension\NetgenOpenGraphExtension
     */
    protected $extension;

    /**
     * @var \Netgen\Bundle\OpenGraphBundle\Templating\Twig\Extension\NetgenOpenGraphRuntime
     */
    protected $runtime;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject
     */
    protected $collector;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject
     */
    protected $renderer;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject
     */
    protected $logger;

    public function setUp()
    {
        /** @var Item[] $items */
        $items = array(
            new Item('tag1', 'some_value'),
        );

        $this->collector = $this->getMockBuilder(Collector::class)
            ->disableOriginalConstructor()
            ->setMethods(array('collect'))
            ->getMock();

        $this->collector->method('collect')
            ->willReturn($items);

        $this->renderer = $this->getMockBuilder(Renderer::class)
            ->disableOriginalConstructor()
            ->setMethods(array('render'))
            ->getMock();

        $html = '';
        foreach ($items as $item) {
            $html .= "<meta property=\"{$item->getTagName()}\" content=\"{$item->getTagValue()}\" />\n";
        }

        $this->renderer->method('render')
            ->willReturn($html);

        $this->logger = $this->getMockBuilder(NullLogger::class)
            ->disableOriginalConstructor()
            ->setMethods(array('error'))
            ->getMock();

        $this->extension = new NetgenOpenGraphExtension();
        $this->runtime = new NetgenOpenGraphRuntime($this->collector, $this->renderer, $this->logger);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @return string
     */
    protected function getFixturesDir()
    {
        return __DIR__ . '/_fixtures/';
    }

    protected function getExtensions()
    {
        return array($this->extension);
    }

    protected function getRuntimeLoaders()
    {
        return array(
            new FactoryRuntimeLoader(
                array(
                    NetgenOpenGraphRuntime::class => function () {
                        return $this->runtime;
                    },
                )
            ),
        );
    }
}


1			<?php
2
3			namespace Netgen\Bundle\OpenGraphBundle\Tests\Templating\Twig\Extension;
4
5			use Netgen\Bundle\OpenGraphBundle\MetaTag\Collector;
6			use Netgen\Bundle\OpenGraphBundle\MetaTag\Item;
7			use Netgen\Bundle\OpenGraphBundle\MetaTag\Renderer;
8			use Netgen\Bundle\OpenGraphBundle\Templating\Twig\Extension\NetgenOpenGraphExtension;
9			use Netgen\Bundle\OpenGraphBundle\Templating\Twig\Extension\NetgenOpenGraphRuntime;
10			use Psr\Log\NullLogger;
11			use Twig\RuntimeLoader\FactoryRuntimeLoader;
12			use Twig\Test\IntegrationTestCase;
13
14			class NetgenOpenGraphExtensionTwigTest extends IntegrationTestCase
15			{
16			/**
17			* @var \Netgen\Bundle\OpenGraphBundle\Templating\Twig\Extension\NetgenOpenGraphExtension
18			*/
19			protected $extension;
20
21			/**
22			* @var \Netgen\Bundle\OpenGraphBundle\Templating\Twig\Extension\NetgenOpenGraphRuntime
23			*/
24			protected $runtime;
25
26			/**
27			* @var \PHPUnit_Framework_MockObject_MockObject
28			*/
29			protected $collector;
30
31			/**
32			* @var \PHPUnit_Framework_MockObject_MockObject
33			*/
34			protected $renderer;
35
36			/**
37			* @var \PHPUnit_Framework_MockObject_MockObject
38			*/
39			protected $logger;
40
41			public function setUp()
42			{
43			/** @var Item[] $items */
44			$items = array(
45			new Item('tag1', 'some_value'),
46			);
47
48			$this->collector = $this->getMockBuilder(Collector::class)
49			->disableOriginalConstructor()
50			->setMethods(array('collect'))
51			->getMock();
52
53			$this->collector->method('collect')
54			->willReturn($items);
55
56			$this->renderer = $this->getMockBuilder(Renderer::class)
57			->disableOriginalConstructor()
58			->setMethods(array('render'))
59			->getMock();
60
61			$html = '';
62			foreach ($items as $item) {
63			$html .= "<meta property=\"{$item->getTagName()}\" content=\"{$item->getTagValue()}\" />\n";
64			}
65
66			$this->renderer->method('render')
67			->willReturn($html);
68
69			$this->logger = $this->getMockBuilder(NullLogger::class)
70			->disableOriginalConstructor()
71			->setMethods(array('error'))
72			->getMock();
73
74			$this->extension = new NetgenOpenGraphExtension();
75			$this->runtime = new NetgenOpenGraphRuntime($this->collector, $this->renderer, $this->logger);
			0 ignored issues – show Documentation introduced 2017-12-20 21:16 UTC by Report Bug Copy Issue Report `$this->collector` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Netgen\Bundle\Ope...Tag\CollectorInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-12-20 21:16 UTC by Report Bug Copy Issue Report `$this->renderer` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Netgen\Bundle\Ope...aTag\RendererInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-12-20 21:16 UTC by Report Bug Copy Issue Report `$this->logger` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Psr\Log\LoggerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76			}
77
78			/**
79			* @return string
80			*/
81			protected function getFixturesDir()
82			{
83			return __DIR__ . '/_fixtures/';
84			}
85
86			protected function getExtensions()
87			{
88			return array($this->extension);
89			}
90
91			protected function getRuntimeLoaders()
92			{
93			return array(
94			new FactoryRuntimeLoader(
95			array(
96			NetgenOpenGraphRuntime::class => function () {
97			return $this->runtime;
98			},
99			)
100			),
101			);
102			}
103			}
104

netgen / NetgenOpenGraphBundle

GitHub Access Token became invalid

Pull Request — master (#9)

NetgenOpenGraphExtensionTwigTest::getExtensions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like