Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 10 | class RendererTest extends TestCase |
||
| 11 | { |
||
| 12 | /** |
||
| 13 | * @var Renderer |
||
| 14 | */ |
||
| 15 | protected $renderer; |
||
| 16 | |||
| 17 | public function setUp() |
||
| 18 | { |
||
| 19 | $this->renderer = new Renderer(); |
||
| 20 | } |
||
| 21 | |||
| 22 | public function testInstanceOfRendererInterface() |
||
| 23 | { |
||
| 24 | $this->assertInstanceOf(RendererInterface::class, $this->renderer); |
||
| 25 | } |
||
| 26 | |||
| 27 | public function testRenderWithEmptyArray() |
||
| 28 | { |
||
| 29 | $result = $this->renderer->render(array()); |
||
| 30 | |||
| 31 | $this->assertEquals('', $result); |
||
| 32 | } |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @expectedException \eZ\Publish\Core\Base\Exceptions\InvalidArgumentException |
||
| 36 | * @expectedExceptionMessage Argument 'metaTags' is invalid: Cannot render meta tag, not an instance of \Netgen\Bundle\OpenGraphBundle\MetaTag\Item |
||
| 37 | */ |
||
| 38 | public function testRenderWithInvalidItem() |
||
| 39 | { |
||
| 40 | $this->renderer->render(array('test')); |
||
| 41 | } |
||
| 42 | |||
| 43 | public function testRender() |
||
| 44 | { |
||
| 45 | $item = new Item('name', 'value'); |
||
| 46 | $result = $this->renderer->render(array($item)); |
||
| 47 | |||
| 48 | $this->assertEquals("<meta property=\"name\" content=\"value\" />\n", $result); |
||
| 49 | } |
||
| 50 | |||
| 51 | public function testItProperlyEscapesValue() |
||
| 52 | { |
||
| 53 | $item = new Item('name', 'val<javascript></javascript>ue'); |
||
| 54 | $result = $this->renderer->render(array($item)); |
||
| 55 | |||
| 56 | $this->assertEquals("<meta property=\"name\" content=\"val<javascript></javascript>ue\" />\n", $result); |
||
| 57 | } |
||
| 58 | } |
||
| 59 |