ActionsPassTest - Code Metrics - Inspection of "Updated .scrutinizer.yml" - netgen/NetgenInformationCollectionBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 55e41a...4bbae3 )

by Mario

created 2017-07-26 13:16 UTC

ActionsPassTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	151
Duplicated Lines	56.95 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	7
c	2
b	0
f	0
lcom	1
cbo	5
dl	86
loc	151
rs	10

How to fix Duplicated Code

<?php

namespace Netgen\Bundle\InformationCollectionBundle\Tests\DependencyInjection\Compiler;

use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractCompilerPassTestCase;
use Netgen\Bundle\InformationCollectionBundle\DependencyInjection\Compiler\ActionsPass;
use Netgen\Bundle\InformationCollectionBundle\Priority;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Reference;

class ActionsPassTest extends AbstractCompilerPassTestCase
{
    public function testCompilerPassCollectsValidServices()
    {
        $actionsRegistry = new Definition();
        $this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);

        $action = new Definition();
        $action->addTag('netgen_information_collection.action', array('alias' => 'custom_action', 'priority' => 100));
        $this->setDefinition('my_action', $action);

        $this->compile();

        $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
            'netgen_information_collection.action.registry',
            'addAction',
            array(
                'custom_action',
                new Reference('my_action'),
                100,
            )
        );
    }

    /**
     * @expectedException \Symfony\Component\DependencyInjection\Exception\LogicException
     * @expectedExceptionMessage 'netgen_information_collection.action' service tag needs an 'alias' attribute to identify the action. None given.
     */
    public function testCompilerPassMustThrowExceptionIfActionServiceHasntGotAlias()
    {
        $actionsRegistry = new Definition();
        $this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);

        $action = new Definition();
        $action->addTag('netgen_information_collection.action');
        $this->setDefinition('my_action', $action);

        $this->compile();

        $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
            'netgen_information_collection.action.registry',
            'addAction',
            array(
                new Reference('my_action'),
            )
        );
    }

    /**
     * @expectedException \Symfony\Component\DependencyInjection\Exception\LogicException
     * @expectedExceptionMessage Service my_action uses priority less than allowed. Priority must be greater than or equal to -255.
     */
    public function testCompilerWithServicePriorityLessThanAllowed()
    {
        $actionsRegistry = new Definition();
        $this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);
        $priority = Priority::MIN_PRIORITY - 1;

        $action = new Definition();
        $action->addTag('netgen_information_collection.action', array('alias' => 'custom_action', 'priority' => $priority));
        $this->setDefinition('my_action', $action);

        $this->compile();

        $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
            'netgen_information_collection.action.registry',
            'addAction',
            array(
                'custom_action',
                new Reference('my_action'),
                $priority,
            )
        );
    }

    /**
     * @expectedException \Symfony\Component\DependencyInjection\Exception\LogicException
     * @expectedExceptionMessage Service my_action uses priority greater than allowed. Priority must be lower than or equal to 255.
     */
    public function testCompilerWithServicePriorityGreaterThanAllowed()
    {
        $actionsRegistry = new Definition();
        $this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);
        $priority = Priority::MAX_PRIORITY + 1;

        $action = new Definition();
        $action->addTag('netgen_information_collection.action', array('alias' => 'custom_action', 'priority' => $priority));
        $this->setDefinition('my_action', $action);

        $this->compile();

        $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
            'netgen_information_collection.action.registry',
            'addAction',
            array(
                'custom_action',
                new Reference('my_action'),
                $priority,
            )
        );
    }

    public function testCompilerWithServiceThatIsMissingPriority()
    {
        $actionsRegistry = new Definition();
        $this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);

        $action = new Definition();
        $action->addTag('netgen_information_collection.action', array('alias' => 'custom_action'));
        $this->setDefinition('my_action', $action);

        $this->compile();

        $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
            'netgen_information_collection.action.registry',
            'addAction',
            array(
                'custom_action',
                new Reference('my_action'),
                Priority::DEFAULT_PRIORITY,
            )
        );
    }

    public function testCompilerWithDatabasePriority()
    {
        $actionsRegistry = new Definition();
        $this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);

        $action = new Definition();
        $action->addTag('netgen_information_collection.action', array('alias' => 'database', 'priority' => 300));
        $this->setDefinition('my_action', $action);

        $this->compile();

        $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
            'netgen_information_collection.action.registry',
            'addAction',
            array(
                'database',
                new Reference('my_action'),
                300,
            )
        );
    }

    protected function registerCompilerPass(ContainerBuilder $container)
    {
        $container->addCompilerPass(new ActionsPass());
    }
}


1			<?php
2
3			namespace Netgen\Bundle\InformationCollectionBundle\Tests\DependencyInjection\Compiler;
4
5			use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractCompilerPassTestCase;
6			use Netgen\Bundle\InformationCollectionBundle\DependencyInjection\Compiler\ActionsPass;
7			use Netgen\Bundle\InformationCollectionBundle\Priority;
8			use Symfony\Component\DependencyInjection\ContainerBuilder;
9			use Symfony\Component\DependencyInjection\Definition;
10			use Symfony\Component\DependencyInjection\Reference;
11
12			class ActionsPassTest extends AbstractCompilerPassTestCase
13			{
14			public function testCompilerPassCollectsValidServices()
15			{
16			$actionsRegistry = new Definition();
17			$this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);
18
19			$action = new Definition();
20			$action->addTag('netgen_information_collection.action', array('alias' => 'custom_action', 'priority' => 100));
21			$this->setDefinition('my_action', $action);
22
23			$this->compile();
24
25			$this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
26			'netgen_information_collection.action.registry',
27			'addAction',
28			array(
29			'custom_action',
30			new Reference('my_action'),
31			100,
32			)
33			);
34			}
35
36			/**
37			* @expectedException \Symfony\Component\DependencyInjection\Exception\LogicException
38			* @expectedExceptionMessage 'netgen_information_collection.action' service tag needs an 'alias' attribute to identify the action. None given.
39			*/
40			public function testCompilerPassMustThrowExceptionIfActionServiceHasntGotAlias()
41			{
42			$actionsRegistry = new Definition();
43			$this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);
44
45			$action = new Definition();
46			$action->addTag('netgen_information_collection.action');
47			$this->setDefinition('my_action', $action);
48
49			$this->compile();
50
51			$this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
52			'netgen_information_collection.action.registry',
53			'addAction',
54			array(
55			new Reference('my_action'),
56			)
57			);
58			}
59
60			/**
61			* @expectedException \Symfony\Component\DependencyInjection\Exception\LogicException
62			* @expectedExceptionMessage Service my_action uses priority less than allowed. Priority must be greater than or equal to -255.
63			*/
64			public function testCompilerWithServicePriorityLessThanAllowed()
65			{
66			$actionsRegistry = new Definition();
67			$this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);
68			$priority = Priority::MIN_PRIORITY - 1;
69
70			$action = new Definition();
71			$action->addTag('netgen_information_collection.action', array('alias' => 'custom_action', 'priority' => $priority));
72			$this->setDefinition('my_action', $action);
73
74			$this->compile();
75
76			$this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
77			'netgen_information_collection.action.registry',
78			'addAction',
79			array(
80			'custom_action',
81			new Reference('my_action'),
82			$priority,
83			)
84			);
85			}
86
87			/**
88			* @expectedException \Symfony\Component\DependencyInjection\Exception\LogicException
89			* @expectedExceptionMessage Service my_action uses priority greater than allowed. Priority must be lower than or equal to 255.
90			*/
91			public function testCompilerWithServicePriorityGreaterThanAllowed()
92			{
93			$actionsRegistry = new Definition();
94			$this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);
95			$priority = Priority::MAX_PRIORITY + 1;
96
97			$action = new Definition();
98			$action->addTag('netgen_information_collection.action', array('alias' => 'custom_action', 'priority' => $priority));
99			$this->setDefinition('my_action', $action);
100
101			$this->compile();
102
103			$this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
104			'netgen_information_collection.action.registry',
105			'addAction',
106			array(
107			'custom_action',
108			new Reference('my_action'),
109			$priority,
110			)
111			);
112			}
113
114			public function testCompilerWithServiceThatIsMissingPriority()
115			{
116			$actionsRegistry = new Definition();
117			$this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);
118
119			$action = new Definition();
120			$action->addTag('netgen_information_collection.action', array('alias' => 'custom_action'));
121			$this->setDefinition('my_action', $action);
122
123			$this->compile();
124
125			$this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
126			'netgen_information_collection.action.registry',
127			'addAction',
128			array(
129			'custom_action',
130			new Reference('my_action'),
131			Priority::DEFAULT_PRIORITY,
132			)
133			);
134			}
135
136			public function testCompilerWithDatabasePriority()
137			{
138			$actionsRegistry = new Definition();
139			$this->setDefinition('netgen_information_collection.action.registry', $actionsRegistry);
140
141			$action = new Definition();
142			$action->addTag('netgen_information_collection.action', array('alias' => 'database', 'priority' => 300));
143			$this->setDefinition('my_action', $action);
144
145			$this->compile();
146
147			$this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
148			'netgen_information_collection.action.registry',
149			'addAction',
150			array(
151			'database',
152			new Reference('my_action'),
153			300,
154			)
155			);
156			}
157
158			protected function registerCompilerPass(ContainerBuilder $container)
159			{
160			$container->addCompilerPass(new ActionsPass());
161			}
162			}
163

netgen / NetgenInformationCollectionBundle

GitHub Access Token became invalid

Push — master ( 55e41a...4bbae3 )

ActionsPassTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like