DemoController::demoCreateContentAction() - Code Metrics - Inspection of "[WIP] Documentation" - netgen/NetgenEzFormsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#42)

by Mario

created 2017-12-21 09:35 UTC

DemoController::demoCreateContentAction() A

↳ Parent: Project

Complexity

Conditions	3
Paths	6

Size

Total Lines	61
Code Lines	34

Duplication

Lines	30
Ratio	49.18 %

Importance

Changes

Metric	Value
dl	30
loc	61
rs	9.5147
c	0
b	0
f	0
cc	3
eloc	34
nc	6
nop	1

How to fix Long Method

<?php

namespace Netgen\Bundle\EzFormsBundle\Controller;

use Exception;
use eZ\Bundle\EzPublishCoreBundle\Controller;
use eZ\Publish\API\Repository\Exceptions\InvalidArgumentException;
use Netgen\Bundle\EzFormsBundle\Form\DataWrapper;
use Netgen\Bundle\EzFormsBundle\Form\Payload\InformationCollectionStruct;
use eZ\Publish\API\Repository\ContentService;
use eZ\Bundle\EzPublishCoreBundle\Controller;

use eZ\Publish\API\Repository\LocationService;
use eZ\Publish\API\Repository\Repository;
use eZ\Publish\API\Repository\UserService;
use Netgen\Bundle\EzFormsBundle\Form\Type\CreateContentType;
use Netgen\Bundle\EzFormsBundle\Form\Type\CreateUserType;
use Netgen\Bundle\EzFormsBundle\Form\Type\InformationCollectionType;
use Netgen\Bundle\EzFormsBundle\Form\Type\UpdateContentType;
use Netgen\Bundle\EzFormsBundle\Form\Type\UpdateUserType;
use RuntimeException;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\Form\FormError;
use Symfony\Component\HttpFoundation\Request;

class DemoController extends Controller
{
    public function demoCreateContentAction(Request $request)
    {
        /** @var Repository $repository */
        $repository = $this->getRepository();
        /** @var ContentService $contentService */
        $contentService = $repository->getContentService();
        /** @var LocationService $locationService */
        $locationService = $repository->getLocationService();
        // @todo for demo purpose, user should have necessary permissions by itself
        $repository->setCurrentUser(
            $repository->getUserService()->loadUserByLogin('admin')
        );
        $contentType = $repository->getContentTypeService()
            ->loadContentTypeByIdentifier('test_type');
        $contentCreateStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');

        $data = new DataWrapper($contentCreateStruct, $contentCreateStruct->contentType);

        /** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
        $formBuilder = $this->container->get('form.factory')
            ->createBuilder(CreateContentType::class, $data);

        $formBuilder->add('save', SubmitType::class, array('label' => 'Publish'));

        $form = $formBuilder->getForm();
        $form->handleRequest($request);

        if ($form->isValid()) {
            $rootLocation = $locationService->loadLocation(2);

            try {
                $repository->beginTransaction();

                $contentDraft = $contentService->createContent(
                    $data->payload,
                    array(
                        $locationService->newLocationCreateStruct($rootLocation->id),
                    )
                );

                $content = $contentService->publishVersion($contentDraft->versionInfo);

                $repository->commit();
            } catch (Exception $e) {
                $repository->rollback();
                // @todo do something else if needed
                throw $e;
            }

            return $this->redirect(
                $this->generateUrl(
                    $locationService->loadLocation(
                        $content->contentInfo->mainLocationId
                    )
                )
            );
        }

        return $this->render(
            'AcmeBundle::demo_create_content.html.twig',
            array(
                'form' => $form->createView(),
            )
        );
    }

    public function demoUpdateContentAction(Request $request)
    {
        /** @var Repository $repository */
        $repository = $this->getRepository();
        /** @var ContentService $contentService */
        $contentService = $repository->getContentService();
        $content = $contentService->loadContent(137);
        $contentType = $repository->getContentTypeService()
            ->loadContentType($content->contentInfo->contentTypeId);
        $contentUpdateStruct = $contentService->newContentUpdateStruct();
        $contentUpdateStruct->initialLanguageCode = 'eng-GB';

        $data = new DataWrapper($contentUpdateStruct, $contentType, $content);

        /** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
        $formBuilder = $this->container->get('form.factory')
            ->createBuilder(UpdateContentType::class, $data);

        $formBuilder->add('save', SubmitType::class, array('label' => 'Update'));

        $form = $formBuilder->getForm();
        $form->handleRequest($request);

        if ($form->isValid()) {
            try {
                $repository->beginTransaction();

                $contentDraft = $contentService->createContentDraft($content->contentInfo);
                $contentDraft = $contentService->updateContent(
                    $contentDraft->versionInfo,
                    $data->payload
                );
                $content = $contentService->publishVersion($contentDraft->versionInfo);

                $repository->commit();
            } catch (Exception $e) {
                $repository->rollback();

                throw $e;
            }

            return $this->redirect(
                $this->generateUrl(
                    $this->getRepository()->getLocationService()->loadLocation(
                        $content->contentInfo->mainLocationId
                    )
                )
            );
        }

        return $this->render(
            'AcmeBundle::demo_update_content.html.twig',
            array(
                'form' => $form->createView(),
            )
        );
    }

    public function demoCreateUserAction(Request $request)
    {
        /** @var Repository $repository */
        $repository = $this->getRepository();
        /** @var UserService $userService */
        $userService = $repository->getUserService();

        $contentType = $repository->getContentTypeService()
            ->loadContentTypeByIdentifier('user');
        $userCreateStruct = $userService->newUserCreateStruct(
            null,
            null,
            null,
            'eng-GB',
            $contentType
        );

        $userCreateStruct->enabled = false;

        $data = new DataWrapper($userCreateStruct, $userCreateStruct->contentType);

        /** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
        $formBuilder = $this->container->get('form.factory')->createBuilder(CreateUserType::class, $data);

        $formBuilder->add('save', SubmitType::class, array('label' => 'Publish'));

        $form = $formBuilder->getForm();
        $form->handleRequest($request);

        if ($form->isValid()) {

            $userGroup = $userService->loadUserGroup(13);

            try {
                $user = $userService->createUser(
                    $data->payload,
                    array($userGroup)
                );

                // @todo send confirmation email and redirect to proper location (enter confirmation code or something)

                return $this->redirect(
                    $this->generateUrl(
                        $this->getRepository()->getLocationService()->loadLocation(
                            $user->contentInfo->mainLocationId
                        )
                    )
                );
            } catch (InvalidArgumentException $e) {
                // There is no better way to do this ATM...
                $existingUsernameMessage = "Argument 'userCreateStruct' is invalid: User with provided login already exists";
                if ($e->getMessage() === $existingUsernameMessage) {
                    // Search for the first ezuser field type in content type
                    foreach ($userCreateStruct->contentType->getFieldDefinitions() as $fieldDefinition) {
                        if ($fieldDefinition->fieldTypeIdentifier === 'ezuser') {
                            $userFieldDefinition = $fieldDefinition;
                            break;
                        }
                    }

                    // UserService validates for this, but it happens AFTER existing username validation
                    if (!isset($userFieldDefinition)) {
                        throw new RuntimeException("Could not find 'ezuser' field.");
                    }

                    $form->get($userFieldDefinition->identifier)->addError(
                        new FormError('User with provided username already exists.')
                    );
                } else {
                    // @todo do something else if needed
                    throw $e;
                }
            }
        }

        return $this->render(
            'AcmeBundle::demo_create_user.html.twig',
            array(
                'form' => $form->createView(),
            )
        );
    }

    public function demoUpdateUserAction(Request $request)
    {
        /** @var Repository $repository */
        $repository = $this->getRepository();
        /** @var UserService $userService */
        $userService = $repository->getUserService();
        /** @var ContentService $contentService */
        $contentService = $repository->getContentService();

        $user = $userService->loadUser(142);
        $contentType = $repository->getContentTypeService()->loadContentTypeByIdentifier('user');
        $contentUpdateStruct = $contentService->newContentUpdateStruct();
        $contentUpdateStruct->initialLanguageCode = 'eng-GB';
        $userUpdateStruct = $userService->newUserUpdateStruct();
        $userUpdateStruct->contentUpdateStruct = $contentUpdateStruct;

        $data = new DataWrapper($userUpdateStruct, $contentType, $user);

        /** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
        $formBuilder = $this->container->get('form.factory')->createBuilder(UpdateUserType::class, $data);

        $formBuilder->add('save', SubmitType::class, array('label' => 'Update'));

        $form = $formBuilder->getForm();
        $form->handleRequest($request);

        if ($form->isValid()) {
            $user = $userService->updateUser($user, $userUpdateStruct);

            return $this->redirect(
                $this->generateUrl(
                    $this->getRepository()->getLocationService()->loadLocation(
                        $user->contentInfo->mainLocationId
                    )
                )
            );
        }

        return $this->render(
            'AcmeBundle::demo_update_user.html.twig',
            array(
                'form' => $form->createView(),
            )
        );
    }

    public function demoInformationCollectionAction(Request $request)
    {
        $repository = $this->getRepository();
        $contentService = $repository->getContentService();
        // @todo for demo purpose, user should have necessary permissions by itself
        $repository->setCurrentUser(
            $repository->getUserService()->loadUserByLogin('admin')
        );

        $content = $contentService->loadContent(126);
        $contentTypeId = $content->versionInfo->contentInfo->contentTypeId;
        $contentType = $repository->getContentTypeService()->loadContentType($contentTypeId);

        $informationCollection = new InformationCollectionStruct();

        $data = new DataWrapper($informationCollection, $contentType);

        // No method to create named builder in framework controller
        /** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
        $formBuilder = $this->container->get('form.factory')->createBuilder(InformationCollectionType::class, $data);
        // Adding controls as EzFormsBundle does not do that by itself
        $formBuilder->add('save', SubmitType::class, array('label' => 'Publish'));

        $form = $formBuilder->getForm();
        $form->handleRequest($request);

        if ($form->isValid()) {
            /** @var InformationCollectionStruct $data */
            $data = $form->getData()->payload;
            // save data to database
            // or something else
            // this is left for end developer
        }

        return $this->render(
            'NetgenEzFormsBundle::demo_form.html.twig',
            array(
                'form' => $form->createView(),
            )
        );
    }
}


1			<?php
2
3			namespace Netgen\Bundle\EzFormsBundle\Controller;
4
5			use Exception;
6			use eZ\Bundle\EzPublishCoreBundle\Controller;
7			use eZ\Publish\API\Repository\Exceptions\InvalidArgumentException;
8			use Netgen\Bundle\EzFormsBundle\Form\DataWrapper;
9			use Netgen\Bundle\EzFormsBundle\Form\Payload\InformationCollectionStruct;
10			use eZ\Publish\API\Repository\ContentService;
11			use eZ\Bundle\EzPublishCoreBundle\Controller;
			0 ignored issues – show Bug introduced 2017-12-21 09:25 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Cannot use eZ\Bundle\EzPublishCoreBundle\Controller as Controller because the name is already in use Loading history...
12			use eZ\Publish\API\Repository\LocationService;
13			use eZ\Publish\API\Repository\Repository;
14			use eZ\Publish\API\Repository\UserService;
15			use Netgen\Bundle\EzFormsBundle\Form\Type\CreateContentType;
16			use Netgen\Bundle\EzFormsBundle\Form\Type\CreateUserType;
17			use Netgen\Bundle\EzFormsBundle\Form\Type\InformationCollectionType;
18			use Netgen\Bundle\EzFormsBundle\Form\Type\UpdateContentType;
19			use Netgen\Bundle\EzFormsBundle\Form\Type\UpdateUserType;
20			use RuntimeException;
21			use Symfony\Component\Form\Extension\Core\Type\SubmitType;
22			use Symfony\Component\Form\FormError;
23			use Symfony\Component\HttpFoundation\Request;
24
25			class DemoController extends Controller
26			{
27			public function demoCreateContentAction(Request $request)
28			{
29			/** @var Repository $repository */
30			$repository = $this->getRepository();
31			/** @var ContentService $contentService */
32			$contentService = $repository->getContentService();
33			/** @var LocationService $locationService */
34			$locationService = $repository->getLocationService();
35			// @todo for demo purpose, user should have necessary permissions by itself
36			$repository->setCurrentUser(
37			$repository->getUserService()->loadUserByLogin('admin')
38			);
39			$contentType = $repository->getContentTypeService()
40			->loadContentTypeByIdentifier('test_type');
41			$contentCreateStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');
42
43			$data = new DataWrapper($contentCreateStruct, $contentCreateStruct->contentType);
44
45			/** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
46			$formBuilder = $this->container->get('form.factory')
47			->createBuilder(CreateContentType::class, $data);
48
49			$formBuilder->add('save', SubmitType::class, array('label' => 'Publish'));
50
51			$form = $formBuilder->getForm();
52			$form->handleRequest($request);
53
54			if ($form->isValid()) {
55			$rootLocation = $locationService->loadLocation(2);
56
57			try {
58			$repository->beginTransaction();
59
60			$contentDraft = $contentService->createContent(
61			$data->payload,
62			array(
63			$locationService->newLocationCreateStruct($rootLocation->id),
64			)
65			);
66
67			$content = $contentService->publishVersion($contentDraft->versionInfo);
68
69			$repository->commit();
70			} catch (Exception $e) {
71			$repository->rollback();
72			// @todo do something else if needed
73			throw $e;
74			}
75
76			return $this->redirect(
77			$this->generateUrl(
78			$locationService->loadLocation(
79			$content->contentInfo->mainLocationId
80			)
81			)
82			);
83			}
84
85			return $this->render(
86			'AcmeBundle::demo_create_content.html.twig',
87			array(
88			'form' => $form->createView(),
89			)
90			);
91			}
92
93			public function demoUpdateContentAction(Request $request)
94			{
95			/** @var Repository $repository */
96			$repository = $this->getRepository();
97			/** @var ContentService $contentService */
98			$contentService = $repository->getContentService();
99			$content = $contentService->loadContent(137);
100			$contentType = $repository->getContentTypeService()
101			->loadContentType($content->contentInfo->contentTypeId);
102			$contentUpdateStruct = $contentService->newContentUpdateStruct();
103			$contentUpdateStruct->initialLanguageCode = 'eng-GB';
104
105			$data = new DataWrapper($contentUpdateStruct, $contentType, $content);
106
107			/** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
108			$formBuilder = $this->container->get('form.factory')
109			->createBuilder(UpdateContentType::class, $data);
110
111			$formBuilder->add('save', SubmitType::class, array('label' => 'Update'));
112
113			$form = $formBuilder->getForm();
114			$form->handleRequest($request);
115
116			if ($form->isValid()) {
117			try {
118			$repository->beginTransaction();
119
120			$contentDraft = $contentService->createContentDraft($content->contentInfo);
121			$contentDraft = $contentService->updateContent(
122			$contentDraft->versionInfo,
123			$data->payload
124			);
125			$content = $contentService->publishVersion($contentDraft->versionInfo);
126
127			$repository->commit();
128			} catch (Exception $e) {
129			$repository->rollback();
130
131			throw $e;
132			}
133
134			return $this->redirect(
135			$this->generateUrl(
136			$this->getRepository()->getLocationService()->loadLocation(
137			$content->contentInfo->mainLocationId
138			)
139			)
140			);
141			}
142
143			return $this->render(
144			'AcmeBundle::demo_update_content.html.twig',
145			array(
146			'form' => $form->createView(),
147			)
148			);
149			}
150
151			public function demoCreateUserAction(Request $request)
152			{
153			/** @var Repository $repository */
154			$repository = $this->getRepository();
155			/** @var UserService $userService */
156			$userService = $repository->getUserService();
157
158			$contentType = $repository->getContentTypeService()
159			->loadContentTypeByIdentifier('user');
160			$userCreateStruct = $userService->newUserCreateStruct(
161			null,
162			null,
163			null,
164			'eng-GB',
165			$contentType
166			);
167
168			$userCreateStruct->enabled = false;
169
170			$data = new DataWrapper($userCreateStruct, $userCreateStruct->contentType);
171
172			/** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
173			$formBuilder = $this->container->get('form.factory')->createBuilder(CreateUserType::class, $data);
174
175			$formBuilder->add('save', SubmitType::class, array('label' => 'Publish'));
176
177			$form = $formBuilder->getForm();
178			$form->handleRequest($request);
179
180			if ($form->isValid()) {
181
182			$userGroup = $userService->loadUserGroup(13);
183
184			try {
185			$user = $userService->createUser(
186			$data->payload,
187			array($userGroup)
188			);
189
190			// @todo send confirmation email and redirect to proper location (enter confirmation code or something)
191
192			return $this->redirect(
193			$this->generateUrl(
194			$this->getRepository()->getLocationService()->loadLocation(
195			$user->contentInfo->mainLocationId
196			)
197			)
198			);
199			} catch (InvalidArgumentException $e) {
200			// There is no better way to do this ATM...
201			$existingUsernameMessage = "Argument 'userCreateStruct' is invalid: User with provided login already exists";
202			if ($e->getMessage() === $existingUsernameMessage) {
203			// Search for the first ezuser field type in content type
204			foreach ($userCreateStruct->contentType->getFieldDefinitions() as $fieldDefinition) {
205			if ($fieldDefinition->fieldTypeIdentifier === 'ezuser') {
206			$userFieldDefinition = $fieldDefinition;
207			break;
208			}
209			}
210
211			// UserService validates for this, but it happens AFTER existing username validation
212			if (!isset($userFieldDefinition)) {
213			throw new RuntimeException("Could not find 'ezuser' field.");
214			}
215
216			$form->get($userFieldDefinition->identifier)->addError(
217			new FormError('User with provided username already exists.')
218			);
219			} else {
220			// @todo do something else if needed
221			throw $e;
222			}
223			}
224			}
225
226			return $this->render(
227			'AcmeBundle::demo_create_user.html.twig',
228			array(
229			'form' => $form->createView(),
230			)
231			);
232			}
233
234			public function demoUpdateUserAction(Request $request)
235			{
236			/** @var Repository $repository */
237			$repository = $this->getRepository();
238			/** @var UserService $userService */
239			$userService = $repository->getUserService();
240			/** @var ContentService $contentService */
241			$contentService = $repository->getContentService();
242
243			$user = $userService->loadUser(142);
244			$contentType = $repository->getContentTypeService()->loadContentTypeByIdentifier('user');
245			$contentUpdateStruct = $contentService->newContentUpdateStruct();
246			$contentUpdateStruct->initialLanguageCode = 'eng-GB';
247			$userUpdateStruct = $userService->newUserUpdateStruct();
248			$userUpdateStruct->contentUpdateStruct = $contentUpdateStruct;
249
250			$data = new DataWrapper($userUpdateStruct, $contentType, $user);
251
252			/** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
253			$formBuilder = $this->container->get('form.factory')->createBuilder(UpdateUserType::class, $data);
254
255			$formBuilder->add('save', SubmitType::class, array('label' => 'Update'));
256
257			$form = $formBuilder->getForm();
258			$form->handleRequest($request);
259
260			if ($form->isValid()) {
261			$user = $userService->updateUser($user, $userUpdateStruct);
262
263			return $this->redirect(
264			$this->generateUrl(
265			$this->getRepository()->getLocationService()->loadLocation(
266			$user->contentInfo->mainLocationId
267			)
268			)
269			);
270			}
271
272			return $this->render(
273			'AcmeBundle::demo_update_user.html.twig',
274			array(
275			'form' => $form->createView(),
276			)
277			);
278			}
279
280			public function demoInformationCollectionAction(Request $request)
281			{
282			$repository = $this->getRepository();
283			$contentService = $repository->getContentService();
284			// @todo for demo purpose, user should have necessary permissions by itself
285			$repository->setCurrentUser(
286			$repository->getUserService()->loadUserByLogin('admin')
287			);
288
289			$content = $contentService->loadContent(126);
290			$contentTypeId = $content->versionInfo->contentInfo->contentTypeId;
291			$contentType = $repository->getContentTypeService()->loadContentType($contentTypeId);
292
293			$informationCollection = new InformationCollectionStruct();
294
295			$data = new DataWrapper($informationCollection, $contentType);
296
297			// No method to create named builder in framework controller
298			/** @var $formBuilder \Symfony\Component\Form\FormBuilderInterface */
299			$formBuilder = $this->container->get('form.factory')->createBuilder(InformationCollectionType::class, $data);
300			// Adding controls as EzFormsBundle does not do that by itself
301			$formBuilder->add('save', SubmitType::class, array('label' => 'Publish'));
302
303			$form = $formBuilder->getForm();
304			$form->handleRequest($request);
305
306			if ($form->isValid()) {
307			/** @var InformationCollectionStruct $data */
308			$data = $form->getData()->payload;
309			// save data to database
310			// or something else
311			// this is left for end developer
312			}
313
314			return $this->render(
315			'NetgenEzFormsBundle::demo_form.html.twig',
316			array(
317			'form' => $form->createView(),
318			)
319			);
320			}
321			}
322

netgen / NetgenEzFormsBundle

GitHub Access Token became invalid

Pull Request — master (#42)

DemoController::demoCreateContentAction() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like