UpdateContentMapper::mapFromForm() - Code Metrics - netgen/NetgenEzFormsBundle - Measure and Improve Code Quality continuously with Scrutinizer

UpdateContentMapper::mapFromForm() A
last analyzed 2020-08-28 09:37 UTC

↳ Parent: UpdateContentMapper

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	9.456
c	0
b	0
f	0
cc	3
nc	3
nop	3

<?php

declare(strict_types=1);

namespace Netgen\Bundle\EzFormsBundle\Form\DataMapper;

use Netgen\Bundle\EzFormsBundle\Form\DataMapper;
use Netgen\Bundle\EzFormsBundle\Form\DataWrapper;
use RuntimeException;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\PropertyAccess\PropertyPathInterface;

/**
 * A data mapper using property paths to read/write data.
 */
final class UpdateContentMapper extends DataMapper
{
    protected function mapToForm(FormInterface $form, DataWrapper $data, PropertyPathInterface $propertyPath): void
    {
        /** @var \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct */
        $contentUpdateStruct = $data->payload;
        /** @var \eZ\Publish\API\Repository\Values\Content\Content $content */
        $content = $data->target;
        /** @var \eZ\Publish\API\Repository\Values\ContentType\ContentType $contentType */
        $contentType = $data->definition;

        $fieldDefinitionIdentifier = (string) $propertyPath;
        $fieldDefinition = $contentType->getFieldDefinition($fieldDefinitionIdentifier);

        if (null === $fieldDefinition) {
            throw new RuntimeException(
                "Data payload does not contain expected FieldDefinition '{$fieldDefinitionIdentifier}'"
            );
        }

        $fieldTypeIdentifier = $fieldDefinition->fieldTypeIdentifier;

        $handler = $this->fieldTypeHandlerRegistry->get($fieldTypeIdentifier);
        $form->setData(
            $handler->convertFieldValueToForm(
                $content->getFieldValue(
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
                    $fieldDefinitionIdentifier,
                    $contentUpdateStruct->initialLanguageCode
                ),
                $fieldDefinition
            )
        );
    }

    protected function mapFromForm(FormInterface $form, DataWrapper $data, PropertyPathInterface $propertyPath): void
    {
        /** @var \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct */
        $contentUpdateStruct = $data->payload;
        /** @var \eZ\Publish\API\Repository\Values\ContentType\ContentType $contentType */
        $contentType = $data->definition;

        $fieldDefinitionIdentifier = (string) $propertyPath;
        $fieldDefinition = $contentType->getFieldDefinition($fieldDefinitionIdentifier);

        if (null === $fieldDefinition) {
            throw new RuntimeException(
                "Data payload does not contain expected FieldDefinition '{$fieldDefinitionIdentifier}'"
            );
        }

        $fieldTypeIdentifier = $fieldDefinition->fieldTypeIdentifier;
        $formData = $form->getData();

        // Set field to struct only if it is not empty or it has not been marked
        // to skip update if empty
        if (!$this->shouldSkipForEmptyUpdate($form, $formData, $fieldDefinitionIdentifier)) {
            $handler = $this->fieldTypeHandlerRegistry->get($fieldTypeIdentifier);
            $contentUpdateStruct->setField(
                $fieldDefinitionIdentifier,
                $handler->convertFieldValueFromForm($form->getData())
            );
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Netgen\Bundle\EzFormsBundle\Form\DataMapper;
6
7			use Netgen\Bundle\EzFormsBundle\Form\DataMapper;
8			use Netgen\Bundle\EzFormsBundle\Form\DataWrapper;
9			use RuntimeException;
10			use Symfony\Component\Form\FormInterface;
11			use Symfony\Component\PropertyAccess\PropertyPathInterface;
12
13			/**
14			* A data mapper using property paths to read/write data.
15			*/
16			final class UpdateContentMapper extends DataMapper
17			{
18			protected function mapToForm(FormInterface $form, DataWrapper $data, PropertyPathInterface $propertyPath): void
19			{
20			/** @var \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct */
21			$contentUpdateStruct = $data->payload;
22			/** @var \eZ\Publish\API\Repository\Values\Content\Content $content */
23			$content = $data->target;
24			/** @var \eZ\Publish\API\Repository\Values\ContentType\ContentType $contentType */
25			$contentType = $data->definition;
26
27			$fieldDefinitionIdentifier = (string) $propertyPath;
28			$fieldDefinition = $contentType->getFieldDefinition($fieldDefinitionIdentifier);
29
30			if (null === $fieldDefinition) {
31			throw new RuntimeException(
32			"Data payload does not contain expected FieldDefinition '{$fieldDefinitionIdentifier}'"
33			);
34			}
35
36			$fieldTypeIdentifier = $fieldDefinition->fieldTypeIdentifier;
37
38			$handler = $this->fieldTypeHandlerRegistry->get($fieldTypeIdentifier);
39			$form->setData(
40			$handler->convertFieldValueToForm(
41			$content->getFieldValue(
			0 ignored issues – show Bug introduced 2017-07-13 10:00 UTC by Report Bug Copy Issue Report It seems like `$content->getFieldValue(...t->initialLanguageCode)` can be `null`; however, `convertFieldValueToForm()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
42			$fieldDefinitionIdentifier,
43			$contentUpdateStruct->initialLanguageCode
44			),
45			$fieldDefinition
46			)
47			);
48			}
49
50			protected function mapFromForm(FormInterface $form, DataWrapper $data, PropertyPathInterface $propertyPath): void
51			{
52			/** @var \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct */
53			$contentUpdateStruct = $data->payload;
54			/** @var \eZ\Publish\API\Repository\Values\ContentType\ContentType $contentType */
55			$contentType = $data->definition;
56
57			$fieldDefinitionIdentifier = (string) $propertyPath;
58			$fieldDefinition = $contentType->getFieldDefinition($fieldDefinitionIdentifier);
59
60			if (null === $fieldDefinition) {
61			throw new RuntimeException(
62			"Data payload does not contain expected FieldDefinition '{$fieldDefinitionIdentifier}'"
63			);
64			}
65
66			$fieldTypeIdentifier = $fieldDefinition->fieldTypeIdentifier;
67			$formData = $form->getData();
68
69			// Set field to struct only if it is not empty or it has not been marked
70			// to skip update if empty
71			if (!$this->shouldSkipForEmptyUpdate($form, $formData, $fieldDefinitionIdentifier)) {
72			$handler = $this->fieldTypeHandlerRegistry->get($fieldTypeIdentifier);
73			$contentUpdateStruct->setField(
74			$fieldDefinitionIdentifier,
75			$handler->convertFieldValueFromForm($form->getData())
76			);
77			}
78			}
79			}
80

netgen / NetgenEzFormsBundle

GitHub Access Token became invalid

UpdateContentMapper::mapFromForm() A last analyzed 2020-08-28 09:37 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

UpdateContentMapper::mapFromForm() A
last analyzed 2020-08-28 09:37 UTC