Conditions | 1 |
Paths | 1 |
Total Lines | 167 |
Code Lines | 77 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
67 | public static function createWithRules() |
||
68 | { |
||
69 | // Create a new Language instance |
||
70 | $language = new self(); |
||
71 | |||
72 | // |
||
73 | // Add a standard set of Rules |
||
74 | // |
||
75 | |||
76 | // Hyphenated Flag with List |
||
77 | $language->addRule(new Rule( |
||
78 | 'Hyphenated Flag with List', |
||
79 | '-f [one, two, three]', |
||
80 | '/^\-(' . ARGH_SYNTAX_FLAG . ')[\s]+\[(' . ARGH_SYNTAX_LIST . ')\]$/i', |
||
81 | [ARGH_SEMANTICS_FLAG, ARGH_SEMANTICS_LIST] |
||
82 | ) |
||
83 | ); |
||
84 | |||
85 | // Double Hyphenated Flag with List |
||
86 | $language->addRule(new Rule( |
||
87 | 'Double Hyphenated Name with List', |
||
88 | '--key=[one, two, three]', |
||
89 | '/^\-\-(' . ARGH_SYNTAX_NAME . ')=\[(' . ARGH_SYNTAX_LIST . ')\]$/i', |
||
90 | [ARGH_SEMANTICS_NAME, ARGH_SEMANTICS_LIST] |
||
91 | ) |
||
92 | ); |
||
93 | |||
94 | // Hyphenated Flag with Quoted Value |
||
95 | $language->addRule(new Rule( |
||
96 | 'Hyphenated Flag with Quoted Value', |
||
97 | '-f \'Hello World\'', |
||
98 | '/^\-(' . ARGH_SYNTAX_FLAG . ')[\s]+\'(' . ARGH_SYNTAX_QUOTED . ')\'$/i', |
||
99 | [ARGH_SEMANTICS_FLAG, ARGH_SEMANTICS_VALUE] |
||
100 | ) |
||
101 | ); |
||
102 | |||
103 | // Double Hyphenated Key with Quoted Value |
||
104 | $language->addRule(new Rule( |
||
105 | 'Double Hyphenated Name with Quoted Value', |
||
106 | '--key=\'quoted value\'', |
||
107 | '/^\-\-(' . ARGH_SYNTAX_NAME . ')=\'(' . ARGH_SYNTAX_QUOTED . ')\'$/i', |
||
108 | [ARGH_SEMANTICS_NAME, ARGH_SEMANTICS_VALUE] |
||
109 | ) |
||
110 | ); |
||
111 | |||
112 | // Hyphenated Flag with Value |
||
113 | $language->addRule(new Rule( |
||
114 | 'Hyphenated Flag with Value', |
||
115 | '-f value', |
||
116 | '/^\-(' . ARGH_SYNTAX_FLAG . ')[\s]+(' . ARGH_SYNTAX_VALUE . ')$/i', |
||
117 | [ARGH_SEMANTICS_FLAG, ARGH_SEMANTICS_VALUE] |
||
118 | ) |
||
119 | ); |
||
120 | |||
121 | /* |
||
122 | // Command with Naked Subcommand |
||
123 | $language->addRule(new Rule( |
||
124 | 'Command with Naked Subcommand', |
||
125 | 'cmd sub', |
||
126 | '/^(' . ARGH_SYNTAX_COMMAND . ')[\s]+(' . ARGH_SYNTAX_COMMAND . ')$/i', |
||
127 | [ARGH_SEMANTICS_COMMAND, ARGH_SEMANTICS_SUB] |
||
128 | ) |
||
129 | ); |
||
130 | */ |
||
131 | |||
132 | // Hyphenated Key with Value |
||
133 | $language->addRule(new Rule( |
||
134 | 'Hyphenated Name with Value', |
||
135 | '-key value', |
||
136 | '/^\-(' . ARGH_SYNTAX_NAME . ') (' . ARGH_SYNTAX_VALUE . ')$/i', |
||
137 | [ARGH_SEMANTICS_NAME, ARGH_SEMANTICS_VALUE] |
||
138 | ) |
||
139 | ); |
||
140 | |||
141 | // Double Hyphenated Key with Value |
||
142 | $language->addRule(new Rule( |
||
143 | 'Double Hyphenated Name with Value', |
||
144 | '--key=value', |
||
145 | '/^\-\-(' . ARGH_SYNTAX_NAME . ')=(' . ARGH_SYNTAX_VALUE . ')$/i', |
||
146 | [ARGH_SEMANTICS_NAME, ARGH_SEMANTICS_VALUE] |
||
147 | ) |
||
148 | ); |
||
149 | |||
150 | // Double Hyphenated Boolean Key |
||
151 | $language->addRule(new Rule( |
||
152 | 'Double Hyphenated Boolean Key', |
||
153 | '--key', |
||
154 | '/^\-\-(' . ARGH_SYNTAX_NAME . ')$/i', |
||
155 | [ARGH_SEMANTICS_NAME] |
||
156 | ) |
||
157 | ); |
||
158 | |||
159 | // Hyphenated Boolean Name |
||
160 | $language->addRule(new Rule( |
||
161 | 'Hyphenated Boolean Key', |
||
162 | '-key', |
||
163 | '/^\-(' . ARGH_SYNTAX_NAME . ')$/i', |
||
164 | [ARGH_SEMANTICS_NAME] |
||
165 | ) |
||
166 | ); |
||
167 | |||
168 | // Hyphenated Boolean Flag |
||
169 | $language->addRule(new Rule( |
||
170 | 'Hyphenated Boolean Flag', |
||
171 | '-f', |
||
172 | '/^\-(' . ARGH_SYNTAX_FLAG . ')$/i', |
||
173 | [ARGH_SEMANTICS_FLAG] |
||
174 | ) |
||
175 | ); |
||
176 | |||
177 | // Hyphenated Multi Flag |
||
178 | $language->addRule(new Rule( |
||
179 | 'Hyphenated Multi Flag', |
||
180 | '-xvf', |
||
181 | '/^\-(' . ARGH_SYNTAX_FLAGS . ')$/i', |
||
182 | [ARGH_SEMANTICS_FLAGS] |
||
183 | ) |
||
184 | ); |
||
185 | |||
186 | /* |
||
187 | // Command with Delimited Subcommand |
||
188 | $language->addRule(new Rule( |
||
189 | 'Command with Delimited Subcommand', |
||
190 | 'cmd:sub', |
||
191 | '/^(' . ARGH_SYNTAX_COMMAND . '):(' . ARGH_SYNTAX_COMMAND . ')$/i', |
||
192 | [ARGH_SEMANTICS_COMMAND, ARGH_SEMANTICS_SUB] |
||
193 | ) |
||
194 | ); |
||
195 | */ |
||
196 | |||
197 | // Command |
||
198 | $language->addRule(new Rule( |
||
199 | 'Command', |
||
200 | 'cmd', |
||
201 | '/^(' . ARGH_SYNTAX_COMMAND . ')$/i', |
||
202 | [ARGH_SEMANTICS_COMMAND] |
||
203 | ) |
||
204 | ); |
||
205 | |||
206 | // Naked Multi Flag |
||
207 | $language->addRule(new Rule( |
||
208 | 'Naked Multi Flag', |
||
209 | 'xvf', |
||
210 | '/^(' . ARGH_SYNTAX_FLAGS . ')$/i', |
||
211 | [ARGH_SEMANTICS_FLAGS] |
||
212 | ) |
||
213 | ); |
||
214 | |||
215 | // Quoted Naked Variable |
||
216 | $language->addRule(new Rule( |
||
217 | 'Quoted Naked Variable', |
||
218 | 'value', |
||
219 | '/^\'(' . ARGH_SYNTAX_QUOTED . ')\'$/i', |
||
220 | [ARGH_SEMANTICS_VARIABLE] |
||
221 | ) |
||
222 | ); |
||
223 | |||
224 | // Naked Variable |
||
225 | $language->addRule(new Rule( |
||
226 | 'Naked Variable', |
||
227 | 'value', |
||
228 | '/^(' . ARGH_SYNTAX_VARIABLE . ')$/i', |
||
229 | [ARGH_SEMANTICS_VARIABLE] |
||
230 | ) |
||
231 | ); |
||
232 | |||
233 | return $language; |
||
234 | } |
||
289 |
This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed.
Unreachable code is most often the result of
return
,die
orexit
statements that have been added for debug purposes.In the above example, the last
return false
will never be executed, because a return statement has already been met in every possible execution path.