netfocusinc\argh\ArgvPreprocessor

Complexity

Total Complexity

13

Size/Duplication

Total Lines	141
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	process()	0	124	13

<?php
	
/**
	* ArgvPreprocessor.php
	*/
	
namespace netfocusinc\argh;

/**
	* Handles the preparation of PHP $argv arrays that is required before parsing
	*
	* @author Benjamin Hough
	*
	* @internal
	*
	* @since 1.0.0
	*/
class ArgvPreprocessor
{
	
	/**
	 * Prepare an array of arguments for parsing
	 * 
	 * PHP registers the $argv array with input from the command line.
	 * This process includes some items that make it difficult to parse the way Argh wants to.
	 * This function takes an $argv array and creates a new array where ...
	 * Bracketed lists are put in a single element, regardless of spacing
	 * Strings containing spaces are wrapped in single quotes; unless they are part of a list
	 *
	 * 
	 * @param array $args An '$argv' like array of arguments
	 *
	 * @return array
	 */
	public static function process(array $argv)
	{
		if(count($argv) < 1)
		{
			throw(new ArghException(__CLASS__ . ': $argv is empty'));
		}
		
		//
		// Remove first element from $argv, it contains the name of the php script
		//
		
		$args = array_slice($argv, 1);
		
		//
		// Lists
		//
		
		for($i=0; $i<count($args); $i++)

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

		{
			// Lists begin with an opening bracket '['
			if( strpos($args[$i], '[') !== FALSE )
			{
				// Found the beginning of a list at $i
				//echo "DEBUG: Found beginning of a list at $i\n";
				
				// Search for the end of the list; starting at the current element				
				for($j=$i; $j<count($args); $j++)

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

				{
					if( strpos($args[$j], ']') !== FALSE )
					{
						// Found the end of a list at $j
						//echo "DEBUG: Found end of a list at $j\n";
						
						if($j != $i)
						{
							// List does NOT open and close in the same element; elements must be re-combined
						
							// List closing bracket should always be the last character of the element
							if( strpos($args[$j], ']') == (strlen($args[$j])-1) )
							{
								// Create a new string for $args $i thru $j
								$list = "";
								for($k=$i; $k<=$j; $k++) $list .= $args[$k];
								
								//echo "DEBUG: Replace elements $i thru $j with: $list\n";
								
								// Replace $args from $i thru $j with $list
								array_splice($args, $i, ($j-$i)+1, $list);
								
								// Stop searching for the end of the list
								break;
							}
							else
							{
								throw new ArghException(__METHOD__ . ': Syntax Error: Invalid list.');
							}
							
						} // END: if($j != $i)
						else
						{
							//echo "DEBUG: List is already contained in a single element.\n";
						}
						
					} // END: if( ($closeAt = strpos($args[$j], ']')) !== FALSE )
					
				} // END: for($j=$i; $j<count($args); $j++)
				
			} // END: if( strpos($args[$i], ' ') !== FALSE )
			
		} // END: for($i=0; $i<count($args); $i++)		
		
		//
		// Quotes
		//
		
		// Check for arguments with spaces, these were originally quoted on the command line
		for($i=0; $i<count($args); $i++)

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

		{
			if( strpos($args[$i], ' ') !== FALSE )
			{

				// Check if argument is a list
				if( strpos($args[$i], '[') !== FALSE )
				{
					
					//
					// DO NOT ADD QUOTES SURROUNDING ITEMS IN A LIST
					// THEY WILL JUST HAVE TO BE STRIPPED LATER
					//
				
				} // END: if( strpos($args[$i], '[') !== FALSE )	
				else
				{
					//!TODO: handle --msg="Hello World"; We don't want "--msg=Hello World"
					//! TODO: FIX. THIS IS BROKEN
					
					if( strpos($args[$i], '=') === FALSE )
					{
						// Wrap (space containing) argument in quotes
						$args[$i] = "'" . $args[$i] . "'";
					}
					else
					{
						// Wrap (space containing) argument value - after '=' sign in quotes
						
						// Split argument into parts, delimted by '='
						$tokens = explode('=', $args[$i]);
						
						$args[$i] = $tokens[0] . '=' . "'" . $tokens[1] . "'";
					}

					
				}			
				
			} // END: if( strpos($args[$i], ' ') !== FALSE )
			
		} // END: for($i=0; $i<count($args); $i++)	
		
		// DEBUG
		//echo "\n------- AFTER PRE PROCESSING --------\n";
		//print_r($args);
		//echo "\n-------------------------------------\n\n";
		
		return $args;	
	}	
	
}