Complex classes like Filterer often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Filterer, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class Filterer |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * @var array |
||
| 19 | */ |
||
| 20 | private $uniqueNameToQueryFieldMap; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * Apply the filters to the query builders |
||
| 24 | * |
||
| 25 | * @param QueryBuilder $queryBuilder |
||
| 26 | * @param Filter $filterDefinition |
||
| 27 | * @param array $uniqueNameToQueryFieldMap |
||
| 28 | * |
||
| 29 | * @return QueryBuilder |
||
| 30 | * @throws \Exception |
||
| 31 | */ |
||
| 32 | public function filter(QueryBuilder $queryBuilder, Filter $filterDefinition, $uniqueNameToQueryFieldMap) |
||
| 42 | |||
| 43 | /** |
||
| 44 | * Builds a filter group and, recursively, constructs a tree of conditions for the filters |
||
| 45 | * |
||
| 46 | * @param QueryBuilder $queryBuilder |
||
| 47 | * @param Filter $filterDefinition |
||
| 48 | * |
||
| 49 | * @throws \Exception |
||
| 50 | * @return Andx|Orx |
||
| 51 | */ |
||
| 52 | protected function buildFilterGroup(QueryBuilder $queryBuilder, Filter $filterDefinition) |
||
| 69 | |||
| 70 | /** |
||
| 71 | * @param Composite $expressions |
||
| 72 | * @param Filter $filterDefinition |
||
| 73 | * @param QueryBuilder $queryBuilder |
||
| 74 | * |
||
| 75 | * @throws \Exception |
||
| 76 | */ |
||
| 77 | protected function addExpressionsForFilter(Composite $expressions, Filter $filterDefinition, QueryBuilder $queryBuilder) |
||
| 88 | |||
| 89 | /** |
||
| 90 | * @param Composite $expressions |
||
| 91 | * @param FilterCondition $filterCondition |
||
| 92 | * @param QueryBuilder $queryBuilder |
||
| 93 | * |
||
| 94 | * @throws ColumnNotFoundException |
||
| 95 | * @throws \Exception |
||
| 96 | */ |
||
| 97 | protected function addExpressionsForFilterCondition(Composite $expressions, FilterCondition $filterCondition, QueryBuilder $queryBuilder) |
||
| 106 | |||
| 107 | /** |
||
| 108 | * @param FilterCondition $filterCondition |
||
| 109 | * @param string $token |
||
| 110 | * @param QueryBuilder $queryBuilder |
||
| 111 | * |
||
| 112 | * @throws \Exception |
||
| 113 | * |
||
| 114 | * @return Expr|string |
||
| 115 | */ |
||
| 116 | protected function buildCondition(FilterCondition $filterCondition, $token, QueryBuilder $queryBuilder) |
||
| 157 | |||
| 158 | /** |
||
| 159 | * @param FilterCondition $filterCondition |
||
| 160 | * @param QueryBuilder $queryBuilder |
||
| 161 | * |
||
| 162 | * @return string |
||
| 163 | */ |
||
| 164 | protected function buildUniqueToken(FilterCondition $filterCondition, QueryBuilder $queryBuilder) |
||
| 170 | |||
| 171 | /** |
||
| 172 | * @param FilterCondition $filterCondition |
||
| 173 | * @param string $identifier |
||
| 174 | * @param QueryBuilder $queryBuilder |
||
| 175 | * |
||
| 176 | * @return Andx|Orx |
||
| 177 | * |
||
| 178 | * @throws \Exception |
||
| 179 | */ |
||
| 180 | private function buildEmptinessCondition(FilterCondition $filterCondition, $identifier, QueryBuilder $queryBuilder) |
||
| 210 | |||
| 211 | /** |
||
| 212 | * @param FilterCondition $filterCondition |
||
| 213 | * @param string $identifier |
||
| 214 | * @param string $token |
||
| 215 | * @param QueryBuilder $queryBuilder |
||
| 216 | * |
||
| 217 | * @return Andx|Orx|string |
||
| 218 | * |
||
| 219 | * @throws \Exception |
||
| 220 | */ |
||
| 221 | private function buildSetInclusionCondition(FilterCondition $filterCondition, $identifier, $token, QueryBuilder $queryBuilder) |
||
| 242 | |||
| 243 | /** |
||
| 244 | * @param FilterCondition $filterCondition |
||
| 245 | * @param string $token |
||
| 246 | * @param QueryBuilder $queryBuilder |
||
| 247 | */ |
||
| 248 | private function setConditionParameters(FilterCondition $filterCondition, $token, QueryBuilder $queryBuilder) |
||
| 269 | } |
||
| 270 |