Netdudes\DataSourceryBundle\Extension\UqlFunction

Complexity

Total Complexity

15

Size/Duplication

Total Lines	150
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getInstance()	0	4	1
A	getMethod()	0	4	1
B	__toString()	0	28	5
A	getName()	0	4	1
A	call()	0	4	1
B	jsonSerialize()	0	34	5

<?php

namespace Netdudes\DataSourceryBundle\Extension;

/**
 * Wraps a definition of a callable defined in an extension,
 * available to be used in UQL, etc.
 */
class UqlFunction implements \JsonSerializable, UqlFunctionInterface
{
    /**
     * Instance to which this function/method belongs
     *
     * @var UqlExtensionInterface
     */
    private $instance;

    /**
     * Name of the method in the instance where its defined
     *
     * @var string
     */
    private $method;

    /**
     * Name by which this function will be known inside UQL
     *
     * @var string
     */
    private $name;

    /**
     * @param string                $name
     * @param UqlExtensionInterface $instance
     * @param string                $method
     */
    public function __construct($name, UqlExtensionInterface $instance, $method)
    {
        $this->instance = $instance;
        $this->name = $name;
        $this->method = $method;
    }

    /**
     * @return UqlExtensionInterface
     */
    public function getInstance()
    {
        return $this->instance;
    }

    /**
     * @return mixed
     */
    public function getMethod()
    {
        return $this->method;
    }

    /**
     * @return mixed
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Performs the call to the function defined by this FunctionExtension
     *
     * @param array $arguments
     *
     * @return mixed
     */
    public function call($arguments)
    {
        return call_user_func_array([$this->getInstance(), $this->getMethod()], $arguments);
    }

    /**
     * Returns a readable string representation of the function, of the standard form:
     *
     * functionName(argument1, argument2, [optionalArgument1 = defaultValue, [optionalNullableArgument2]])
     *
     * @return string
     */
    public function __toString()
    {
        $reflection = new \ReflectionMethod($this->instance, $this->method);
        $methodParameters = $reflection
            ->getParameters();

        $optionalArgumentCount = 0;
        $splitStringRepresentation = [];
        foreach ($methodParameters as $parameter) {
            $optional = $parameter->isOptional();
            $name = $parameter->getName();

Consider using $parameter->name. There is an issue with getName() and APC-enabled PHP versions.

            if ($optional) {
                $name = '[' . $name;
                $defaultValue = $parameter->getDefaultValue();
                if (!is_null($defaultValue)) {
                    if (is_numeric($defaultValue)) {
                        $defaultValue = intval($defaultValue);
                    }
                    $name .= ' = ' . $defaultValue;
                }

                $optionalArgumentCount++;
            }
            $splitStringRepresentation[] = $name;
        }

        return $this->name . '(' . implode(', ', $splitStringRepresentation) . str_repeat(']', $optionalArgumentCount) . ')';
    }

    /**
     * (PHP 5 &gt;= 5.4.0)<br/>
     * Specify data which should be serialized to JSON
     *
     * @link http://php.net/manual/en/jsonserializable.jsonserialize.php
     * @return mixed data which can be serialized by <b>json_encode</b>,
     *       which is a value of any type other than a resource.
     */
    public function jsonSerialize()
    {
        $json = [
            'name' => $this->getName(),

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

            'arguments' => [],
        ];

        $reflection = new \ReflectionMethod($this->instance, $this->method);
        $methodParameters = $reflection
            ->getParameters();

        foreach ($methodParameters as $parameter) {
            $isOptional = $parameter->isOptional();
            $argument = [
                'name' => $parameter->getName(),

Consider using $parameter->name. There is an issue with getName() and APC-enabled PHP versions.

                'optional' => $isOptional,
                'default' => null,
            ];

            if ($isOptional) {
                $defaultValue = $parameter->getDefaultValue();
                if (!is_null($defaultValue)) {
                    if (is_numeric($defaultValue)) {
                        $defaultValue = intval($defaultValue);
                    }
                    $argument['default'] = $defaultValue;
                }
            }

            $json['arguments'][] = $argument;
        }

        return $json;
    }
}