Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | View Code Duplication | class PropertyGroupOption extends Base |
|
|
|||
17 | { |
||
18 | /** |
||
19 | * @var int |
||
20 | */ |
||
21 | protected $id; |
||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | protected $name; |
||
26 | /** |
||
27 | * @var bool |
||
28 | */ |
||
29 | protected $filterable; |
||
30 | |||
31 | /** |
||
32 | * @return int |
||
33 | */ |
||
34 | public function getId() |
||
38 | |||
39 | /** |
||
40 | * @param int $id |
||
41 | * |
||
42 | * @return PropertyGroupOption |
||
43 | */ |
||
44 | public function setId($id) |
||
50 | |||
51 | /** |
||
52 | * @return string |
||
53 | */ |
||
54 | public function getName() |
||
58 | |||
59 | /** |
||
60 | * @param string $name |
||
61 | * |
||
62 | * @return PropertyGroupOption |
||
63 | */ |
||
64 | public function setName($name) |
||
70 | |||
71 | /** |
||
72 | * @return bool |
||
73 | */ |
||
74 | public function isFilterable() |
||
78 | |||
79 | /** |
||
80 | * @param bool $filterable |
||
81 | * |
||
82 | * @return PropertyGroupOption |
||
83 | */ |
||
84 | public function setFilterable($filterable) |
||
90 | } |
||
91 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.