Complex classes like ArticleDetail often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ArticleDetail, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 16 | class ArticleDetail extends Base |
||
| 17 | { |
||
| 18 | /** |
||
| 19 | * @var int |
||
| 20 | */ |
||
| 21 | protected $id; |
||
| 22 | /** |
||
| 23 | * @var string |
||
| 24 | */ |
||
| 25 | protected $number; |
||
| 26 | /** |
||
| 27 | * @var string |
||
| 28 | */ |
||
| 29 | protected $supplierNumber; |
||
| 30 | /** |
||
| 31 | * @var string |
||
| 32 | */ |
||
| 33 | protected $additionalText; |
||
| 34 | /** |
||
| 35 | * @var string |
||
| 36 | */ |
||
| 37 | protected $weight; |
||
| 38 | /** |
||
| 39 | * @var string |
||
| 40 | */ |
||
| 41 | protected $width; |
||
| 42 | /** |
||
| 43 | * @var string |
||
| 44 | */ |
||
| 45 | protected $len; |
||
| 46 | /** |
||
| 47 | * @var string |
||
| 48 | */ |
||
| 49 | protected $height; |
||
| 50 | /** |
||
| 51 | * @var string |
||
| 52 | */ |
||
| 53 | protected $ean; |
||
| 54 | /** |
||
| 55 | * @var string |
||
| 56 | */ |
||
| 57 | protected $purchaseUnit; |
||
| 58 | /** |
||
| 59 | * @var string |
||
| 60 | */ |
||
| 61 | protected $descriptionLong; |
||
| 62 | /** |
||
| 63 | * @var string |
||
| 64 | */ |
||
| 65 | protected $referenceUnit; |
||
| 66 | /** |
||
| 67 | * @var string |
||
| 68 | */ |
||
| 69 | protected $packUnit; |
||
| 70 | /** |
||
| 71 | * @var string |
||
| 72 | */ |
||
| 73 | protected $shippingTime; |
||
| 74 | /** |
||
| 75 | * @var Price[] |
||
| 76 | */ |
||
| 77 | protected $prices; |
||
| 78 | /** |
||
| 79 | * @var ConfiguratorOption[] |
||
| 80 | */ |
||
| 81 | protected $configuratorOptions; |
||
| 82 | /** |
||
| 83 | * @var ArticleAttribute |
||
| 84 | */ |
||
| 85 | protected $attribute; |
||
| 86 | /** |
||
| 87 | * @var int |
||
| 88 | */ |
||
| 89 | protected $articleId; |
||
| 90 | /** |
||
| 91 | * @var int |
||
| 92 | */ |
||
| 93 | protected $unitId; |
||
| 94 | /** |
||
| 95 | * @var int |
||
| 96 | */ |
||
| 97 | protected $kind; |
||
| 98 | /** |
||
| 99 | * @var int |
||
| 100 | */ |
||
| 101 | protected $inStock; |
||
| 102 | /** |
||
| 103 | * @var int |
||
| 104 | */ |
||
| 105 | protected $position; |
||
| 106 | /** |
||
| 107 | * @var int |
||
| 108 | */ |
||
| 109 | protected $minPurchase; |
||
| 110 | /** |
||
| 111 | * @var int |
||
| 112 | */ |
||
| 113 | protected $purchaseSteps; |
||
| 114 | /** |
||
| 115 | * @var int |
||
| 116 | */ |
||
| 117 | protected $maxPurchase; |
||
| 118 | /** |
||
| 119 | * @var string |
||
| 120 | */ |
||
| 121 | protected $releaseDate; |
||
| 122 | /** |
||
| 123 | * @var bool |
||
| 124 | */ |
||
| 125 | protected $active; |
||
| 126 | /** |
||
| 127 | * @var bool |
||
| 128 | */ |
||
| 129 | protected $shippingFree; |
||
| 130 | |||
| 131 | /** |
||
| 132 | * @return int |
||
| 133 | */ |
||
| 134 | public function getId() |
||
| 138 | |||
| 139 | /** |
||
| 140 | * @param int $id |
||
| 141 | * |
||
| 142 | * @return ArticleDetail |
||
| 143 | */ |
||
| 144 | public function setId($id) |
||
| 150 | |||
| 151 | /** |
||
| 152 | * @return string |
||
| 153 | */ |
||
| 154 | public function getNumber() |
||
| 158 | |||
| 159 | /** |
||
| 160 | * @param string $number |
||
| 161 | * |
||
| 162 | * @return ArticleDetail |
||
| 163 | */ |
||
| 164 | public function setNumber($number) |
||
| 170 | |||
| 171 | /** |
||
| 172 | * @return string |
||
| 173 | */ |
||
| 174 | public function getSupplierNumber() |
||
| 178 | |||
| 179 | /** |
||
| 180 | * @param string $supplierNumber |
||
| 181 | * |
||
| 182 | * @return ArticleDetail |
||
| 183 | */ |
||
| 184 | public function setSupplierNumber($supplierNumber) |
||
| 190 | |||
| 191 | /** |
||
| 192 | * @return string |
||
| 193 | */ |
||
| 194 | public function getAdditionalText() |
||
| 198 | |||
| 199 | /** |
||
| 200 | * @param string $additionalText |
||
| 201 | * |
||
| 202 | * @return ArticleDetail |
||
| 203 | */ |
||
| 204 | public function setAdditionalText($additionalText) |
||
| 210 | |||
| 211 | /** |
||
| 212 | * @return string |
||
| 213 | */ |
||
| 214 | public function getWeight() |
||
| 218 | |||
| 219 | /** |
||
| 220 | * @param string $weight |
||
| 221 | * |
||
| 222 | * @return ArticleDetail |
||
| 223 | */ |
||
| 224 | public function setWeight($weight) |
||
| 230 | |||
| 231 | /** |
||
| 232 | * @return string |
||
| 233 | */ |
||
| 234 | public function getWidth() |
||
| 238 | |||
| 239 | /** |
||
| 240 | * @param string $width |
||
| 241 | * |
||
| 242 | * @return ArticleDetail |
||
| 243 | */ |
||
| 244 | public function setWidth($width) |
||
| 250 | |||
| 251 | /** |
||
| 252 | * @return string |
||
| 253 | */ |
||
| 254 | public function getLen() |
||
| 258 | |||
| 259 | /** |
||
| 260 | * @param string $len |
||
| 261 | * |
||
| 262 | * @return ArticleDetail |
||
| 263 | */ |
||
| 264 | public function setLen($len) |
||
| 270 | |||
| 271 | /** |
||
| 272 | * @return string |
||
| 273 | */ |
||
| 274 | public function getHeight() |
||
| 278 | |||
| 279 | /** |
||
| 280 | * @param string $height |
||
| 281 | * |
||
| 282 | * @return ArticleDetail |
||
| 283 | */ |
||
| 284 | public function setHeight($height) |
||
| 290 | |||
| 291 | /** |
||
| 292 | * @return string |
||
| 293 | */ |
||
| 294 | public function getEan() |
||
| 298 | |||
| 299 | /** |
||
| 300 | * @param string $ean |
||
| 301 | * |
||
| 302 | * @return ArticleDetail |
||
| 303 | */ |
||
| 304 | public function setEan($ean) |
||
| 310 | |||
| 311 | /** |
||
| 312 | * @return string |
||
| 313 | */ |
||
| 314 | public function getPurchaseUnit() |
||
| 318 | |||
| 319 | /** |
||
| 320 | * @param string $purchaseUnit |
||
| 321 | * |
||
| 322 | * @return ArticleDetail |
||
| 323 | */ |
||
| 324 | public function setPurchaseUnit($purchaseUnit) |
||
| 330 | |||
| 331 | /** |
||
| 332 | * @return string |
||
| 333 | */ |
||
| 334 | public function getDescriptionLong() |
||
| 338 | |||
| 339 | /** |
||
| 340 | * @param string $descriptionLong |
||
| 341 | * |
||
| 342 | * @return ArticleDetail |
||
| 343 | */ |
||
| 344 | public function setDescriptionLong($descriptionLong) |
||
| 350 | |||
| 351 | /** |
||
| 352 | * @return string |
||
| 353 | */ |
||
| 354 | public function getReferenceUnit() |
||
| 358 | |||
| 359 | /** |
||
| 360 | * @param string $referenceUnit |
||
| 361 | * |
||
| 362 | * @return ArticleDetail |
||
| 363 | */ |
||
| 364 | public function setReferenceUnit($referenceUnit) |
||
| 370 | |||
| 371 | /** |
||
| 372 | * @return string |
||
| 373 | */ |
||
| 374 | public function getPackUnit() |
||
| 378 | |||
| 379 | /** |
||
| 380 | * @param string $packUnit |
||
| 381 | * |
||
| 382 | * @return ArticleDetail |
||
| 383 | */ |
||
| 384 | public function setPackUnit($packUnit) |
||
| 390 | |||
| 391 | /** |
||
| 392 | * @return string |
||
| 393 | */ |
||
| 394 | public function getShippingTime() |
||
| 398 | |||
| 399 | /** |
||
| 400 | * @param string $shippingTime |
||
| 401 | * |
||
| 402 | * @return ArticleDetail |
||
| 403 | */ |
||
| 404 | public function setShippingTime($shippingTime) |
||
| 410 | |||
| 411 | /** |
||
| 412 | * @return Price[] |
||
| 413 | */ |
||
| 414 | public function getPrices() |
||
| 418 | |||
| 419 | /** |
||
| 420 | * @param Price[] $prices |
||
| 421 | * |
||
| 422 | * @return ArticleDetail |
||
| 423 | */ |
||
| 424 | public function setPrices($prices) |
||
| 430 | |||
| 431 | /** |
||
| 432 | * @return ConfiguratorOption[] |
||
| 433 | */ |
||
| 434 | public function getConfiguratorOptions() |
||
| 438 | |||
| 439 | /** |
||
| 440 | * @param ConfiguratorOption[] $configuratorOptions |
||
| 441 | * |
||
| 442 | * @return ArticleDetail |
||
| 443 | */ |
||
| 444 | public function setConfiguratorOptions($configuratorOptions) |
||
| 450 | |||
| 451 | /** |
||
| 452 | * @return ArticleAttribute |
||
| 453 | */ |
||
| 454 | public function getAttributes() |
||
| 458 | |||
| 459 | /** |
||
| 460 | * @param ArticleAttribute $attribute |
||
| 461 | * |
||
| 462 | * @return ArticleDetail |
||
| 463 | */ |
||
| 464 | public function setAttributes($attribute) |
||
| 470 | |||
| 471 | /** |
||
| 472 | * @return int |
||
| 473 | */ |
||
| 474 | public function getArticleId() |
||
| 478 | |||
| 479 | /** |
||
| 480 | * @param int $articleId |
||
| 481 | * |
||
| 482 | * @return ArticleDetail |
||
| 483 | */ |
||
| 484 | public function setArticleId($articleId) |
||
| 490 | |||
| 491 | /** |
||
| 492 | * @return int |
||
| 493 | */ |
||
| 494 | public function getUnitId() |
||
| 498 | |||
| 499 | /** |
||
| 500 | * @param int $unitId |
||
| 501 | * |
||
| 502 | * @return ArticleDetail |
||
| 503 | */ |
||
| 504 | public function setUnitId($unitId) |
||
| 510 | |||
| 511 | /** |
||
| 512 | * @return int |
||
| 513 | */ |
||
| 514 | public function getKind() |
||
| 518 | |||
| 519 | /** |
||
| 520 | * @param int $kind |
||
| 521 | * |
||
| 522 | * @return ArticleDetail |
||
| 523 | */ |
||
| 524 | public function setKind($kind) |
||
| 530 | |||
| 531 | /** |
||
| 532 | * @return int |
||
| 533 | */ |
||
| 534 | public function getInStock() |
||
| 538 | |||
| 539 | /** |
||
| 540 | * @param int $inStock |
||
| 541 | * |
||
| 542 | * @return ArticleDetail |
||
| 543 | */ |
||
| 544 | public function setInStock($inStock) |
||
| 550 | |||
| 551 | /** |
||
| 552 | * @return int |
||
| 553 | */ |
||
| 554 | public function getPosition() |
||
| 558 | |||
| 559 | /** |
||
| 560 | * @param int $position |
||
| 561 | * |
||
| 562 | * @return ArticleDetail |
||
| 563 | */ |
||
| 564 | public function setPosition($position) |
||
| 570 | |||
| 571 | /** |
||
| 572 | * @return int |
||
| 573 | */ |
||
| 574 | public function getMinPurchase() |
||
| 578 | |||
| 579 | /** |
||
| 580 | * @param int $minPurchase |
||
| 581 | * |
||
| 582 | * @return ArticleDetail |
||
| 583 | */ |
||
| 584 | public function setMinPurchase($minPurchase) |
||
| 590 | |||
| 591 | /** |
||
| 592 | * @return int |
||
| 593 | */ |
||
| 594 | public function getPurchaseSteps() |
||
| 598 | |||
| 599 | /** |
||
| 600 | * @param int $purchaseSteps |
||
| 601 | * |
||
| 602 | * @return ArticleDetail |
||
| 603 | */ |
||
| 604 | public function setPurchaseSteps($purchaseSteps) |
||
| 610 | |||
| 611 | /** |
||
| 612 | * @return int |
||
| 613 | */ |
||
| 614 | public function getMaxPurchase() |
||
| 618 | |||
| 619 | /** |
||
| 620 | * @param int $maxPurchase |
||
| 621 | * |
||
| 622 | * @return ArticleDetail |
||
| 623 | */ |
||
| 624 | public function setMaxPurchase($maxPurchase) |
||
| 630 | |||
| 631 | /** |
||
| 632 | * @return string |
||
| 633 | */ |
||
| 634 | public function getReleaseDate() |
||
| 638 | |||
| 639 | /** |
||
| 640 | * @param string $releaseDate |
||
| 641 | * |
||
| 642 | * @return ArticleDetail |
||
| 643 | */ |
||
| 644 | public function setReleaseDate($releaseDate) |
||
| 650 | |||
| 651 | /** |
||
| 652 | * @return bool |
||
| 653 | */ |
||
| 654 | public function isActive() |
||
| 658 | |||
| 659 | /** |
||
| 660 | * @param bool $active |
||
| 661 | * |
||
| 662 | * @return ArticleDetail |
||
| 663 | */ |
||
| 664 | public function setActive($active) |
||
| 670 | |||
| 671 | /** |
||
| 672 | * @return bool |
||
| 673 | */ |
||
| 674 | public function isShippingFree() |
||
| 678 | |||
| 679 | /** |
||
| 680 | * @param bool $shippingFree |
||
| 681 | * |
||
| 682 | * @return ArticleDetail |
||
| 683 | */ |
||
| 684 | public function setShippingFree($shippingFree) |
||
| 690 | } |
||
| 691 |