Complex classes like ArticleAttribute often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ArticleAttribute, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 16 | class ArticleAttribute extends Base |
||
| 17 | { |
||
| 18 | /** |
||
| 19 | * @var mixed |
||
| 20 | */ |
||
| 21 | protected $attr1; |
||
| 22 | /** |
||
| 23 | * @var mixed |
||
| 24 | */ |
||
| 25 | protected $attr2; |
||
| 26 | /** |
||
| 27 | * @var mixed |
||
| 28 | */ |
||
| 29 | protected $attr3; |
||
| 30 | /** |
||
| 31 | * @var mixed |
||
| 32 | */ |
||
| 33 | protected $attr4; |
||
| 34 | /** |
||
| 35 | * @var mixed |
||
| 36 | */ |
||
| 37 | protected $attr5; |
||
| 38 | /** |
||
| 39 | * @var mixed |
||
| 40 | */ |
||
| 41 | protected $attr6; |
||
| 42 | /** |
||
| 43 | * @var mixed |
||
| 44 | */ |
||
| 45 | protected $attr7; |
||
| 46 | /** |
||
| 47 | * @var mixed |
||
| 48 | */ |
||
| 49 | protected $attr8; |
||
| 50 | /** |
||
| 51 | * @var mixed |
||
| 52 | */ |
||
| 53 | protected $attr9; |
||
| 54 | /** |
||
| 55 | * @var mixed |
||
| 56 | */ |
||
| 57 | protected $attr10; |
||
| 58 | /** |
||
| 59 | * @var mixed |
||
| 60 | */ |
||
| 61 | protected $attr11; |
||
| 62 | /** |
||
| 63 | * @var mixed |
||
| 64 | */ |
||
| 65 | protected $attr12; |
||
| 66 | /** |
||
| 67 | * @var mixed |
||
| 68 | */ |
||
| 69 | protected $attr13; |
||
| 70 | /** |
||
| 71 | * @var mixed |
||
| 72 | */ |
||
| 73 | protected $attr14; |
||
| 74 | /** |
||
| 75 | * @var mixed |
||
| 76 | */ |
||
| 77 | protected $attr15; |
||
| 78 | /** |
||
| 79 | * @var mixed |
||
| 80 | */ |
||
| 81 | protected $attr16; |
||
| 82 | /** |
||
| 83 | * @var mixed |
||
| 84 | */ |
||
| 85 | protected $attr17; |
||
| 86 | /** |
||
| 87 | * @var mixed |
||
| 88 | */ |
||
| 89 | protected $attr18; |
||
| 90 | /** |
||
| 91 | * @var mixed |
||
| 92 | */ |
||
| 93 | protected $attr19; |
||
| 94 | /** |
||
| 95 | * @var mixed |
||
| 96 | */ |
||
| 97 | protected $attr20; |
||
| 98 | /** |
||
| 99 | * @var int |
||
| 100 | */ |
||
| 101 | protected $articleId; |
||
| 102 | /** |
||
| 103 | * @var int |
||
| 104 | */ |
||
| 105 | protected $articleDetailId; |
||
| 106 | |||
| 107 | /** |
||
| 108 | * @return mixed |
||
| 109 | */ |
||
| 110 | public function getAttr1() |
||
| 114 | |||
| 115 | /** |
||
| 116 | * @param mixed $attr1 |
||
| 117 | * |
||
| 118 | * @return ArticleAttribute |
||
| 119 | */ |
||
| 120 | public function setAttr1($attr1) |
||
| 126 | |||
| 127 | /** |
||
| 128 | * @return mixed |
||
| 129 | */ |
||
| 130 | public function getAttr2() |
||
| 134 | |||
| 135 | /** |
||
| 136 | * @param mixed $attr2 |
||
| 137 | * |
||
| 138 | * @return ArticleAttribute |
||
| 139 | */ |
||
| 140 | public function setAttr2($attr2) |
||
| 146 | |||
| 147 | /** |
||
| 148 | * @return mixed |
||
| 149 | */ |
||
| 150 | public function getAttr3() |
||
| 154 | |||
| 155 | /** |
||
| 156 | * @param mixed $attr3 |
||
| 157 | * |
||
| 158 | * @return ArticleAttribute |
||
| 159 | */ |
||
| 160 | public function setAttr3($attr3) |
||
| 166 | |||
| 167 | /** |
||
| 168 | * @return mixed |
||
| 169 | */ |
||
| 170 | public function getAttr4() |
||
| 174 | |||
| 175 | /** |
||
| 176 | * @param mixed $attr4 |
||
| 177 | * |
||
| 178 | * @return ArticleAttribute |
||
| 179 | */ |
||
| 180 | public function setAttr4($attr4) |
||
| 186 | |||
| 187 | /** |
||
| 188 | * @return mixed |
||
| 189 | */ |
||
| 190 | public function getAttr5() |
||
| 194 | |||
| 195 | /** |
||
| 196 | * @param mixed $attr5 |
||
| 197 | * |
||
| 198 | * @return ArticleAttribute |
||
| 199 | */ |
||
| 200 | public function setAttr5($attr5) |
||
| 206 | |||
| 207 | /** |
||
| 208 | * @return mixed |
||
| 209 | */ |
||
| 210 | public function getAttr6() |
||
| 214 | |||
| 215 | /** |
||
| 216 | * @param mixed $attr6 |
||
| 217 | * |
||
| 218 | * @return ArticleAttribute |
||
| 219 | */ |
||
| 220 | public function setAttr6($attr6) |
||
| 226 | |||
| 227 | /** |
||
| 228 | * @return mixed |
||
| 229 | */ |
||
| 230 | public function getAttr7() |
||
| 234 | |||
| 235 | /** |
||
| 236 | * @param mixed $attr7 |
||
| 237 | * |
||
| 238 | * @return ArticleAttribute |
||
| 239 | */ |
||
| 240 | public function setAttr7($attr7) |
||
| 246 | |||
| 247 | /** |
||
| 248 | * @return mixed |
||
| 249 | */ |
||
| 250 | public function getAttr8() |
||
| 254 | |||
| 255 | /** |
||
| 256 | * @param mixed $attr8 |
||
| 257 | * |
||
| 258 | * @return ArticleAttribute |
||
| 259 | */ |
||
| 260 | public function setAttr8($attr8) |
||
| 266 | |||
| 267 | /** |
||
| 268 | * @return mixed |
||
| 269 | */ |
||
| 270 | public function getAttr9() |
||
| 274 | |||
| 275 | /** |
||
| 276 | * @param mixed $attr9 |
||
| 277 | * |
||
| 278 | * @return ArticleAttribute |
||
| 279 | */ |
||
| 280 | public function setAttr9($attr9) |
||
| 286 | |||
| 287 | /** |
||
| 288 | * @return mixed |
||
| 289 | */ |
||
| 290 | public function getAttr10() |
||
| 294 | |||
| 295 | /** |
||
| 296 | * @param mixed $attr10 |
||
| 297 | * |
||
| 298 | * @return ArticleAttribute |
||
| 299 | */ |
||
| 300 | public function setAttr10($attr10) |
||
| 306 | |||
| 307 | /** |
||
| 308 | * @return mixed |
||
| 309 | */ |
||
| 310 | public function getAttr11() |
||
| 314 | |||
| 315 | /** |
||
| 316 | * @param mixed $attr11 |
||
| 317 | * |
||
| 318 | * @return ArticleAttribute |
||
| 319 | */ |
||
| 320 | public function setAttr11($attr11) |
||
| 326 | |||
| 327 | /** |
||
| 328 | * @return mixed |
||
| 329 | */ |
||
| 330 | public function getAttr12() |
||
| 334 | |||
| 335 | /** |
||
| 336 | * @param mixed $attr12 |
||
| 337 | * |
||
| 338 | * @return ArticleAttribute |
||
| 339 | */ |
||
| 340 | public function setAttr12($attr12) |
||
| 346 | |||
| 347 | /** |
||
| 348 | * @return mixed |
||
| 349 | */ |
||
| 350 | public function getAttr13() |
||
| 354 | |||
| 355 | /** |
||
| 356 | * @param mixed $attr13 |
||
| 357 | * |
||
| 358 | * @return ArticleAttribute |
||
| 359 | */ |
||
| 360 | public function setAttr13($attr13) |
||
| 366 | |||
| 367 | /** |
||
| 368 | * @return mixed |
||
| 369 | */ |
||
| 370 | public function getAttr14() |
||
| 374 | |||
| 375 | /** |
||
| 376 | * @param mixed $attr14 |
||
| 377 | * |
||
| 378 | * @return ArticleAttribute |
||
| 379 | */ |
||
| 380 | public function setAttr14($attr14) |
||
| 386 | |||
| 387 | /** |
||
| 388 | * @return mixed |
||
| 389 | */ |
||
| 390 | public function getAttr15() |
||
| 394 | |||
| 395 | /** |
||
| 396 | * @param mixed $attr15 |
||
| 397 | * |
||
| 398 | * @return ArticleAttribute |
||
| 399 | */ |
||
| 400 | public function setAttr15($attr15) |
||
| 406 | |||
| 407 | /** |
||
| 408 | * @return mixed |
||
| 409 | */ |
||
| 410 | public function getAttr16() |
||
| 414 | |||
| 415 | /** |
||
| 416 | * @param mixed $attr16 |
||
| 417 | * |
||
| 418 | * @return ArticleAttribute |
||
| 419 | */ |
||
| 420 | public function setAttr16($attr16) |
||
| 426 | |||
| 427 | /** |
||
| 428 | * @return mixed |
||
| 429 | */ |
||
| 430 | public function getAttr17() |
||
| 434 | |||
| 435 | /** |
||
| 436 | * @param mixed $attr17 |
||
| 437 | * |
||
| 438 | * @return ArticleAttribute |
||
| 439 | */ |
||
| 440 | public function setAttr17($attr17) |
||
| 446 | |||
| 447 | /** |
||
| 448 | * @return mixed |
||
| 449 | */ |
||
| 450 | public function getAttr18() |
||
| 454 | |||
| 455 | /** |
||
| 456 | * @param mixed $attr18 |
||
| 457 | * |
||
| 458 | * @return ArticleAttribute |
||
| 459 | */ |
||
| 460 | public function setAttr18($attr18) |
||
| 466 | |||
| 467 | /** |
||
| 468 | * @return mixed |
||
| 469 | */ |
||
| 470 | public function getAttr19() |
||
| 474 | |||
| 475 | /** |
||
| 476 | * @param mixed $attr19 |
||
| 477 | * |
||
| 478 | * @return ArticleAttribute |
||
| 479 | */ |
||
| 480 | public function setAttr19($attr19) |
||
| 486 | |||
| 487 | /** |
||
| 488 | * @return mixed |
||
| 489 | */ |
||
| 490 | public function getAttr20() |
||
| 494 | |||
| 495 | /** |
||
| 496 | * @param mixed $attr20 |
||
| 497 | * |
||
| 498 | * @return ArticleAttribute |
||
| 499 | */ |
||
| 500 | public function setAttr20($attr20) |
||
| 506 | |||
| 507 | /** |
||
| 508 | * @return int |
||
| 509 | */ |
||
| 510 | public function getArticleId() |
||
| 514 | |||
| 515 | /** |
||
| 516 | * @param int $articleId |
||
| 517 | * |
||
| 518 | * @return ArticleAttribute |
||
| 519 | */ |
||
| 520 | public function setArticleId($articleId) |
||
| 526 | |||
| 527 | /** |
||
| 528 | * @return int |
||
| 529 | */ |
||
| 530 | public function getArticleDetailId() |
||
| 534 | |||
| 535 | /** |
||
| 536 | * @param int $articleDetailId |
||
| 537 | * |
||
| 538 | * @return ArticleAttribute |
||
| 539 | */ |
||
| 540 | public function setArticleDetailId($articleDetailId) |
||
| 546 | } |
||
| 547 |