Complex classes like Article often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Article, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
16 | class Article extends Base |
||
17 | { |
||
18 | /** |
||
19 | * @var int |
||
20 | */ |
||
21 | protected $id; |
||
22 | /** |
||
23 | * @var int |
||
24 | */ |
||
25 | protected $mainDetailId; |
||
26 | /** |
||
27 | * @var int |
||
28 | */ |
||
29 | protected $supplierId; |
||
30 | /** |
||
31 | * @var string |
||
32 | */ |
||
33 | protected $supplier; |
||
34 | /** |
||
35 | * @var int |
||
36 | */ |
||
37 | protected $taxId; |
||
38 | /** |
||
39 | * @var float |
||
40 | */ |
||
41 | protected $tax; |
||
42 | /** |
||
43 | * @var int |
||
44 | */ |
||
45 | protected $priceGroupId; |
||
46 | /** |
||
47 | * @var int |
||
48 | */ |
||
49 | protected $filterGroupId; |
||
50 | /** |
||
51 | * @var int |
||
52 | */ |
||
53 | protected $configuratorSetId; |
||
54 | /** |
||
55 | * @var string |
||
56 | */ |
||
57 | protected $name; |
||
58 | /** |
||
59 | * @var string |
||
60 | */ |
||
61 | protected $description; |
||
62 | /** |
||
63 | * @var string |
||
64 | */ |
||
65 | protected $descriptionLong; |
||
66 | /** |
||
67 | * @var string |
||
68 | */ |
||
69 | protected $added; |
||
70 | /** |
||
71 | * @var bool |
||
72 | */ |
||
73 | protected $active; |
||
74 | /** |
||
75 | * @var int |
||
76 | */ |
||
77 | protected $pseudoSales; |
||
78 | /** |
||
79 | * @var bool |
||
80 | */ |
||
81 | protected $highlight; |
||
82 | /** |
||
83 | * @var string |
||
84 | */ |
||
85 | protected $keywords; |
||
86 | /** |
||
87 | * @var string |
||
88 | */ |
||
89 | protected $metaTitle; |
||
90 | /** |
||
91 | * @var string |
||
92 | */ |
||
93 | protected $changed; |
||
94 | /** |
||
95 | * @var bool |
||
96 | */ |
||
97 | protected $priceGroupActive; |
||
98 | /** |
||
99 | * @var bool |
||
100 | */ |
||
101 | protected $lastStock; |
||
102 | /** |
||
103 | * @var bool |
||
104 | */ |
||
105 | protected $crossBundleLook; |
||
106 | /** |
||
107 | * @var bool |
||
108 | */ |
||
109 | protected $notification; |
||
110 | /** |
||
111 | * @var string |
||
112 | */ |
||
113 | protected $template; |
||
114 | /** |
||
115 | * @var int |
||
116 | */ |
||
117 | protected $mode; |
||
118 | /** |
||
119 | * @var string |
||
120 | */ |
||
121 | protected $availableFrom; |
||
122 | /** |
||
123 | * @var string |
||
124 | */ |
||
125 | protected $availableTo; |
||
126 | /** |
||
127 | * @var ArticleAttribute |
||
128 | */ |
||
129 | protected $attribute; |
||
130 | /** |
||
131 | * @var Category[] |
||
132 | */ |
||
133 | protected $categories; |
||
134 | /** |
||
135 | * @var ArticleDetail |
||
136 | */ |
||
137 | protected $mainDetail; |
||
138 | |||
139 | /** |
||
140 | * @return int |
||
141 | */ |
||
142 | public function getId() |
||
146 | |||
147 | /** |
||
148 | * @param int $id |
||
149 | * |
||
150 | * @return Article |
||
151 | */ |
||
152 | public function setId($id) |
||
158 | |||
159 | /** |
||
160 | * @return int |
||
161 | */ |
||
162 | public function getMainDetailId() |
||
166 | |||
167 | /** |
||
168 | * @param int $mainDetailId |
||
169 | * |
||
170 | * @return Article |
||
171 | */ |
||
172 | public function setMainDetailId($mainDetailId) |
||
178 | |||
179 | /** |
||
180 | * @return int |
||
181 | */ |
||
182 | public function getSupplierId() |
||
186 | |||
187 | /** |
||
188 | * @param int $supplierId |
||
189 | * |
||
190 | * @return Article |
||
191 | */ |
||
192 | public function setSupplierId($supplierId) |
||
198 | |||
199 | /** |
||
200 | * @return string |
||
201 | */ |
||
202 | public function getSupplier() |
||
206 | |||
207 | /** |
||
208 | * @param string $supplier |
||
209 | */ |
||
210 | public function setSupplier($supplier) |
||
214 | |||
215 | /** |
||
216 | * @return int |
||
217 | */ |
||
218 | public function getTaxId() |
||
222 | |||
223 | /** |
||
224 | * @param int $taxId |
||
225 | * |
||
226 | * @return Article |
||
227 | */ |
||
228 | public function setTaxId($taxId) |
||
234 | |||
235 | /** |
||
236 | * @return float |
||
237 | */ |
||
238 | public function getTax() |
||
242 | |||
243 | /** |
||
244 | * @param float $tax |
||
245 | */ |
||
246 | public function setTax($tax) |
||
250 | |||
251 | /** |
||
252 | * @return int |
||
253 | */ |
||
254 | public function getPriceGroupId() |
||
258 | |||
259 | /** |
||
260 | * @param int $priceGroupId |
||
261 | * |
||
262 | * @return Article |
||
263 | */ |
||
264 | public function setPriceGroupId($priceGroupId) |
||
270 | |||
271 | /** |
||
272 | * @return int |
||
273 | */ |
||
274 | public function getFilterGroupId() |
||
278 | |||
279 | /** |
||
280 | * @param int $filterGroupId |
||
281 | * |
||
282 | * @return Article |
||
283 | */ |
||
284 | public function setFilterGroupId($filterGroupId) |
||
290 | |||
291 | /** |
||
292 | * @return int |
||
293 | */ |
||
294 | public function getConfiguratorSetId() |
||
298 | |||
299 | /** |
||
300 | * @param int $configuratorSetId |
||
301 | * |
||
302 | * @return Article |
||
303 | */ |
||
304 | public function setConfiguratorSetId($configuratorSetId) |
||
310 | |||
311 | /** |
||
312 | * @return string |
||
313 | */ |
||
314 | public function getName() |
||
318 | |||
319 | /** |
||
320 | * @param string $name |
||
321 | * |
||
322 | * @return Article |
||
323 | */ |
||
324 | public function setName($name) |
||
330 | |||
331 | /** |
||
332 | * @return string |
||
333 | */ |
||
334 | public function getDescription() |
||
338 | |||
339 | /** |
||
340 | * @param string $description |
||
341 | * |
||
342 | * @return Article |
||
343 | */ |
||
344 | public function setDescription($description) |
||
350 | |||
351 | /** |
||
352 | * @return string |
||
353 | */ |
||
354 | public function getDescriptionLong() |
||
358 | |||
359 | /** |
||
360 | * @param string $descriptionLong |
||
361 | * |
||
362 | * @return Article |
||
363 | */ |
||
364 | public function setDescriptionLong($descriptionLong) |
||
370 | |||
371 | /** |
||
372 | * @return string |
||
373 | */ |
||
374 | public function getAdded() |
||
378 | |||
379 | /** |
||
380 | * @param string $added |
||
381 | * |
||
382 | * @return Article |
||
383 | */ |
||
384 | public function setAdded($added) |
||
390 | |||
391 | /** |
||
392 | * @return bool |
||
393 | */ |
||
394 | public function isActive() |
||
398 | |||
399 | /** |
||
400 | * @param bool $active |
||
401 | * |
||
402 | * @return Article |
||
403 | */ |
||
404 | public function setActive($active) |
||
410 | |||
411 | /** |
||
412 | * @return int |
||
413 | */ |
||
414 | public function getPseudoSales() |
||
418 | |||
419 | /** |
||
420 | * @param int $pseudoSales |
||
421 | * |
||
422 | * @return Article |
||
423 | */ |
||
424 | public function setPseudoSales($pseudoSales) |
||
430 | |||
431 | /** |
||
432 | * @return bool |
||
433 | */ |
||
434 | public function isHighlight() |
||
438 | |||
439 | /** |
||
440 | * @param bool $highlight |
||
441 | * |
||
442 | * @return Article |
||
443 | */ |
||
444 | public function setHighlight($highlight) |
||
450 | |||
451 | /** |
||
452 | * @return string |
||
453 | */ |
||
454 | public function getKeywords() |
||
458 | |||
459 | /** |
||
460 | * @param string $keywords |
||
461 | * |
||
462 | * @return Article |
||
463 | */ |
||
464 | public function setKeywords($keywords) |
||
470 | |||
471 | /** |
||
472 | * @return string |
||
473 | */ |
||
474 | public function getMetaTitle() |
||
478 | |||
479 | /** |
||
480 | * @param string $metaTitle |
||
481 | * |
||
482 | * @return Article |
||
483 | */ |
||
484 | public function setMetaTitle($metaTitle) |
||
490 | |||
491 | /** |
||
492 | * @return string |
||
493 | */ |
||
494 | public function getChanged() |
||
498 | |||
499 | /** |
||
500 | * @param string $changed |
||
501 | * |
||
502 | * @return Article |
||
503 | */ |
||
504 | public function setChanged($changed) |
||
510 | |||
511 | /** |
||
512 | * @return bool |
||
513 | */ |
||
514 | public function isPriceGroupActive() |
||
518 | |||
519 | /** |
||
520 | * @param bool $priceGroupActive |
||
521 | * |
||
522 | * @return Article |
||
523 | */ |
||
524 | public function setPriceGroupActive($priceGroupActive) |
||
530 | |||
531 | /** |
||
532 | * @return bool |
||
533 | */ |
||
534 | public function isLastStock() |
||
538 | |||
539 | /** |
||
540 | * @param bool $lastStock |
||
541 | * |
||
542 | * @return Article |
||
543 | */ |
||
544 | public function setLastStock($lastStock) |
||
550 | |||
551 | /** |
||
552 | * @return bool |
||
553 | */ |
||
554 | public function isCrossBundleLook() |
||
558 | |||
559 | /** |
||
560 | * @param bool $crossBundleLook |
||
561 | * |
||
562 | * @return Article |
||
563 | */ |
||
564 | public function setCrossBundleLook($crossBundleLook) |
||
570 | |||
571 | /** |
||
572 | * @return bool |
||
573 | */ |
||
574 | public function isNotification() |
||
578 | |||
579 | /** |
||
580 | * @param bool $notification |
||
581 | * |
||
582 | * @return Article |
||
583 | */ |
||
584 | public function setNotification($notification) |
||
590 | |||
591 | /** |
||
592 | * @return string |
||
593 | */ |
||
594 | public function getTemplate() |
||
598 | |||
599 | /** |
||
600 | * @param string $template |
||
601 | * |
||
602 | * @return Article |
||
603 | */ |
||
604 | public function setTemplate($template) |
||
610 | |||
611 | /** |
||
612 | * @return int |
||
613 | */ |
||
614 | public function getMode() |
||
618 | |||
619 | /** |
||
620 | * @param int $mode |
||
621 | * |
||
622 | * @return Article |
||
623 | */ |
||
624 | public function setMode($mode) |
||
630 | |||
631 | /** |
||
632 | * @return string |
||
633 | */ |
||
634 | public function getAvailableFrom() |
||
638 | |||
639 | /** |
||
640 | * @param string $availableFrom |
||
641 | * |
||
642 | * @return Article |
||
643 | */ |
||
644 | public function setAvailableFrom($availableFrom) |
||
650 | |||
651 | /** |
||
652 | * @return string |
||
653 | */ |
||
654 | public function getAvailableTo() |
||
658 | |||
659 | /** |
||
660 | * @param string $availableTo |
||
661 | * |
||
662 | * @return Article |
||
663 | */ |
||
664 | public function setAvailableTo($availableTo) |
||
670 | |||
671 | /** |
||
672 | * @return array |
||
673 | */ |
||
674 | public function getAttributes() |
||
678 | |||
679 | /** |
||
680 | * @param ArticleAttribute $attributes |
||
681 | * |
||
682 | * @return Article |
||
683 | */ |
||
684 | public function setAttributes($attributes) |
||
690 | |||
691 | /** |
||
692 | * @return mixed |
||
693 | */ |
||
694 | public function getCategories() |
||
698 | |||
699 | /** |
||
700 | * @param Category[] $categories |
||
701 | * |
||
702 | * @return Article |
||
703 | */ |
||
704 | public function setCategories($categories) |
||
710 | |||
711 | /** |
||
712 | * @return ArticleDetail |
||
713 | */ |
||
714 | public function getMainDetail(): ArticleDetail |
||
718 | |||
719 | /** |
||
720 | * @param ArticleDetail $mainDetail |
||
721 | */ |
||
722 | public function setMainDetail(ArticleDetail $mainDetail) |
||
726 | |||
727 | /** |
||
728 | * @return array |
||
729 | */ |
||
730 | public function getArrayCopy() |
||
740 | } |
||
741 |