Complex classes like Article often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Article, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | class Article extends Base |
||
19 | { |
||
20 | /** |
||
21 | * @var int |
||
22 | */ |
||
23 | protected $id; |
||
24 | /** |
||
25 | * @var int |
||
26 | */ |
||
27 | protected $mainDetailId; |
||
28 | /** |
||
29 | * @var int |
||
30 | */ |
||
31 | protected $supplierId; |
||
32 | /** |
||
33 | * @var string |
||
34 | */ |
||
35 | protected $supplier; |
||
36 | /** |
||
37 | * @var int |
||
38 | */ |
||
39 | protected $taxId; |
||
40 | /** |
||
41 | * @var float |
||
42 | */ |
||
43 | protected $tax; |
||
44 | /** |
||
45 | * @var int |
||
46 | */ |
||
47 | protected $priceGroupId; |
||
48 | /** |
||
49 | * @var int |
||
50 | */ |
||
51 | protected $filterGroupId; |
||
52 | /** |
||
53 | * @var int |
||
54 | */ |
||
55 | protected $configuratorSetId; |
||
56 | /** |
||
57 | * @var string |
||
58 | */ |
||
59 | protected $name; |
||
60 | /** |
||
61 | * @var string |
||
62 | */ |
||
63 | protected $description; |
||
64 | /** |
||
65 | * @var string |
||
66 | */ |
||
67 | protected $descriptionLong; |
||
68 | /** |
||
69 | * @var string |
||
70 | */ |
||
71 | protected $added; |
||
72 | /** |
||
73 | * @var bool |
||
74 | */ |
||
75 | protected $active; |
||
76 | /** |
||
77 | * @var int |
||
78 | */ |
||
79 | protected $pseudoSales; |
||
80 | /** |
||
81 | * @var bool |
||
82 | */ |
||
83 | protected $highlight; |
||
84 | /** |
||
85 | * @var string |
||
86 | */ |
||
87 | protected $keywords; |
||
88 | /** |
||
89 | * @var string |
||
90 | */ |
||
91 | protected $metaTitle; |
||
92 | /** |
||
93 | * @var string |
||
94 | */ |
||
95 | protected $changed; |
||
96 | /** |
||
97 | * @var bool |
||
98 | */ |
||
99 | protected $priceGroupActive; |
||
100 | /** |
||
101 | * @var bool |
||
102 | */ |
||
103 | protected $lastStock; |
||
104 | /** |
||
105 | * @var bool |
||
106 | */ |
||
107 | protected $crossBundleLook; |
||
108 | /** |
||
109 | * @var bool |
||
110 | */ |
||
111 | protected $notification; |
||
112 | /** |
||
113 | * @var string |
||
114 | */ |
||
115 | protected $template; |
||
116 | /** |
||
117 | * @var int |
||
118 | */ |
||
119 | protected $mode; |
||
120 | /** |
||
121 | * @var string |
||
122 | */ |
||
123 | protected $availableFrom; |
||
124 | /** |
||
125 | * @var string |
||
126 | */ |
||
127 | protected $availableTo; |
||
128 | /** |
||
129 | * @var ArticleAttribute |
||
130 | */ |
||
131 | protected $attribute; |
||
132 | /** |
||
133 | * @var Category[] |
||
134 | */ |
||
135 | protected $categories; |
||
136 | /** |
||
137 | * @var ArticleDetail |
||
138 | */ |
||
139 | protected $mainDetail; |
||
140 | |||
141 | /** |
||
142 | * @return int |
||
143 | */ |
||
144 | 5 | public function getId() |
|
148 | |||
149 | /** |
||
150 | * @param int $id |
||
151 | * |
||
152 | * @return Article |
||
153 | */ |
||
154 | 13 | public function setId($id) |
|
160 | |||
161 | /** |
||
162 | * @return int |
||
163 | */ |
||
164 | 3 | public function getMainDetailId() |
|
168 | |||
169 | /** |
||
170 | * @param int $mainDetailId |
||
171 | * |
||
172 | * @return Article |
||
173 | */ |
||
174 | 12 | public function setMainDetailId($mainDetailId) |
|
180 | |||
181 | /** |
||
182 | * @return int |
||
183 | */ |
||
184 | public function getSupplierId() |
||
188 | |||
189 | /** |
||
190 | * @param int $supplierId |
||
191 | * |
||
192 | * @return Article |
||
193 | */ |
||
194 | 11 | public function setSupplierId($supplierId) |
|
200 | |||
201 | /** |
||
202 | * @return string |
||
203 | */ |
||
204 | public function getSupplier() |
||
208 | |||
209 | /** |
||
210 | * @param string $supplier |
||
211 | */ |
||
212 | public function setSupplier($supplier) |
||
216 | |||
217 | /** |
||
218 | * @return int |
||
219 | */ |
||
220 | public function getTaxId() |
||
224 | |||
225 | /** |
||
226 | * @param int $taxId |
||
227 | * |
||
228 | * @return Article |
||
229 | */ |
||
230 | 13 | public function setTaxId($taxId) |
|
236 | |||
237 | /** |
||
238 | * @return float |
||
239 | */ |
||
240 | public function getTax() |
||
244 | |||
245 | /** |
||
246 | * @param float $tax |
||
247 | */ |
||
248 | public function setTax($tax) |
||
252 | |||
253 | /** |
||
254 | * @return int |
||
255 | */ |
||
256 | public function getPriceGroupId() |
||
260 | |||
261 | /** |
||
262 | * @param int $priceGroupId |
||
263 | * |
||
264 | * @return Article |
||
265 | */ |
||
266 | 11 | public function setPriceGroupId($priceGroupId) |
|
272 | |||
273 | /** |
||
274 | * @return int |
||
275 | */ |
||
276 | public function getFilterGroupId() |
||
280 | |||
281 | /** |
||
282 | * @param int $filterGroupId |
||
283 | * |
||
284 | * @return Article |
||
285 | */ |
||
286 | 11 | public function setFilterGroupId($filterGroupId) |
|
292 | |||
293 | /** |
||
294 | * @return int |
||
295 | */ |
||
296 | public function getConfiguratorSetId() |
||
300 | |||
301 | /** |
||
302 | * @param int $configuratorSetId |
||
303 | * |
||
304 | * @return Article |
||
305 | */ |
||
306 | 11 | public function setConfiguratorSetId($configuratorSetId) |
|
312 | |||
313 | /** |
||
314 | * @return string |
||
315 | */ |
||
316 | 5 | public function getName() |
|
320 | |||
321 | /** |
||
322 | * @param string $name |
||
323 | * |
||
324 | * @return Article |
||
325 | */ |
||
326 | 12 | public function setName($name) |
|
332 | |||
333 | /** |
||
334 | * @return string |
||
335 | */ |
||
336 | public function getDescription() |
||
340 | |||
341 | /** |
||
342 | * @param string $description |
||
343 | * |
||
344 | * @return Article |
||
345 | */ |
||
346 | 11 | public function setDescription($description) |
|
352 | |||
353 | /** |
||
354 | * @return string |
||
355 | */ |
||
356 | public function getDescriptionLong() |
||
360 | |||
361 | /** |
||
362 | * @param string $descriptionLong |
||
363 | * |
||
364 | * @return Article |
||
365 | */ |
||
366 | 11 | public function setDescriptionLong($descriptionLong) |
|
372 | |||
373 | /** |
||
374 | * @return string |
||
375 | */ |
||
376 | public function getAdded() |
||
380 | |||
381 | /** |
||
382 | * @param string $added |
||
383 | * |
||
384 | * @return Article |
||
385 | */ |
||
386 | 11 | public function setAdded($added) |
|
392 | |||
393 | /** |
||
394 | * @return bool |
||
395 | */ |
||
396 | 2 | public function isActive() |
|
400 | |||
401 | /** |
||
402 | * @param bool $active |
||
403 | * |
||
404 | * @return Article |
||
405 | */ |
||
406 | 11 | public function setActive($active) |
|
412 | |||
413 | /** |
||
414 | * @return int |
||
415 | */ |
||
416 | public function getPseudoSales() |
||
420 | |||
421 | /** |
||
422 | * @param int $pseudoSales |
||
423 | * |
||
424 | * @return Article |
||
425 | */ |
||
426 | 11 | public function setPseudoSales($pseudoSales) |
|
432 | |||
433 | /** |
||
434 | * @return bool |
||
435 | */ |
||
436 | public function isHighlight() |
||
440 | |||
441 | /** |
||
442 | * @param bool $highlight |
||
443 | * |
||
444 | * @return Article |
||
445 | */ |
||
446 | 11 | public function setHighlight($highlight) |
|
452 | |||
453 | /** |
||
454 | * @return string |
||
455 | */ |
||
456 | public function getKeywords() |
||
460 | |||
461 | /** |
||
462 | * @param string $keywords |
||
463 | * |
||
464 | * @return Article |
||
465 | */ |
||
466 | 11 | public function setKeywords($keywords) |
|
472 | |||
473 | /** |
||
474 | * @return string |
||
475 | */ |
||
476 | public function getMetaTitle() |
||
480 | |||
481 | /** |
||
482 | * @param string $metaTitle |
||
483 | * |
||
484 | * @return Article |
||
485 | */ |
||
486 | 11 | public function setMetaTitle($metaTitle) |
|
492 | |||
493 | /** |
||
494 | * @return string |
||
495 | */ |
||
496 | public function getChanged() |
||
500 | |||
501 | /** |
||
502 | * @param string $changed |
||
503 | * |
||
504 | * @return Article |
||
505 | */ |
||
506 | public function setChanged($changed) |
||
512 | |||
513 | /** |
||
514 | * @return bool |
||
515 | */ |
||
516 | public function isPriceGroupActive() |
||
520 | |||
521 | /** |
||
522 | * @param bool $priceGroupActive |
||
523 | * |
||
524 | * @return Article |
||
525 | */ |
||
526 | 11 | public function setPriceGroupActive($priceGroupActive) |
|
532 | |||
533 | /** |
||
534 | * @return bool |
||
535 | */ |
||
536 | public function isLastStock() |
||
540 | |||
541 | /** |
||
542 | * @param bool $lastStock |
||
543 | * |
||
544 | * @return Article |
||
545 | */ |
||
546 | 11 | public function setLastStock($lastStock) |
|
552 | |||
553 | /** |
||
554 | * @return bool |
||
555 | */ |
||
556 | public function isCrossBundleLook() |
||
560 | |||
561 | /** |
||
562 | * @param bool $crossBundleLook |
||
563 | * |
||
564 | * @return Article |
||
565 | */ |
||
566 | 11 | public function setCrossBundleLook($crossBundleLook) |
|
572 | |||
573 | /** |
||
574 | * @return bool |
||
575 | */ |
||
576 | public function isNotification() |
||
580 | |||
581 | /** |
||
582 | * @param bool $notification |
||
583 | * |
||
584 | * @return Article |
||
585 | */ |
||
586 | 11 | public function setNotification($notification) |
|
592 | |||
593 | /** |
||
594 | * @return string |
||
595 | */ |
||
596 | public function getTemplate() |
||
600 | |||
601 | /** |
||
602 | * @param string $template |
||
603 | * |
||
604 | * @return Article |
||
605 | */ |
||
606 | 11 | public function setTemplate($template) |
|
612 | |||
613 | /** |
||
614 | * @return int |
||
615 | */ |
||
616 | public function getMode() |
||
620 | |||
621 | /** |
||
622 | * @param int $mode |
||
623 | * |
||
624 | * @return Article |
||
625 | */ |
||
626 | 11 | public function setMode($mode) |
|
632 | |||
633 | /** |
||
634 | * @return string |
||
635 | */ |
||
636 | public function getAvailableFrom() |
||
640 | |||
641 | /** |
||
642 | * @param string $availableFrom |
||
643 | * |
||
644 | * @return Article |
||
645 | */ |
||
646 | 11 | public function setAvailableFrom($availableFrom) |
|
652 | |||
653 | /** |
||
654 | * @return string |
||
655 | */ |
||
656 | public function getAvailableTo() |
||
660 | |||
661 | /** |
||
662 | * @param string $availableTo |
||
663 | * |
||
664 | * @return Article |
||
665 | */ |
||
666 | 11 | public function setAvailableTo($availableTo) |
|
672 | |||
673 | /** |
||
674 | * @return \Neta\Shopware\SDK\Entity\ArticleAttribute |
||
675 | */ |
||
676 | 1 | public function getAttribute(): ?ArticleAttribute |
|
680 | |||
681 | /** |
||
682 | * @param \Neta\Shopware\SDK\Entity\ArticleAttribute|array $value |
||
683 | * |
||
684 | * @return \Neta\Shopware\SDK\Entity\Article |
||
685 | */ |
||
686 | 11 | public function setAttribute($value) |
|
700 | |||
701 | /** |
||
702 | * @return mixed |
||
703 | */ |
||
704 | public function getCategories() |
||
708 | |||
709 | /** |
||
710 | * @param Category[] $categories |
||
711 | * |
||
712 | * @return Article |
||
713 | */ |
||
714 | public function setCategories($categories) |
||
720 | |||
721 | /** |
||
722 | * @return \Neta\Shopware\SDK\Entity\ArticleDetail |
||
723 | */ |
||
724 | 2 | public function getMainDetail(): ?ArticleDetail |
|
728 | |||
729 | /** |
||
730 | * @param \Neta\Shopware\SDK\Entity\ArticleDetail|array $value |
||
731 | * @return \Neta\Shopware\SDK\Entity\Article |
||
732 | */ |
||
733 | 3 | public function setMainDetail($value) |
|
747 | |||
748 | /** |
||
749 | * @return array |
||
750 | */ |
||
751 | 4 | public function getArrayCopy() |
|
761 | } |
||
762 |