UserGroupTest::testDeleteRecord() - Code Metrics - Inspection of "Refactor for Craft3" - nerds-and-company/schematic - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#114)

by Bart

created 2018-04-11 15:10 UTC

UserGroupTest::testDeleteRecord() A

↳ Parent: UserGroupTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1

<?php

namespace NerdsAndCompany\Schematic\Converters\Models;

use Craft;
use craft\console\Application;
use craft\models\UserGroup as UserGroupModel;
use craft\models\Section as SectionModel;
use craft\models\CategoryGroup as CategoryGroupModel;
use craft\base\Volume as VolumeModel;
use Codeception\Test\Unit;

/**
 * Class UserGroupTest.
 *
 * @author    Nerds & Company
 * @copyright Copyright (c) 2015-2017, Nerds & Company
 * @license   MIT
 *
 * @see      http://www.nerds.company
 */
class UserGroupTest extends Unit
{
    /**
     * @var UserGroups
     */
    private $converter;

    /**
     * Set the converter.
     *
     * @SuppressWarnings(PHPMD.CamelCaseMethodName)
     */
    protected function _before()
    {
        $this->converter = new UserGroup();

    }

    //==============================================================================================================
    //=================================================  TESTS  ====================================================
    //==============================================================================================================

    /**
     * @dataProvider provideUserGroups
     *
     * @param UserGroupModel $group
     * @param array          $definition
     * @param array          $groupPermissions
     * @param array          $allPermissions
     */
    public function testGetRecordDefinition(UserGroupModel $group, array $definition, array $groupPermissions, array $allPermissions)
    {
        Craft::$app->userPermissions->expects($this->exactly(1))
                                    ->method('getPermissionsByGroupId')
                                    ->with($group->id)
                                    ->willReturn($groupPermissions);

        Craft::$app->userPermissions->expects($this->exactly(1))
                                    ->method('getAllPermissions')
                                    ->willReturn($allPermissions);

        Craft::$app->sections->expects($this->exactly(1))
                             ->method('getSectionById')
                             ->with(1)
                             ->willReturn($this->getMockSection(1));

        Craft::$app->categories->expects($this->exactly(1))
                               ->method('getGroupById')
                               ->with(2)
                               ->willReturn($this->getMockCategoryGroup(2));

        Craft::$app->volumes->expects($this->exactly(1))
                            ->method('getVolumeById')
                            ->with(3)
                            ->willReturn($this->getmockVolume(3));

        $result = $this->converter->getRecordDefinition($group);

        $this->assertSame($definition, $result);
    }

    /**
     * @dataProvider provideUserGroups
     *
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     *
     * @param UserGroupModel $group
     * @param array          $definition
     * @param array          $groupPermissions
     * @param array          $allPermissions
     * @param bool           $valid
     */
    public function testSaveRecord(UserGroupModel $group, array $definition, array $groupPermissions, array $allPermissions, bool $valid)

    {
        Craft::$app->userGroups->expects($this->exactly(1))
                               ->method('saveGroup')
                               ->with($group)
                               ->willReturn($valid);

        $mappedPermissions = ['createEntries:1', 'editCategories:2', 'performUpdates', 'viewVolume:3'];

        if ($valid) {
            Craft::$app->userPermissions->expects($this->exactly(1))
                                        ->method('saveGroupPermissions')
                                        ->with($group->id, $mappedPermissions)
                                        ->willReturn(true);

            Craft::$app->sections->expects($this->exactly(1))
                                 ->method('getSectionByHandle')
                                 ->with('section1')
                                 ->willReturn($this->getMockSection(1));

            Craft::$app->categories->expects($this->exactly(1))
                                   ->method('getGroupByHandle')
                                   ->with('group2')
                                   ->willReturn($this->getMockCategoryGroup(2));

            Craft::$app->volumes->expects($this->exactly(1))
                                ->method('getVolumeByHandle')
                                ->with('volume3')
                                ->willReturn($this->getmockVolume(3));
        }

        $result = $this->converter->saveRecord($group, $definition);

        $this->assertSame($valid, $result);
    }

    /**
     * @dataProvider provideUserGroups
     *
     * @param UserGroupModel $group
     */
    public function testDeleteRecord(UserGroupModel $group)
    {
        Craft::$app->userGroups->expects($this->exactly(1))
                               ->method('deleteGroupById')
                               ->with($group->id);

        $this->converter->deleteRecord($group);
    }

    //==============================================================================================================
    //==============================================  PROVIDERS  ===================================================
    //==============================================================================================================

    /**
     * @return array
     */
    public function provideUserGroups()
    {
        $mockUserGroup = $this->getMockUserGroup(1);

        return [
            'valid user group' => [
                'group' => $mockUserGroup,
                'definition' => $this->getMockUserGroupDefinition($mockUserGroup),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'groupPermissions' => [
                    'createentries:1',
                    'editcategories:2',
                    'performupdates',
                    'viewvolume:3',
                ],
                'allPermissions' => [
                    ['createEntries:1' => []],
                    ['editCategories:2' => []],
                    ['performUpdates' => []],
                    ['viewVolume:3' => []],
                ],
                'validSave' => true,
            ],
            'invalid user group' => [
                'group' => $mockUserGroup,
                'definition' => $this->getMockUserGroupDefinition($mockUserGroup),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'groupPermissions' => [
                    'createentries:1',
                    'editcategories:2',
                    'performupdates',
                    'viewvolume:3',
                ],
                'allPermissions' => [
                    ['createEntries:1' => []],
                    ['editCategories:2' => []],
                    ['performUpdates' => []],
                    ['viewVolume:3' => []],
                ],
                'validSave' => false,
            ],
        ];
    }

    //==============================================================================================================
    //================================================  HELPERS  ===================================================
    //==============================================================================================================

    /**
     * @param UserGroupModel $userGroup
     *
     * @return array
     */
    private function getMockUserGroupDefinition(UserGroupModel $userGroup)
    {
        return [
          'class' => get_class($userGroup),
          'attributes' => [
              'name' => 'userGroupName'.$userGroup->id,
              'handle' => 'userGroupHandle'.$userGroup->id,
          ],
          'permissions' => [
              'createEntries:section1',
              'editCategories:group2',
              'performUpdates',
              'viewVolume:volume3',
          ],
        ];
    }

    /**
     * @param int $userGroupId
     *
     * @return UserGroupModel
     */
    private function getMockUserGroup(int $userGroupId)
    {
        $mockApp = $this->getMockBuilder(Application::class)
                        ->disableOriginalConstructor()
                        ->getMock();

        $mockApp->expects($this->exactly(1))
                ->method('requireEdition')
                ->with(Craft::Pro)
                ->willReturn(true);

        Craft::$app = $mockApp;


        $mockUserGroup = $this->getmockBuilder(UserGroupModel::class)
                              ->setMethods(['__toString'])
                              ->getMock();

        $mockUserGroup->id = $userGroupId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $mockUserGroup->handle = 'userGroupHandle'.$userGroupId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $mockUserGroup->name = 'userGroupName'.$userGroupId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $mockUserGroup;
    }

    /**
     * @param int $sectionId
     *
     * @return Mock|SectionModel
     */
    private function getMockSection(int $sectionId)
    {
        $mockSection = $this->getMockBuilder(SectionModel::class)
                           ->disableOriginalConstructor()
                           ->getMock();

        $mockSection->id = $sectionId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $mockSection->handle = 'section'.$sectionId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $mockSection;
    }

    /**
     * @param int $groupId
     *
     * @return Mock|CategoryGroupModel
     */
    private function getMockCategoryGroup(int $groupId)
    {
        $mockGroup = $this->getMockBuilder(CategoryGroupModel::class)
                          ->disableOriginalConstructor()
                          ->getMock();

        $mockGroup->id = $groupId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $mockGroup->handle = 'group'.$groupId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $mockGroup;
    }

    /**
     * @param int $volumeId
     *
     * @return Mock|VolumeModel
     */
    private function getMockVolume(int $volumeId)
    {
        $mockVolume = $this->getMockBuilder(VolumeModel::class)
                          ->disableOriginalConstructor()
                          ->getMock();

        $mockVolume->id = $volumeId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $mockVolume->handle = 'volume'.$volumeId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $mockVolume;
    }
}


Pull Request — master (#114)

UserGroupTest::testDeleteRecord() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace NerdsAndCompany\Schematic\Converters\Models;
4
5			use Craft;
6			use craft\console\Application;
7			use craft\models\UserGroup as UserGroupModel;
8			use craft\models\Section as SectionModel;
9			use craft\models\CategoryGroup as CategoryGroupModel;
10			use craft\base\Volume as VolumeModel;
11			use Codeception\Test\Unit;
12
13			/**
14			* Class UserGroupTest.
15			*
16			* @author Nerds & Company
17			* @copyright Copyright (c) 2015-2017, Nerds & Company
18			* @license MIT
19			*
20			* @see http://www.nerds.company
21			*/
22			class UserGroupTest extends Unit
23			{
24			/**
25			* @var UserGroups
26			*/
27			private $converter;
28
29			/**
30			* Set the converter.
31			*
32			* @SuppressWarnings(PHPMD.CamelCaseMethodName)
33			*/
34			protected function _before()
35			{
36			$this->converter = new UserGroup();
			0 ignored issues – show Documentation Bug introduced 2018-04-11 14:06 UTC by Report Bug Copy Issue Report It seems like `new \NerdsAndCompany\Sch...ters\Models\UserGroup()` of type `object<NerdsAndCompany\S...rters\Models\UserGroup>` is incompatible with the declared type `object<NerdsAndCompany\S...ters\Models\UserGroups>` of property `$converter`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
37			}
38
39			//==============================================================================================================
40			//================================================= TESTS ====================================================
41			//==============================================================================================================
42
43			/**
44			* @dataProvider provideUserGroups
45			*
46			* @param UserGroupModel $group
47			* @param array $definition
48			* @param array $groupPermissions
49			* @param array $allPermissions
50			*/
51			public function testGetRecordDefinition(UserGroupModel $group, array $definition, array $groupPermissions, array $allPermissions)
52			{
53			Craft::$app->userPermissions->expects($this->exactly(1))
54			->method('getPermissionsByGroupId')
55			->with($group->id)
56			->willReturn($groupPermissions);
57
58			Craft::$app->userPermissions->expects($this->exactly(1))
59			->method('getAllPermissions')
60			->willReturn($allPermissions);
61
62			Craft::$app->sections->expects($this->exactly(1))
63			->method('getSectionById')
64			->with(1)
65			->willReturn($this->getMockSection(1));
66
67			Craft::$app->categories->expects($this->exactly(1))
68			->method('getGroupById')
69			->with(2)
70			->willReturn($this->getMockCategoryGroup(2));
71
72			Craft::$app->volumes->expects($this->exactly(1))
73			->method('getVolumeById')
74			->with(3)
75			->willReturn($this->getmockVolume(3));
76
77			$result = $this->converter->getRecordDefinition($group);
78
79			$this->assertSame($definition, $result);
80			}
81
82			/**
83			* @dataProvider provideUserGroups
84			*
85			* @SuppressWarnings(PHPMD.UnusedFormalParameter)
86			*
87			* @param UserGroupModel $group
88			* @param array $definition
89			* @param array $groupPermissions
90			* @param array $allPermissions
91			* @param bool $valid
92			*/
93			public function testSaveRecord(UserGroupModel $group, array $definition, array $groupPermissions, array $allPermissions, bool $valid)
			0 ignored issues – show Unused Code introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report The parameter `$groupPermissions` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report The parameter `$allPermissions` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
94			{
95			Craft::$app->userGroups->expects($this->exactly(1))
96			->method('saveGroup')
97			->with($group)
98			->willReturn($valid);
99
100			$mappedPermissions = ['createEntries:1', 'editCategories:2', 'performUpdates', 'viewVolume:3'];
101
102			if ($valid) {
103			Craft::$app->userPermissions->expects($this->exactly(1))
104			->method('saveGroupPermissions')
105			->with($group->id, $mappedPermissions)
106			->willReturn(true);
107
108			Craft::$app->sections->expects($this->exactly(1))
109			->method('getSectionByHandle')
110			->with('section1')
111			->willReturn($this->getMockSection(1));
112
113			Craft::$app->categories->expects($this->exactly(1))
114			->method('getGroupByHandle')
115			->with('group2')
116			->willReturn($this->getMockCategoryGroup(2));
117
118			Craft::$app->volumes->expects($this->exactly(1))
119			->method('getVolumeByHandle')
120			->with('volume3')
121			->willReturn($this->getmockVolume(3));
122			}
123
124			$result = $this->converter->saveRecord($group, $definition);
125
126			$this->assertSame($valid, $result);
127			}
128
129			/**
130			* @dataProvider provideUserGroups
131			*
132			* @param UserGroupModel $group
133			*/
134			public function testDeleteRecord(UserGroupModel $group)
135			{
136			Craft::$app->userGroups->expects($this->exactly(1))
137			->method('deleteGroupById')
138			->with($group->id);
139
140			$this->converter->deleteRecord($group);
141			}
142
143			//==============================================================================================================
144			//============================================== PROVIDERS ===================================================
145			//==============================================================================================================
146
147			/**
148			* @return array
149			*/
150			public function provideUserGroups()
151			{
152			$mockUserGroup = $this->getMockUserGroup(1);
153
154			return [
155			'valid user group' => [
156			'group' => $mockUserGroup,
157			'definition' => $this->getMockUserGroupDefinition($mockUserGroup),
			0 ignored issues – show Documentation introduced 2018-04-11 14:06 UTC by Report Bug Copy Issue Report `$mockUserGroup` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<craft\models\UserGroup>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
158			'groupPermissions' => [
159			'createentries:1',
160			'editcategories:2',
161			'performupdates',
162			'viewvolume:3',
163			],
164			'allPermissions' => [
165			['createEntries:1' => []],
166			['editCategories:2' => []],
167			['performUpdates' => []],
168			['viewVolume:3' => []],
169			],
170			'validSave' => true,
171			],
172			'invalid user group' => [
173			'group' => $mockUserGroup,
174			'definition' => $this->getMockUserGroupDefinition($mockUserGroup),
			0 ignored issues – show Documentation introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report `$mockUserGroup` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<craft\models\UserGroup>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
175			'groupPermissions' => [
176			'createentries:1',
177			'editcategories:2',
178			'performupdates',
179			'viewvolume:3',
180			],
181			'allPermissions' => [
182			['createEntries:1' => []],
183			['editCategories:2' => []],
184			['performUpdates' => []],
185			['viewVolume:3' => []],
186			],
187			'validSave' => false,
188			],
189			];
190			}
191
192			//==============================================================================================================
193			//================================================ HELPERS ===================================================
194			//==============================================================================================================
195
196			/**
197			* @param UserGroupModel $userGroup
198			*
199			* @return array
200			*/
201			private function getMockUserGroupDefinition(UserGroupModel $userGroup)
202			{
203			return [
204			'class' => get_class($userGroup),
205			'attributes' => [
206			'name' => 'userGroupName'.$userGroup->id,
207			'handle' => 'userGroupHandle'.$userGroup->id,
208			],
209			'permissions' => [
210			'createEntries:section1',
211			'editCategories:group2',
212			'performUpdates',
213			'viewVolume:volume3',
214			],
215			];
216			}
217
218			/**
219			* @param int $userGroupId
220			*
221			* @return UserGroupModel
222			*/
223			private function getMockUserGroup(int $userGroupId)
224			{
225			$mockApp = $this->getMockBuilder(Application::class)
226			->disableOriginalConstructor()
227			->getMock();
228
229			$mockApp->expects($this->exactly(1))
230			->method('requireEdition')
231			->with(Craft::Pro)
232			->willReturn(true);
233
234			Craft::$app = $mockApp;
			0 ignored issues – show Documentation Bug introduced 2018-04-11 14:06 UTC by Report Bug Copy Issue Report It seems like `$mockApp` of type `object<PHPUnit\Framework\MockObject\MockObject>` is incompatible with the declared type `object<craft\web\Applica...ft\console\Application>` of property `$app`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
235
236			$mockUserGroup = $this->getmockBuilder(UserGroupModel::class)
237			->setMethods(['__toString'])
238			->getMock();
239
240			$mockUserGroup->id = $userGroupId;
			0 ignored issues – show Bug introduced 2018-04-11 14:06 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
241			$mockUserGroup->handle = 'userGroupHandle'.$userGroupId;
			0 ignored issues – show Bug introduced 2018-04-11 14:06 UTC by Report Bug Copy Issue Report Accessing `handle` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
242			$mockUserGroup->name = 'userGroupName'.$userGroupId;
			0 ignored issues – show Bug introduced 2018-04-11 14:06 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
243
244			return $mockUserGroup;
245			}
246
247			/**
248			* @param int $sectionId
249			*
250			* @return Mock\|SectionModel
251			*/
252			private function getMockSection(int $sectionId)
253			{
254			$mockSection = $this->getMockBuilder(SectionModel::class)
255			->disableOriginalConstructor()
256			->getMock();
257
258			$mockSection->id = $sectionId;
			0 ignored issues – show Bug introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
259			$mockSection->handle = 'section'.$sectionId;
			0 ignored issues – show Bug introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report Accessing `handle` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
260
261			return $mockSection;
262			}
263
264			/**
265			* @param int $groupId
266			*
267			* @return Mock\|CategoryGroupModel
268			*/
269			private function getMockCategoryGroup(int $groupId)
270			{
271			$mockGroup = $this->getMockBuilder(CategoryGroupModel::class)
272			->disableOriginalConstructor()
273			->getMock();
274
275			$mockGroup->id = $groupId;
			0 ignored issues – show Bug introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
276			$mockGroup->handle = 'group'.$groupId;
			0 ignored issues – show Bug introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report Accessing `handle` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
277
278			return $mockGroup;
279			}
280
281			/**
282			* @param int $volumeId
283			*
284			* @return Mock\|VolumeModel
285			*/
286			private function getMockVolume(int $volumeId)
287			{
288			$mockVolume = $this->getMockBuilder(VolumeModel::class)
289			->disableOriginalConstructor()
290			->getMock();
291
292			$mockVolume->id = $volumeId;
			0 ignored issues – show Bug introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
293			$mockVolume->handle = 'volume'.$volumeId;
			0 ignored issues – show Bug introduced 2018-04-11 15:12 UTC by Report Bug Copy Issue Report Accessing `handle` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
294
295			return $mockVolume;
296			}
297			}
298

nerds-and-company / schematic

Pull Request — master (#114)

UserGroupTest::testDeleteRecord() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like