Users::behaviors() - Code Metrics - Inspection of "Refactor for Craft3" - nerds-and-company/schematic - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#114)

by Bart

created 2018-04-05 15:57 UTC

Users::behaviors() A

↳ Parent: Users

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
ccs	2
cts	2
cp	1
cc	1
eloc	3
nc	1
nop	0
crap	1

<?php

namespace NerdsAndCompany\Schematic\Services;

use Craft;
use craft\elements\User;
use yii\base\Component as BaseComponent;
use NerdsAndCompany\Schematic\Behaviors\FieldLayoutBehavior;
use NerdsAndCompany\Schematic\Interfaces\MappingInterface;
use NerdsAndCompany\Schematic\Schematic;

/**
 * Schematic Users Service.
 *
 * Sync Craft Setups.
 *
 * @author    Nerds & Company
 * @copyright Copyright (c) 2015-2018, Nerds & Company
 * @license   MIT
 *
 * @see      http://www.nerds.company
 */
class Users extends BaseComponent implements MappingInterface
{
    /**
     * Load fieldlayout behavior
     *
     * @return array
     */
    public function behaviors()
    {
        return [
          FieldLayoutBehavior::className(),

        ];
    }

    /**
     * Export user settings
     *
     * @return array
     */
    public function export()
    {
        $settings = Craft::$app->systemSettings->getSettings('users');
        $photoVolumeId = (int)$settings['photoVolumeId'];
        $volume = Craft::$app->volumes->getVolumeById($photoVolumeId);
        unset($settings['photoVolumeId']);

        $fieldLayout = Craft::$app->getFields()->getLayoutByType(User::class);
        return [
            'settings' => $settings,
            'photoVolume' => $volume ? $volume->handle : null,
            'fieldLayout' => $this->getFieldLayoutDefinition($fieldLayout),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        ];
    }

    /**
     * Import user settings.
     *
     * @param array $userSettings
     */
    public function import(array $userSettings)
    {
        $photoVolumeId = null;
        if (array_key_exists('photoVolume', $userSettings) && $userSettings['photoVolume'] != null) {
            $volume = Craft::$app->volumes->getVolumeByHandle($userSettings['photoVolume']);
            $photoVolumeId = $volume ? $volume->id : null;
        }
        if (array_key_exists('settings', $userSettings)) {
            Schematic::info('- Saving user settings');
            $userSettings['photoVolumeId'] = $photoVolumeId;
            if (!Craft::$app->systemSettings->saveSettings('users', $userSettings['settings'])) {
                Schematic::warning('- Couldn’t save user settings.');
            }
        }

        if (array_key_exists('fieldLayout', $userSettings)) {
            Schematic::info('- Saving user field layout');
            $fieldLayout = $this->getFieldLayout($userSettings['fieldLayout']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $fieldLayout->type = User::class;

            Craft::$app->fields->deleteLayoutsByType(User::class);
            if (!Craft::$app->fields->saveLayout($fieldLayout)) {
                Schematic::warning('- Couldn’t save user field layout.');
            }
        }
    }
}


1		<?php
2
3		namespace NerdsAndCompany\Schematic\Services;
4
5		use Craft;
6		use craft\elements\User;
7		use yii\base\Component as BaseComponent;
8		use NerdsAndCompany\Schematic\Behaviors\FieldLayoutBehavior;
9		use NerdsAndCompany\Schematic\Interfaces\MappingInterface;
10		use NerdsAndCompany\Schematic\Schematic;
11
12		/**
13		* Schematic Users Service.
14		*
15		* Sync Craft Setups.
16		*
17		* @author Nerds & Company
18		* @copyright Copyright (c) 2015-2018, Nerds & Company
19		* @license MIT
20		*
21		* @see http://www.nerds.company
22		*/
23		class Users extends BaseComponent implements MappingInterface
24		{
25		/**
26		* Load fieldlayout behavior
27		*
28		* @return array
29	1	*/
30		public function behaviors()
31	1	{
32		return [
33	1	FieldLayoutBehavior::className(),
		0 ignored issues – show Deprecated Code introduced 2018-04-03 09:26 UTC by Report Bug Copy Issue Report The method `yii\base\BaseObject::className()` has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
34		];
35		}
36
37		/**
38		* Export user settings
39		*
40		* @return array
41		*/
42		public function export()
43	1	{
44		$settings = Craft::$app->systemSettings->getSettings('users');
45		$photoVolumeId = (int)$settings['photoVolumeId'];
46	1	$volume = Craft::$app->volumes->getVolumeById($photoVolumeId);
47	1	unset($settings['photoVolumeId']);
48
49		$fieldLayout = Craft::$app->getFields()->getLayoutByType(User::class);
50		return [
51		'settings' => $settings,
52		'photoVolume' => $volume ? $volume->handle : null,
53		'fieldLayout' => $this->getFieldLayoutDefinition($fieldLayout),
		0 ignored issues – show Documentation Bug introduced 2018-04-03 09:26 UTC by Report Bug Copy Issue Report The method `getFieldLayoutDefinition` does not exist on `object<NerdsAndCompany\Schematic\Services\Users>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
54		];
55		}
56
57		/**
58	3	* Import user settings.
59		*
60	3	* @param array $userSettings
61		*/
62		public function import(array $userSettings)
63	3	{
64		$photoVolumeId = null;
65	3	if (array_key_exists('photoVolume', $userSettings) && $userSettings['photoVolume'] != null) {
66	1	$volume = Craft::$app->volumes->getVolumeByHandle($userSettings['photoVolume']);
67	1	$photoVolumeId = $volume ? $volume->id : null;
68	2	}
69		if (array_key_exists('settings', $userSettings)) {
70		Schematic::info('- Saving user settings');
71	3	$userSettings['photoVolumeId'] = $photoVolumeId;
72	3	if (!Craft::$app->systemSettings->saveSettings('users', $userSettings['settings'])) {
73		Schematic::warning('- Couldn’t save user settings.');
74	3	}
75		}
76	1
77	1	if (array_key_exists('fieldLayout', $userSettings)) {
78		Schematic::info('- Saving user field layout');
79	3	$fieldLayout = $this->getFieldLayout($userSettings['fieldLayout']);
		0 ignored issues – show Documentation Bug introduced 2018-04-04 15:38 UTC by Report Bug Copy Issue Report The method `getFieldLayout` does not exist on `object<NerdsAndCompany\Schematic\Services\Users>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
80		$fieldLayout->type = User::class;
81
82		Craft::$app->fields->deleteLayoutsByType(User::class);
83		if (!Craft::$app->fields->saveLayout($fieldLayout)) {
84		Schematic::warning('- Couldn’t save user field layout.');
85		}
86		}
87		}
88		}
89

nerds-and-company / schematic

Pull Request — master (#114)

Users::behaviors() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like