UserSettingsMapper::import() - Code Metrics - Inspection of "Refactor for Craft3" - nerds-and-company/schematic - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#114)

by Bart

created 2018-04-13 13:45 UTC

UserSettingsMapper::import() C

↳ Parent: UserSettingsMapper

Complexity

Conditions	8
Paths	27

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
rs	5.3846
c	0
b	0
f	0
cc	8
eloc	20
nc	27
nop	2

<?php

namespace NerdsAndCompany\Schematic\Mappers;

use Craft;
use craft\elements\User;
use NerdsAndCompany\Schematic\Behaviors\FieldLayoutBehavior;
use NerdsAndCompany\Schematic\Schematic;
use NerdsAndCompany\Schematic\Interfaces\MapperInterface;
use yii\base\Component as BaseComponent;

/**
 * Schematic User Mapper.
 *
 * Sync Craft Setups.
 *
 * @author    Nerds & Company
 * @copyright Copyright (c) 2015-2018, Nerds & Company
 * @license   MIT
 *
 * @see      http://www.nerds.company
 */
class UserSettingsMapper extends BaseComponent implements MapperInterface
{
    /**
     * Load fieldlayout behavior.
     *
     * @return array
     */
    public function behaviors(): array
    {
        return [
          FieldLayoutBehavior::className(),

        ];
    }

    /**
     * {@inheritdoc}
     */
    public function export(array $settings = []): array
    {
        $settings = Craft::$app->systemSettings->getSettings('users');
        $photoVolumeId = (int) $settings['photoVolumeId'];
        $volume = Craft::$app->volumes->getVolumeById($photoVolumeId);
        unset($settings['photoVolumeId']);
        $settings['photoVolume'] = $volume ? $volume->handle : null;

        $fieldLayout = Craft::$app->fields->getLayoutByType(User::class);

        return [
            'settings' => $settings,
            'fieldLayout' => $this->getFieldLayoutDefinition($fieldLayout),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        ];
    }

    /**
     * {@inheritdoc}
     */
    public function import(array $userSettings, array $settings = []): array
    {
        $photoVolumeId = null;
        if (array_key_exists('photoVolume', $userSettings['settings']) && null != $userSettings['settings']['photoVolume']) {
            $volume = Craft::$app->volumes->getVolumeByHandle($userSettings['settings']['photoVolume']);
            $photoVolumeId = $volume ? $volume->id : null;
        }
        unset($userSettings['settings']['photoVolume']);

        if (array_key_exists('settings', $userSettings)) {
            Schematic::info('- Saving user settings');
            $userSettings['settings']['photoVolumeId'] = $photoVolumeId;
            if (!Craft::$app->systemSettings->saveSettings('users', $userSettings['settings'])) {
                Schematic::warning('- Couldn’t save user settings.');
            }
        }

        if (array_key_exists('fieldLayout', $userSettings)) {
            Schematic::info('- Saving user field layout');
            $fieldLayout = $this->getFieldLayout($userSettings['fieldLayout']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $fieldLayout->type = User::class;

            Craft::$app->fields->deleteLayoutsByType(User::class);
            if (!Craft::$app->fields->saveLayout($fieldLayout)) {
                Schematic::warning('- Couldn’t save user field layout.');

                Schematic::importError($fieldLayout, 'users');
            }
        }

        return [];
    }
}


1			<?php
2
3			namespace NerdsAndCompany\Schematic\Mappers;
4
5			use Craft;
6			use craft\elements\User;
7			use NerdsAndCompany\Schematic\Behaviors\FieldLayoutBehavior;
8			use NerdsAndCompany\Schematic\Schematic;
9			use NerdsAndCompany\Schematic\Interfaces\MapperInterface;
10			use yii\base\Component as BaseComponent;
11
12			/**
13			* Schematic User Mapper.
14			*
15			* Sync Craft Setups.
16			*
17			* @author Nerds & Company
18			* @copyright Copyright (c) 2015-2018, Nerds & Company
19			* @license MIT
20			*
21			* @see http://www.nerds.company
22			*/
23			class UserSettingsMapper extends BaseComponent implements MapperInterface
24			{
25			/**
26			* Load fieldlayout behavior.
27			*
28			* @return array
29			*/
30			public function behaviors(): array
31			{
32			return [
33			FieldLayoutBehavior::className(),
			0 ignored issues – show Deprecated Code introduced 2018-04-10 10:04 UTC by Report Bug Copy Issue Report The method `yii\base\BaseObject::className()` has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
34			];
35			}
36
37			/**
38			* {@inheritdoc}
39			*/
40			public function export(array $settings = []): array
41			{
42			$settings = Craft::$app->systemSettings->getSettings('users');
43			$photoVolumeId = (int) $settings['photoVolumeId'];
44			$volume = Craft::$app->volumes->getVolumeById($photoVolumeId);
45			unset($settings['photoVolumeId']);
46			$settings['photoVolume'] = $volume ? $volume->handle : null;
47
48			$fieldLayout = Craft::$app->fields->getLayoutByType(User::class);
49
50			return [
51			'settings' => $settings,
52			'fieldLayout' => $this->getFieldLayoutDefinition($fieldLayout),
			0 ignored issues – show Documentation Bug introduced 2018-04-11 21:50 UTC by Report Bug Copy Issue Report The method `getFieldLayoutDefinition` does not exist on `object<NerdsAndCompany\S...ers\UserSettingsMapper>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
53			];
54			}
55
56			/**
57			* {@inheritdoc}
58			*/
59			public function import(array $userSettings, array $settings = []): array
60			{
61			$photoVolumeId = null;
62			if (array_key_exists('photoVolume', $userSettings['settings']) && null != $userSettings['settings']['photoVolume']) {
63			$volume = Craft::$app->volumes->getVolumeByHandle($userSettings['settings']['photoVolume']);
64			$photoVolumeId = $volume ? $volume->id : null;
65			}
66			unset($userSettings['settings']['photoVolume']);
67
68			if (array_key_exists('settings', $userSettings)) {
69			Schematic::info('- Saving user settings');
70			$userSettings['settings']['photoVolumeId'] = $photoVolumeId;
71			if (!Craft::$app->systemSettings->saveSettings('users', $userSettings['settings'])) {
72			Schematic::warning('- Couldn’t save user settings.');
73			}
74			}
75
76			if (array_key_exists('fieldLayout', $userSettings)) {
77			Schematic::info('- Saving user field layout');
78			$fieldLayout = $this->getFieldLayout($userSettings['fieldLayout']);
			0 ignored issues – show Documentation Bug introduced 2018-04-11 21:50 UTC by Report Bug Copy Issue Report The method `getFieldLayout` does not exist on `object<NerdsAndCompany\S...ers\UserSettingsMapper>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
79			$fieldLayout->type = User::class;
80
81			Craft::$app->fields->deleteLayoutsByType(User::class);
82			if (!Craft::$app->fields->saveLayout($fieldLayout)) {
83			Schematic::warning('- Couldn’t save user field layout.');
84
85			Schematic::importError($fieldLayout, 'users');
86			}
87			}
88
89			return [];
90			}
91			}
92

nerds-and-company / schematic

Pull Request — master (#114)

UserSettingsMapper::import() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like