Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
20 | class CategoryGroups extends Base |
||
21 | { |
||
22 | /** |
||
23 | * Export categoryGroups. |
||
24 | * |
||
25 | * @param CategoryGroupModel[] $categoryGroups |
||
26 | * |
||
27 | * @return array |
||
28 | */ |
||
29 | 3 | public function export(array $categoryGroups = []) |
|
41 | |||
42 | /** |
||
43 | * Get category groups definition. |
||
44 | * |
||
45 | * @param CategoryGroupModel $categoryGroup |
||
46 | * |
||
47 | * @return array |
||
48 | */ |
||
49 | 4 | private function getCategoryGroupDefinition(CategoryGroupModel $categoryGroup) |
|
61 | |||
62 | /** |
||
63 | * Get locale definitions. |
||
64 | * |
||
65 | * @param CategoryGroupLocaleModel[] $locales |
||
66 | * |
||
67 | * @return array |
||
68 | */ |
||
69 | 2 | View Code Duplication | private function getLocaleDefinitions(array $locales) |
79 | |||
80 | /** |
||
81 | * Get locale definition. |
||
82 | * |
||
83 | * @param CategoryGroupLocaleModel $locale |
||
84 | * |
||
85 | * @return array |
||
86 | */ |
||
87 | 2 | private function getLocaleDefinition(CategoryGroupLocaleModel $locale) |
|
94 | |||
95 | /** |
||
96 | * Attempt to import category groups. |
||
97 | * |
||
98 | * @param array $categoryGroupDefinitions |
||
99 | * @param bool $force If set to true category groups not included in the import will be deleted |
||
100 | * |
||
101 | * @return Result |
||
102 | */ |
||
103 | 4 | View Code Duplication | public function import(array $categoryGroupDefinitions, $force = false) |
104 | { |
||
105 | 4 | Craft::log(Craft::t('Importing Category Groups')); |
|
106 | |||
107 | 4 | $categoryGroups = Craft::app()->categories->getAllGroups('handle'); |
|
108 | |||
109 | 4 | foreach ($categoryGroupDefinitions as $categoryGroupHandle => $categoryGroupDefinition) { |
|
110 | 2 | $categoryGroup = array_key_exists($categoryGroupHandle, $categoryGroups) |
|
111 | 2 | ? $categoryGroups[$categoryGroupHandle] |
|
112 | 2 | : new CategoryGroupModel(); |
|
113 | |||
114 | 2 | unset($categoryGroups[$categoryGroupHandle]); |
|
115 | |||
116 | 2 | $this->populateCategoryGroup($categoryGroup, $categoryGroupDefinition, $categoryGroupHandle); |
|
117 | |||
118 | 2 | if (!Craft::app()->categories->saveGroup($categoryGroup)) { // Save categorygroup via craft |
|
119 | 2 | $this->addErrors($categoryGroup->getAllErrors()); |
|
120 | |||
121 | 2 | continue; |
|
122 | } |
||
123 | 4 | } |
|
124 | |||
125 | 4 | if ($force) { |
|
126 | 2 | foreach ($categoryGroups as $categoryGroup) { |
|
127 | Craft::app()->categories->deleteGroupById($categoryGroup->id); |
||
128 | 2 | } |
|
129 | 2 | } |
|
130 | |||
131 | 4 | return $this->getResultModel(); |
|
132 | } |
||
133 | |||
134 | /** |
||
135 | * Populate categorygroup. |
||
136 | * |
||
137 | * @param CategoryGroupModel $categoryGroup |
||
138 | * @param array $categoryGroupDefinition |
||
139 | * @param string $categoryGroupHandle |
||
140 | */ |
||
141 | 2 | View Code Duplication | private function populateCategoryGroup(CategoryGroupModel $categoryGroup, array $categoryGroupDefinition, $categoryGroupHandle) |
156 | |||
157 | /** |
||
158 | * Populate section locales. |
||
159 | * |
||
160 | * @param CategoryGroupModel $categoryGroup |
||
161 | * @param $localeDefinitions |
||
162 | */ |
||
163 | 2 | View Code Duplication | private function populateCategoryGroupLocales(CategoryGroupModel $categoryGroup, $localeDefinitions) |
187 | } |
||
188 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.