Issues in ImportController.php - Fixed Issues - Inspection of "Merge pull request #116 from nerds-and-company/tra..." - nerds-and-company/schematic - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 33ec04...ed9cfc )

by Bart

created 2018-04-18 09:40 UTC

src/Controllers/ImportController.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace NerdsAndCompany\Schematic\Controllers;

use Craft;
use NerdsAndCompany\Schematic\Models\Data;
use NerdsAndCompany\Schematic\Schematic;
use craft\errors\WrongEditionException;

/**
 * Schematic Import Command.
 *
 * Sync Craft Setups.
 *
 * @author    Nerds & Company
 * @copyright Copyright (c) 2015-2018, Nerds & Company
 * @license   MIT
 *
 * @see      http://www.nerds.company
 */
class ImportController extends Base
{
    public $force = false;

    /**
     * {@inheritdoc}
     *
     * @return array
     */
    public function options($actionID): array
    {
        return array_merge(parent::options($actionID), ['force']);
    }

    /**
     * Imports the Craft datamodel.
     *
     * @return int
     */
    public function actionIndex(): int
    {
        if (!file_exists($this->file)) {
            Schematic::error('File not found: '.$this->file);

            return 1;
        }

        $dataTypes = $this->getDataTypes();
        $this->importFromYaml($dataTypes);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        Schematic::info('Loaded schema from '.$this->file);

        return 0;
    }

    /**
     * Import from Yaml file.
     *
     * @param string $dataTypes The data types to import
     *
     * @throws Exception
     */
    private function importFromYaml($dataTypes): void
    {
        $this->disableLogging();
        $yaml = file_get_contents($this->file);
        $yamlOverride = null;
        if (file_exists($this->overrideFile)) {
            $yamlOverride = file_get_contents($this->overrideFile);
        }
        $definitions = Data::fromYaml($yaml, $yamlOverride);

        foreach ($dataTypes as $dataTypeHandle) {

            $dataType = $this->module->getDataType($dataTypeHandle);
            if (null == $dataType) {
                continue;
            }

            $mapper = $dataType->getMapperHandle();
            if (!$this->module->checkMapper($mapper)) {
                continue;
            }

            Schematic::info('Importing '.$dataTypeHandle);
            Schematic::$force = $this->force;
            if (array_key_exists($dataTypeHandle, $definitions) && is_array($definitions[$dataTypeHandle])) {
                $records = $dataType->getRecords();
                try {
                    $this->module->$mapper->import($definitions[$dataTypeHandle], $records);

                    // @TODO: Don't hardcode datatype in controller
                    if ('fields' == $dataTypeHandle) {
                        Craft::$app->fields->updateFieldVersion();
                    }
                } catch (WrongEditionException $e) {
                    Schematic::error('Craft Pro is required for datatype '.$dataTypeHandle);
                }
            }
        }
    }
}


1			<?php
2
3			namespace NerdsAndCompany\Schematic\Controllers;
4
5			use Craft;
6			use NerdsAndCompany\Schematic\Models\Data;
7			use NerdsAndCompany\Schematic\Schematic;
8			use craft\errors\WrongEditionException;
9
10			/**
11			* Schematic Import Command.
12			*
13			* Sync Craft Setups.
14			*
15			* @author Nerds & Company
16			* @copyright Copyright (c) 2015-2018, Nerds & Company
17			* @license MIT
18			*
19			* @see http://www.nerds.company
20			*/
21			class ImportController extends Base
22			{
23			public $force = false;
24
25			/**
26			* {@inheritdoc}
27			*
28			* @return array
29			*/
30			public function options($actionID): array
31			{
32			return array_merge(parent::options($actionID), ['force']);
33			}
34
35			/**
36			* Imports the Craft datamodel.
37			*
38			* @return int
39			*/
40			public function actionIndex(): int
41			{
42			if (!file_exists($this->file)) {
43			Schematic::error('File not found: '.$this->file);
44
45			return 1;
46			}
47
48			$dataTypes = $this->getDataTypes();
49			$this->importFromYaml($dataTypes);
			0 ignored issues – show Documentation introduced 2018-04-03 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$dataTypes` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50			Schematic::info('Loaded schema from '.$this->file);
51
52			return 0;
53			}
54
55			/**
56			* Import from Yaml file.
57			*
58			* @param string $dataTypes The data types to import
59			*
60			* @throws Exception
61			*/
62			private function importFromYaml($dataTypes): void
63			{
64			$this->disableLogging();
65			$yaml = file_get_contents($this->file);
66			$yamlOverride = null;
67			if (file_exists($this->overrideFile)) {
68			$yamlOverride = file_get_contents($this->overrideFile);
69			}
70			$definitions = Data::fromYaml($yaml, $yamlOverride);
71
72			foreach ($dataTypes as $dataTypeHandle) {
			0 ignored issues – show Bug introduced 2018-04-12 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dataTypes` of type `string` is not traversable. Loading history...
73			$dataType = $this->module->getDataType($dataTypeHandle);
74			if (null == $dataType) {
75			continue;
76			}
77
78			$mapper = $dataType->getMapperHandle();
79			if (!$this->module->checkMapper($mapper)) {
80			continue;
81			}
82
83			Schematic::info('Importing '.$dataTypeHandle);
84			Schematic::$force = $this->force;
85			if (array_key_exists($dataTypeHandle, $definitions) && is_array($definitions[$dataTypeHandle])) {
86			$records = $dataType->getRecords();
87			try {
88			$this->module->$mapper->import($definitions[$dataTypeHandle], $records);
89
90			// @TODO: Don't hardcode datatype in controller
91			if ('fields' == $dataTypeHandle) {
92			Craft::$app->fields->updateFieldVersion();
93			}
94			} catch (WrongEditionException $e) {
95			Schematic::error('Craft Pro is required for datatype '.$dataTypeHandle);
96			}
97			}
98			}
99			}
100			}
101

nerds-and-company / schematic

Push — master ( 33ec04...ed9cfc )

src/Controllers/ImportController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like