AsyncioEventLoop._connect_child() - Code Metrics - Inspection of "WIP: reimplement stdio on windows" - neovim/python-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#307)

by Björn

created 2018-03-15 15:08 UTC

AsyncioEventLoop._connect_child() A

↳ Parent: AsyncioEventLoop

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
dl	0
loc	5
ccs	0
cts	0
cp	0
crap	2
rs	9.4285

"""Event loop implementation that uses the `asyncio` standard module.

The `asyncio` module was added to python standard library on 3.4, and it
provides a pure python implementation of an event loop library. It is used
as a fallback in case pyuv is not available(on python implementations other
than CPython).

Earlier python versions are supported through the `trollius` package, which
is a backport of `asyncio` that works on Python 2.6+.
"""
from __future__ import absolute_import

import logging
import os
import sys
from collections import deque
import threading

try:
    # For python 3.4+, use the standard library module
    import asyncio
except (ImportError, SyntaxError):
    # Fallback to trollius
    import trollius as asyncio
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from .base import BaseEventLoop

logger = logging.getLogger(__name__)
debug, info, warn = (logger.debug, logger.info, logger.warning,)

loop_cls = asyncio.SelectorEventLoop
if os.name == 'nt':
    # On windows use ProactorEventLoop which support pipes and is backed by the
    # more powerful IOCP facility
    # NOTE: we override in the stdio case, because it doesn't work.
    loop_cls = asyncio.ProactorEventLoop

    import msvcrt
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
    from ctypes import windll, byref, wintypes, GetLastError, WinError, POINTER

    from ctypes.wintypes import HANDLE, DWORD, BOOL

    LPDWORD = POINTER(DWORD)

    PIPE_NOWAIT = wintypes.DWORD(0x00000001)

    ERROR_NO_DATA = 232

    def pipe_no_wait(pipefd):
        SetNamedPipeHandleState = windll.kernel32.SetNamedPipeHandleState
        SetNamedPipeHandleState.argtypes = [HANDLE, LPDWORD, LPDWORD, LPDWORD]
        SetNamedPipeHandleState.restype = BOOL

        h = msvcrt.get_osfhandle(pipefd)

        res = windll.kernel32.SetNamedPipeHandleState(h, byref(PIPE_NOWAIT), None, None)
        if res == 0:
            print(WinError())
            return False
        return True

class AsyncioEventLoop(BaseEventLoop, asyncio.Protocol,
                       asyncio.SubprocessProtocol):

    """`BaseEventLoop` subclass that uses `asyncio` as a backend."""

    def connection_made(self, transport):
        """Used to signal `asyncio.Protocol` of a successful connection."""
        self._transport = transport
class Foo:
    def __init__(self, x=None):
        self.x = x
        self._raw_transport = transport
class Foo:
    def __init__(self, x=None):
        self.x = x
        if isinstance(transport, asyncio.SubprocessTransport):
            self._transport = transport.get_pipe_transport(0)
class Foo:
    def __init__(self, x=None):
        self.x = x

    def connection_lost(self, exc):
        """Used to signal `asyncio.Protocol` of a lost connection."""
        self._on_error(exc.args[0] if exc else 'EOF')

    def data_received(self, data):
        """Used to signal `asyncio.Protocol` of incoming data."""
        if self._on_data:
            self._on_data(data)
            return
        self._queued_data.append(data)

    def pipe_connection_lost(self, fd, exc):
        """Used to signal `asyncio.SubprocessProtocol` of a lost connection."""
        self._on_error(exc.args[0] if exc else 'EOF')

    def pipe_data_received(self, fd, data):
        """Used to signal `asyncio.SubprocessProtocol` of incoming data."""
        if fd == 2:  # stderr fd number
            self._on_stderr(data)

        elif self._on_data:
            self._on_data(data)
        else:
            self._queued_data.append(data)

    def process_exited(self):
        """Used to signal `asyncio.SubprocessProtocol` when the child exits."""
        self._on_error('EOF')

    def _init(self):
        self._loop = loop_cls()
class Foo:
    def __init__(self, x=None):
        self.x = x
        self._queued_data = deque()
class Foo:
    def __init__(self, x=None):
        self.x = x
        self._fact = lambda: self
class Foo:
    def __init__(self, x=None):
        self.x = x
        self._raw_transport = None
class Foo:
    def __init__(self, x=None):
        self.x = x
        self._raw_stdout = False
class Foo:
    def __init__(self, x=None):
        self.x = x
        self._active = False
class Foo:
    def __init__(self, x=None):
        self.x = x

    def _connect_tcp(self, address, port):
        coroutine = self._loop.create_connection(self._fact, address, port)
        self._loop.run_until_complete(coroutine)

    def _connect_socket(self, path):
        if os.name == 'nt':
            coroutine = self._loop.create_pipe_connection(self._fact, path)
        else:
            coroutine = self._loop.create_unix_connection(self._fact, path)
        self._loop.run_until_complete(coroutine)

    def _stdin_reader(self):
        debug("started reader thread")
        while True: #self._active
            data = self._stdin.read(1)
            debug("reader thread read %d", len(data))
            self._loop.call_soon_threadsafe(self.data_received, data)

    def _connect_stdio(self):
        try:
            coroutine = self._loop.connect_read_pipe(self._fact, sys.stdin)
            self._loop.run_until_complete(coroutine)
            debug("native stdin connection successful")
        except OSError:
            debug("native stdin connection failed, using reader thread")
            if os.name == "nt":
                pass
                #pipe_no_wait(sys.stdin.fileno())
            else:
                import fcntl

                #orig_fl = fcntl.fcntl(sys.stdin.fileno(), fcntl.F_GETFL)
                #fcntl.fcntl(sys.stdin.fileno(), fcntl.F_SETFL, orig_fl | os.O_NONBLOCK)
            #coro = self._loop.run_in_executor(None, self._stdin_reader)
            #self._loop.create_task(coro)
            self._stdin = sys.stdin.buffer
class Foo:
    def __init__(self, x=None):
        self.x = x
            self._active = True
class Foo:
    def __init__(self, x=None):
        self.x = x
            threading.Thread(target=self._stdin_reader).start()


        try:
            coroutine = self._loop.connect_write_pipe(self._fact, sys.stdout)
            self._loop.run_until_complete(coroutine)
            debug("native stdout connection successful")
        except OSError:
            debug("native stdin connection failed, using reader thread")

            self._stdout = sys.stdout.buffer
class Foo:
    def __init__(self, x=None):
        self.x = x
            self._raw_stdout = True
class Foo:
    def __init__(self, x=None):
        self.x = x

    def _connect_child(self, argv):
        self._child_watcher = asyncio.get_child_watcher()
class Foo:
    def __init__(self, x=None):
        self.x = x
        self._child_watcher.attach_loop(self._loop)
        coroutine = self._loop.subprocess_exec(self._fact, *argv)
        self._loop.run_until_complete(coroutine)

    def _start_reading(self):
        pass

    def _send(self, data):
        debug("sent %s %s", repr(data), str(self._raw_stdout))
        if self._raw_stdout:
            self._stdout.write(data)
            self._stdout.flush()
        else:
            self._transport.write(data)

    def _run(self):
        while self._queued_data:
            self._on_data(self._queued_data.popleft())
        self._loop.run_forever()

    def _stop(self):
        self._loop.stop()

    def _close(self):
        if self._raw_transport is not None:
            self._raw_transport.close()
        # FIXME: this is racy and stuff
        self._active = False
class Foo:
    def __init__(self, x=None):
        self.x = x
        self._loop.close()

    def _threadsafe_call(self, fn):
        self._loop.call_soon_threadsafe(fn)

    def _setup_signals(self, signals):
        if os.name == 'nt':
            # add_signal_handler is not supported in win32
            self._signals = []
class Foo:
    def __init__(self, x=None):
        self.x = x
            return

        self._signals = list(signals)
class Foo:
    def __init__(self, x=None):
        self.x = x
        for signum in self._signals:
            self._loop.add_signal_handler(signum, self._on_signal, signum)

    def _teardown_signals(self):
        for signum in self._signals:
            self._loop.remove_signal_handler(signum)


Pull Request — master (#307)

AsyncioEventLoop._connect_child() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1		"""Event loop implementation that uses the `asyncio` standard module.
2
3		The `asyncio` module was added to python standard library on 3.4, and it
4		provides a pure python implementation of an event loop library. It is used
5		as a fallback in case pyuv is not available(on python implementations other
6		than CPython).
7
8		Earlier python versions are supported through the `trollius` package, which
9		is a backport of `asyncio` that works on Python 2.6+.
10		"""
11	5	from __future__ import absolute_import
12
13	5	import logging
14	5	import os
15	5	import sys
16		from collections import deque
17	5	import threading
18
19	5	try:
20	3	# For python 3.4+, use the standard library module
21		import asyncio
22	3	except (ImportError, SyntaxError):
23		# Fallback to trollius
24	5	import trollius as asyncio
		0 ignored issues – show Configuration introduced 2015-12-02 06:47 UTC by Report Bug Copy Issue Report The import `trollius` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
25
26		from .base import BaseEventLoop
27	5
28	5	logger = logging.getLogger(__name__)
29		debug, info, warn = (logger.debug, logger.info, logger.warning,)
30
31		loop_cls = asyncio.SelectorEventLoop
32		if os.name == 'nt':
33		# On windows use ProactorEventLoop which support pipes and is backed by the
34	5	# more powerful IOCP facility
35		# NOTE: we override in the stdio case, because it doesn't work.
36		loop_cls = asyncio.ProactorEventLoop
37
38		import msvcrt
		0 ignored issues – show Configuration introduced 2018-03-05 18:43 UTC by Report Bug Copy Issue Report The import `msvcrt` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
39	5	from ctypes import windll, byref, wintypes, GetLastError, WinError, POINTER
		0 ignored issues – show Unused Code introduced 2018-03-05 18:43 UTC by Report Bug Copy Issue Report Unused GetLastError imported from ctypes Loading history...
40		from ctypes.wintypes import HANDLE, DWORD, BOOL
41	5
42	5	LPDWORD = POINTER(DWORD)
43	5
44		PIPE_NOWAIT = wintypes.DWORD(0x00000001)
45	5
46		ERROR_NO_DATA = 232
47
48		def pipe_no_wait(pipefd):
49	5	SetNamedPipeHandleState = windll.kernel32.SetNamedPipeHandleState
50		SetNamedPipeHandleState.argtypes = [HANDLE, LPDWORD, LPDWORD, LPDWORD]
51		SetNamedPipeHandleState.restype = BOOL
52
53		h = msvcrt.get_osfhandle(pipefd)
54
55		res = windll.kernel32.SetNamedPipeHandleState(h, byref(PIPE_NOWAIT), None, None)
56	5	if res == 0:
57		print(WinError())
58	4	return False
59		return True
60	5
61		class AsyncioEventLoop(BaseEventLoop, asyncio.Protocol,
62	5	asyncio.SubprocessProtocol):
63	4
64	5	"""`BaseEventLoop` subclass that uses `asyncio` as a backend."""
65	5
66		def connection_made(self, transport):
67		"""Used to signal `asyncio.Protocol` of a successful connection."""
68		self._transport = transport
		0 ignored issues – show Coding Style introduced 2015-12-02 06:47 UTC by Report Bug Copy Issue Report The attribute `_transport` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
69	5	self._raw_transport = transport
		0 ignored issues – show Coding Style introduced 2018-02-27 20:13 UTC by Report Bug Copy Issue Report The attribute `_raw_transport` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
70		if isinstance(transport, asyncio.SubprocessTransport):
71		self._transport = transport.get_pipe_transport(0)
		0 ignored issues – show Coding Style introduced 2015-12-02 06:47 UTC by Report Bug Copy Issue Report The attribute `_transport` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
72
73	5	def connection_lost(self, exc):
74	5	"""Used to signal `asyncio.Protocol` of a lost connection."""
75	5	self._on_error(exc.args[0] if exc else 'EOF')
76	5
77		def data_received(self, data):
78	5	"""Used to signal `asyncio.Protocol` of incoming data."""
79		if self._on_data:
80		self._on_data(data)
81		return
82	5	self._queued_data.append(data)
83
84		def pipe_connection_lost(self, fd, exc):
85		"""Used to signal `asyncio.SubprocessProtocol` of a lost connection."""
86		self._on_error(exc.args[0] if exc else 'EOF')
87
88		def pipe_data_received(self, fd, data):
89	5	"""Used to signal `asyncio.SubprocessProtocol` of incoming data."""
90		if fd == 2: # stderr fd number
91		self._on_stderr(data)
		0 ignored issues – show Bug introduced 2015-12-02 06:47 UTC by Report Bug Copy Issue Report The Instance of `AsyncioEventLoop` does not seem to have a member named `_on_stderr`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
92		elif self._on_data:
93	1	self._on_data(data)
94		else:
95	5	self._queued_data.append(data)
96	5
97	5	def process_exited(self):
98		"""Used to signal `asyncio.SubprocessProtocol` when the child exits."""
99	5	self._on_error('EOF')
100	5
101		def _init(self):
102	5	self._loop = loop_cls()
		0 ignored issues – show Coding Style introduced 2015-12-02 06:47 UTC by Report Bug Copy Issue Report The attribute `_loop` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
103	5	self._queued_data = deque()
		0 ignored issues – show Coding Style introduced 2015-12-02 06:47 UTC by Report Bug Copy Issue Report The attribute `_queued_data` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
104		self._fact = lambda: self
		0 ignored issues – show Coding Style introduced 2018-02-27 20:38 UTC by Report Bug Copy Issue Report The attribute `_fact` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
105	5	self._raw_transport = None
		0 ignored issues – show Coding Style introduced 2018-03-05 18:43 UTC by Report Bug Copy Issue Report The attribute `_raw_transport` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
106	5	self._raw_stdout = False
		0 ignored issues – show Coding Style introduced 2018-03-14 18:28 UTC by Report Bug Copy Issue Report The attribute `_raw_stdout` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
107		self._active = False
		0 ignored issues – show Coding Style introduced 2018-03-14 18:28 UTC by Report Bug Copy Issue Report The attribute `_active` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
108	5
109		def _connect_tcp(self, address, port):
110	5	coroutine = self._loop.create_connection(self._fact, address, port)
111	5	self._loop.run_until_complete(coroutine)
112
113	5	def _connect_socket(self, path):
114	5	if os.name == 'nt':
115		coroutine = self._loop.create_pipe_connection(self._fact, path)
116	5	else:
117	5	coroutine = self._loop.create_unix_connection(self._fact, path)
118		self._loop.run_until_complete(coroutine)
119
120		def _stdin_reader(self):
121		debug("started reader thread")
122	5	while True: #self._active
123	5	data = self._stdin.read(1)
124	5	debug("reader thread read %d", len(data))
125		self._loop.call_soon_threadsafe(self.data_received, data)
126	5
127	5	def _connect_stdio(self):
128	5	try:
129		coroutine = self._loop.connect_read_pipe(self._fact, sys.stdin)
130		self._loop.run_until_complete(coroutine)
131		debug("native stdin connection successful")
132		except OSError:
133		debug("native stdin connection failed, using reader thread")
134		if os.name == "nt":
135		pass
136		#pipe_no_wait(sys.stdin.fileno())
137		else:
138		import fcntl
		0 ignored issues – show Unused Code introduced 2018-03-06 10:14 UTC by Report Bug Copy Issue Report The variable `fcntl` seems to be unused. Loading history...
139		#orig_fl = fcntl.fcntl(sys.stdin.fileno(), fcntl.F_GETFL)
140		#fcntl.fcntl(sys.stdin.fileno(), fcntl.F_SETFL, orig_fl \| os.O_NONBLOCK)
141		#coro = self._loop.run_in_executor(None, self._stdin_reader)
142		#self._loop.create_task(coro)
143		self._stdin = sys.stdin.buffer
		0 ignored issues – show Coding Style introduced 2018-03-14 18:28 UTC by Report Bug Copy Issue Report The attribute `_stdin` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
144		self._active = True
		0 ignored issues – show Coding Style introduced 2018-03-14 18:28 UTC by Report Bug Copy Issue Report The attribute `_active` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
145		threading.Thread(target=self._stdin_reader).start()
146
147
148		try:
149		coroutine = self._loop.connect_write_pipe(self._fact, sys.stdout)
150		self._loop.run_until_complete(coroutine)
151		debug("native stdout connection successful")
152		except OSError:
153		debug("native stdin connection failed, using reader thread")
154
155		self._stdout = sys.stdout.buffer
		0 ignored issues – show Bug introduced 2018-03-14 18:28 UTC by Report Bug Copy Issue Report The Instance of `RedirectStream` does not seem to have a member named `buffer`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history... Coding Style introduced 2018-03-14 18:28 UTC by Report Bug Copy Issue Report The attribute `_stdout` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
156		self._raw_stdout = True
		0 ignored issues – show Coding Style introduced 2018-03-14 18:28 UTC by Report Bug Copy Issue Report The attribute `_raw_stdout` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
157
158		def _connect_child(self, argv):
159		self._child_watcher = asyncio.get_child_watcher()
		0 ignored issues – show Coding Style introduced 2017-01-08 20:41 UTC by Report Bug Copy Issue Report The attribute `_child_watcher` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
160		self._child_watcher.attach_loop(self._loop)
161		coroutine = self._loop.subprocess_exec(self._fact, *argv)
162		self._loop.run_until_complete(coroutine)
163
164		def _start_reading(self):
165		pass
166
167		def _send(self, data):
168		debug("sent %s %s", repr(data), str(self._raw_stdout))
169		if self._raw_stdout:
170		self._stdout.write(data)
171		self._stdout.flush()
172		else:
173		self._transport.write(data)
174
175		def _run(self):
176		while self._queued_data:
177		self._on_data(self._queued_data.popleft())
178		self._loop.run_forever()
179
180		def _stop(self):
181		self._loop.stop()
182
183		def _close(self):
184		if self._raw_transport is not None:
185		self._raw_transport.close()
186		# FIXME: this is racy and stuff
187		self._active = False
		0 ignored issues – show Coding Style introduced 2018-03-14 18:28 UTC by Report Bug Copy Issue Report The attribute `_active` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
188		self._loop.close()
189
190		def _threadsafe_call(self, fn):
191		self._loop.call_soon_threadsafe(fn)
192
193		def _setup_signals(self, signals):
194		if os.name == 'nt':
195		# add_signal_handler is not supported in win32
196		self._signals = []
		0 ignored issues – show Coding Style introduced 2016-02-15 16:00 UTC by Report Bug Copy Issue Report The attribute `_signals` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
197		return
198
199		self._signals = list(signals)
		0 ignored issues – show Coding Style introduced 2015-12-02 06:47 UTC by Report Bug Copy Issue Report The attribute `_signals` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
200		for signum in self._signals:
201		self._loop.add_signal_handler(signum, self._on_signal, signum)
202
203		def _teardown_signals(self):
204		for signum in self._signals:
205		self._loop.remove_signal_handler(signum)
206

neovim / python-client

Pull Request — master (#307)

AsyncioEventLoop._connect_child() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files