View GitHub Repository json-api

Schedule Inspection
Subscribe
Completed
Pull Request — master (#227)
by
unknown
02:04
created
Status
Category
Toggle Patches
src/Exceptions/JsonApiException.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -54,7 +54,7 @@
 
 block discarded – undo
54 54 
     private $httpCode;
55 55
56 56 
     /**
57 
-     * @param ErrorInterface|iterable $errors
57 
+     * @param ErrorInterface $errors
58 58 
      * @param int                     $httpCode
59 59 
      * @param Exception|null          $previous
60 60 
      *
Please login to merge, or discard this patch.
src/Http/Query/BaseQueryParserTrait.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -30,7 +30,7 @@  discard block
 
 block discarded – undo
30 30 
      * @param array  $parameters
31 31 
      * @param string $errorTitle
32 32 
      *
33 
-     * @return iterable
33 
+     * @return \Generator
34 34 
      */
35 35 
     protected function getIncludes(array $parameters, string $errorTitle): iterable
36 36 
     {
 
@@ -47,7 +47,7 @@  discard block
 
 block discarded – undo
47 47 
      * @param array  $parameters
48 48 
      * @param string $errorTitle
49 49 
      *
50 
-     * @return iterable
50 
+     * @return \Generator
51 51 
      */
52 52 
     protected function getFields(array $parameters, string $errorTitle): iterable
53 53 
     {
 
@@ -67,7 +67,7 @@  discard block
 
 block discarded – undo
67 67 
      * @param array  $parameters
68 68 
      * @param string $errorTitle
69 69 
      *
70 
-     * @return iterable
70 
+     * @return \Generator
71 71 
      */
72 72 
     protected function getSorts(array $parameters, string $errorTitle): iterable
73 73 
     {
 
@@ -99,7 +99,7 @@  discard block
 
 block discarded – undo
99 99 
      * @param array  $parameters
100 100 
      * @param string $errorTitle
101 101 
      *
102 
-     * @return iterable
102 
+     * @return \Generator
103 103 
      */
104 104 
     protected function getProfileUrls(array $parameters, string $errorTitle): iterable
105 105 
     {
 
@@ -119,7 +119,7 @@  discard block
 
 block discarded – undo
119 119 
      * @param string|mixed $shouldBeString
120 120 
      * @param string       $errorTitle
121 121 
      *
122 
-     * @return iterable
122 
+     * @return \Generator
123 123 
      */
124 124 
     private function splitCommaSeparatedStringAndCheckNoEmpties(
125 125 
         string $paramName,
 
@@ -131,10 +131,10 @@  discard block
 
 block discarded – undo
131 131
132 132 
     /**
133 133 
      * @param string       $paramName
134 
-     * @param string|mixed $shouldBeString
134 
+     * @param string $shouldBeString
135 135 
      * @param string       $errorTitle
136 136 
      *
137 
-     * @return iterable
137 
+     * @return \Generator
138 138 
      */
139 139 
     private function splitSpaceSeparatedStringAndCheckNoEmpties(
140 140 
         string $paramName,
 
@@ -150,7 +150,7 @@  discard block
 
 block discarded – undo
150 150 
      * @param string       $separator
151 151 
      * @param string       $errorTitle
152 152 
      *
153 
-     * @return iterable
153 
+     * @return \Generator
154 154 
      */
155 155 
     private function splitStringAndCheckNoEmpties(
156 156 
         string $paramName,
Please login to merge, or discard this patch.
src/Representation/FieldSetFilter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -117,7 +117,7 @@
 
 block discarded – undo
117 117 
      * @param string   $type
118 118 
      * @param iterable $fields
119 119 
      *
120 
-     * @return iterable
120 
+     * @return \Generator
121 121 
      */
122 122 
     protected function filterFields(string $type, iterable $fields): iterable
123 123 
     {
Please login to merge, or discard this patch.
src/Parser/RelationshipData/ParseRelationshipLinksTrait.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -84,7 +84,7 @@
 
 block discarded – undo
84 84 
      * @param bool            $addSelfLink
85 85 
      * @param bool            $addRelatedLink
86 86 
      *
87 
-     * @return iterable
87 
+     * @return \Generator
88 88 
      */
89 89 
     private function parseLinks(
90 90 
         SchemaInterface $parentSchema,
Please login to merge, or discard this patch.
src/Parser/Parser.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -188,7 +188,7 @@  discard block
 
 block discarded – undo
188 188 
      * @see ResourceInterface
189 189 
      * @see IdentifierInterface
190 190 
      *
191 
-     * @return iterable
191 
+     * @return \Generator
192 192 
      */
193 193 
     private function parseAsResourcesOrIdentifiers(
194 194 
         PositionInterface $position,
 
@@ -212,7 +212,7 @@  discard block
 
 block discarded – undo
212 212 
      *
213 213 
      * @see ResourceInterface
214 214 
      *
215 
-     * @return iterable
215 
+     * @return \Generator
216 216 
      *
217 217 
      */
218 218 
     private function parseAsResource(
 
@@ -233,7 +233,7 @@  discard block
 
 block discarded – undo
233 233 
     /**
234 234 
      * @param ResourceInterface $resource
235 235 
      *
236 
-     * @return iterable
236 
+     * @return \Generator
237 237 
      *
238 238 
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
239 239 
      */
Please login to merge, or discard this patch.