D::getCustomGetterPrefix() - Code Metrics - Inspection of "Merge branch 'v0.6.x'" - nelson6e65/php_nml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 446f2e...32b2c3 )

by Nelson

created 2016-10-04 16:37 UTC

D::getCustomGetterPrefix() A

↳ Parent: D

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/**
 * PHP: Nelson Martell Library file
 *
 * Content:
 * - Class definition.
 *
 * Copyright © 2016 Nelson Martell (http://nelson6e65.github.io)
 *
 * Licensed under The MIT License (MIT)
 * For full copyright and license information, please see the LICENSE
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright 2016 Nelson Martell
 * @link      http://nelson6e65.github.io/php_nml/
 * @since     v0.6.0
 * @license   http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
 * */

namespace NelsonMartell\Test\DataProviders\ExampleClass;

class D extends C
{
    public function __construct()
    {
        parent::__construct();
        unset(
            $this->property9
        );
    }

    public static function getCustomGetterPrefix()
    {
        return 'get_';
    }

    public static function getCustomSetterPrefix()
    {
        return 'set_';
    }


    private $attribute8 = -8;

    public function get_attribute8()

    {
        return $this->attribute8;
    }

    private $attribute9 = -9;
    public $property9;

    protected function get_property9()

    {
        return $this->attribute9;
    }

    protected function set_property9($value)

    {
        $this->attribute9 = $value * 10;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }
}



1			<?php
2			/**
3			* PHP: Nelson Martell Library file
4			*
5			* Content:
6			* - Class definition.
7			*
8			* Copyright © 2016 Nelson Martell (http://nelson6e65.github.io)
9			*
10			* Licensed under The MIT License (MIT)
11			* For full copyright and license information, please see the LICENSE
12			* Redistributions of files must retain the above copyright notice.
13			*
14			* @copyright 2016 Nelson Martell
15			* @link http://nelson6e65.github.io/php_nml/
16			* @since v0.6.0
17			* @license http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
18			* */
19
20			namespace NelsonMartell\Test\DataProviders\ExampleClass;
21
22			class D extends C
23			{
24			public function __construct()
25			{
26			parent::__construct();
27			unset(
28			$this->property9
29			);
30			}
31
32			public static function getCustomGetterPrefix()
33			{
34			return 'get_';
35			}
36
37			public static function getCustomSetterPrefix()
38			{
39			return 'set_';
40			}
41
42
43			private $attribute8 = -8;
44
45			public function get_attribute8()
			0 ignored issues – show Coding Style introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report This method is not in camel caps format. This check looks for method names that are not written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection seeker becomes `databaseConnectionSeeker`. Loading history...
46			{
47			return $this->attribute8;
48			}
49
50			private $attribute9 = -9;
51			public $property9;
52
53			protected function get_property9()
			0 ignored issues – show Coding Style introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report This method is not in camel caps format. This check looks for method names that are not written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection seeker becomes `databaseConnectionSeeker`. Loading history...
54			{
55			return $this->attribute9;
56			}
57
58			protected function set_property9($value)
			0 ignored issues – show Coding Style introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report This method is not in camel caps format. This check looks for method names that are not written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection seeker becomes `databaseConnectionSeeker`. Loading history...
59			{
60			$this->attribute9 = $value * 10;
			0 ignored issues – show Documentation Bug introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report It seems like `$value * 10` can also be of type `double`. However, the property `$attribute9` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
61			}
62			}
			0 ignored issues – show Coding Style introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
63

nelson6e65 / php_nml

Push — master ( 446f2e...32b2c3 )

D::getCustomGetterPrefix() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like