B - Code Metrics - Inspection of "Merge branch 'v0.6.x'" - nelson6e65/php_nml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 446f2e...32b2c3 )

by Nelson

created 2016-10-04 16:37 UTC

B A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	38
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	1

4 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	setProperty2()	4	1
A	getProperty4()	4	1
A	setProperty1()	4	1

<?php
/**
 * PHP: Nelson Martell Library file
 *
 * Content:
 * - Class definition.
 *
 * Copyright © 2016 Nelson Martell (http://nelson6e65.github.io)
 *
 * Licensed under The MIT License (MIT)
 * For full copyright and license information, please see the LICENSE
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright 2016 Nelson Martell
 * @link      http://nelson6e65.github.io/php_nml/
 * @since     v0.6.0
 * @license   http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
 * */

namespace NelsonMartell\Test\DataProviders\ExampleClass;

class B extends A
{
    public function __construct()
    {
        parent::__construct();
        unset(
            $this->property2,
            $this->property4
        );
    }

    // This is a wrapper for attribute2
    public $property2;

    /**
     * Sets attribute of parent class directly
     */
    public function setProperty2($value)
    {
        $this->attribute2 = $value; //This is accesible since is protected
    }

    public $property4;
    protected function getProperty4()
    {
        return $this->attribute4;
    }

    # ERRORS #########################################

    /**
     * Try to make read-only property accesible in this parent class
     * @throws \BadMethodCallException
     */
    protected function setProperty1($value)
    {
        $this->attribute1 = $value; //This is not accesible since is declared private in A
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}



1			<?php
2			/**
3			* PHP: Nelson Martell Library file
4			*
5			* Content:
6			* - Class definition.
7			*
8			* Copyright © 2016 Nelson Martell (http://nelson6e65.github.io)
9			*
10			* Licensed under The MIT License (MIT)
11			* For full copyright and license information, please see the LICENSE
12			* Redistributions of files must retain the above copyright notice.
13			*
14			* @copyright 2016 Nelson Martell
15			* @link http://nelson6e65.github.io/php_nml/
16			* @since v0.6.0
17			* @license http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
18			* */
19
20			namespace NelsonMartell\Test\DataProviders\ExampleClass;
21
22			class B extends A
23			{
24			public function __construct()
25			{
26			parent::__construct();
27			unset(
28			$this->property2,
29			$this->property4
30			);
31			}
32
33			// This is a wrapper for attribute2
34			public $property2;
35
36			/**
37			* Sets attribute of parent class directly
38			*/
39			public function setProperty2($value)
40			{
41			$this->attribute2 = $value; //This is accesible since is protected
42			}
43
44			public $property4;
45			protected function getProperty4()
46			{
47			return $this->attribute4;
48			}
49
50			# ERRORS #########################################
			0 ignored issues – show Coding Style introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead. Loading history...
51			/**
52			* Try to make read-only property accesible in this parent class
53			* @throws \BadMethodCallException
54			*/
55			protected function setProperty1($value)
56			{
57			$this->attribute1 = $value; //This is not accesible since is declared private in A
			0 ignored issues – show Documentation introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report The property `$attribute1` is declared private in `NelsonMartell\Test\DataProviders\ExampleClass\A`. Since you implemented `__set()`, maybe consider adding a @property or @property-write annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
58			}
59			}
			0 ignored issues – show Coding Style introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
60

nelson6e65 / php_nml

Push — master ( 446f2e...32b2c3 )

B A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like