Version - Code Metrics - Inspection of ":up: Type: Simplify isValueType()." - nelson6e65/php_nml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0f375a...9b86b0 )

by Nelson

created 2016-10-07 01:35 UTC

Version C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	423
Duplicated Lines	15.6 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

96.59%

Importance

Changes	4
Bugs	1	Features	2

Metric	Value
c	4
b	1
f	2
dl	66
loc	423
ccs	170
cts	176
cp	0.9659
rs	6.5957
wmc	56
lcom	1
cbo	3

10 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	66	80	5
C	parse()	0	51	10
A	getMajor()	0	4	1
A	getMinor()	0	4	1
A	getBuild()	0	4	1
A	getRevision()	0	4	1
C	isValid()	0	37	13
B	equals()	0	14	6
C	compareTo()	0	52	15
A	toString()	0	17	3

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Version often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Version, and based on these observations, apply Extract Interface, too.

<?php
/**
 * PHP: Nelson Martell Library file
 *
 * Content:
 * - Class definition:  [NelsonMartell]  Version
 *
 * Copyright © 2015-2016 Nelson Martell (http://nelson6e65.github.io)
 *
 * Licensed under The MIT License (MIT)
 * For full copyright and license information, please see the LICENSE
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright 2015-2016 Nelson Martell
 * @link      http://nelson6e65.github.io/php_nml/
 * @since     v0.1.1
 * @license   http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
 * */

namespace NelsonMartell;

use \InvalidArgumentException;

/**
 * Representa el número de versión de un programa o ensamblado, de la forma "1.2.3.4". Sólo
 * siendo obligatorios el primer y segundo componente.
 * No se puede heredar esta clase.
 *
 * @author Nelson Martell <[email protected]>
 * */
final class Version extends Object implements IEquatable, IComparable
{

    /**
     * Crea una nueva instancia con los números principal, secundario, de
     * compilación (opcional) y revisión (opcional).
     * Para comprobar si la versión es válida, usar el método isValid.
     *
     * @param int                              $major    Componente principal
     * @param int                              $minor    Componente secundario
     * @param int|string|VersionComponent|null $build    Componente de compilación
     * @param int|string|VersionComponent|null $revision Componente de revisión
     *
     * @throws InvalidArgumentException
     * */
    public function __construct($major, $minor, $build = null, $revision = null)
    {
        parent::__construct();
        unset($this->Major, $this->Minor, $this->Build, $this->Revision);

        if (!is_integer($major)) {

            $args = [
                'class'    => typeof($this)->Name,

                'name'     => 'major',
                'pos'      => 0,
                'expected' => typeof(0),

                'actual'   => typeof($major),

            ];

            $msg = nml_msg('Invalid argument type.');
$a = "a";
$ab = "ab";
$abc = "abc";
            $msg .= nml_msg(

                ' "{name}" (position {pos}) must to be an instance of "{expected}"; "{actual}" given.',
                $args
            );
            $msg .= nml_msg(' Convert value or use the "{class}::parse" (static) method.', $args);


            throw new InvalidArgumentException($msg);
        }

        if (!is_integer($minor)) {

            $args = [
                'class'    => typeof($this)->Name,

                'name'     => 'minor',
                'pos'      => 1,
                'expected' => typeof(0),

                'actual'   => typeof($minor),

            ];

            $msg = nml_msg('Invalid argument type.');
$a = "a";
$ab = "ab";
$abc = "abc";
            $msg .= nml_msg(

                ' "{name}" (position {pos}) must to be an instance of "{expected}"; "{actual}" given.',
                $args
            );
            $msg .= nml_msg(' Convert value or use the "{class}::parse" (static) method.', $args);


            throw new InvalidArgumentException($msg);
        }

        if ($major < 0) {

            $args = [
                'name'     => 'major',
                'pos'      => 0,
                'actual'   => $major,
            ];

            $msg = nml_msg('Invalid argument value.');
$a = "a";
$ab = "ab";
$abc = "abc";
            $msg .= nml_msg(

                ' "{name}" (position {pos}) must to be a positive number; "{actual}" given.',
                $args
            );

            throw new InvalidArgumentException($msg);
        }

        if ($minor < 0) {

            $args = [
                'name'     => 'minor',
                'pos'      => 1,
                'actual'   => $minor,
            ];

            $msg = nml_msg('Invalid argument value.');
$a = "a";
$ab = "ab";
$abc = "abc";
            $msg .= nml_msg(

                ' "{name}" (position {pos}) must to be a positive number; "{actual}" given.',
                $args
            );

            throw new InvalidArgumentException($msg);
        }

        $this->major = $major;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->minor = $minor;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->build = VersionComponent::Parse($build);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->revision = VersionComponent::Parse($revision);
    }

    /**
     * Convierte una cadena a su representación del tipo Version.
     *
     * @param Version|string|int|float|array $value Objeto a convertir.
     *
     * @return Version Objeto convertido desde $value.
     * */
    public static function parse($value)
    {
        if ($value instanceof Version) {
            return $value;
        }

        $version = [];

        // Try to convert into an array
        if (is_integer($value)) {
            // Integer for major value
            $version = [$value, 0];
        } elseif (is_float($value)) {
            // Integer part as major, and decimal part as minor
            $version = sprintf("%F", $value);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $version = explode('.', $version);
        } elseif (is_array($value)) {
            // Implode first 4 places for major, minor, build and revision respectivally.
            $version = array_slice($value, 0, 4);
        } elseif (is_string($value)) {
            $version = explode('.', $value);
        } else {
            $msg = nml_msg('Unable to parse. Argument passed has an invalid type: "{0}".', typeof($value));

            throw new InvalidArgumentException($msg);
        }

        // $value ya debería ser un array.
        $c = count($version);


        if ($c > 4 || $c < 2) {
            $msg = nml_msg('Unable to parse. Argument passed has an invalid format: "{0}".', $value);

            //var_dump($version);
            throw new InvalidArgumentException($msg);
        }


        $major = (int) $version[0];
$a = "a";
$ab = "ab";
$abc = "abc";
        $minor = (int) $version[1];
$a = "a";
$ab = "ab";
$abc = "abc";
        $build = null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $revision = null;

        if (count($version) >= 3) {
            $build = VersionComponent::Parse($version[2]);

            if (count($version) == 4) {
                $revision = VersionComponent::Parse($version[3]);
            }
        }

        return new Version($major, $minor, $build, $revision);
    }

    /**
     * Obtiene el valor del componente principal del número de versión del
     * objeto actual.
     * Esta propiedad es de sólo lectura.
     *
     * @var int Componente principal del número de versión.
     * */
    public $Major;
    private $major;

    /**
     * Getter for Major property.
     *
     * @return integer
     * @see    Version::Major.
     */
    public function getMajor()
    {
        return $this->major;
    }


    /**
     * Obtiene el valor del componente secundario del número de versión del
     * objeto actual.
     * Esta propiedad es de sólo lectura.
     *
     * @var int Componente secundario del número de versión.
     * */
    public $Minor;
    private $minor;

    /**
     * Getter for minor property.
     *
     * @return integer
     * @see    Version::Minor.
     */
    public function getMinor()
    {
        return $this->minor;
    }

    /**
     * Obtiene el valor del componente de compilación del número de versión
     * del objeto actual.
     * Esta propiedad es de sólo lectura.
     *
     * @var VersionComponent Componente de compilación del número de versión.
     * */
    public $Build;
    private $build;

    /**
     * Getter for Build property.
     *
     * @return VersionComponent
     * @see    Version::Build
     */
    public function getBuild()
    {
        return $this->build;
    }

    /**
     * Obtiene el valor del componente de revisión del número de versión del
     * objeto actual.
     * Esta propiedad es de sólo lectura.
     *
     * @var VersionComponent Componente de revisión del número de versión.
     * */
    public $Revision;
    private $revision;

    /**
     * Getter for Revision property.
     *
     * @return VersionComponent
     * @see    Version::Revision
     */
    public function getRevision()
    {
        return $this->revision;
    }


    /**
     * Convierte la instancia actual en su representación en cadena.
     * Por defecto, si no están definidos los componentes de compilación y
     * revisión, no se incluyen en la salida.
     * Use el método isValid si quiere determinar si la versión es válida
     * antes de devolver esta cadena.
     *
     * @return string Representación de la versión en forma de cadena:
     *   'major.minor[.build[.revision]]'
     * @see    VersionComponent::isNull
     * @see    Version::isValid
     * */
    public function toString()
    {
        $s[0] = $this->Major;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $s[1] = $this->Minor;

        if ($this->Revision->IsNotNull()) {
            $s[2] = $this->Build;
            $s[3] = $this->Revision;
        } else {
            if ($this->Build->IsNotNull()) {
                $s[2] = $this->Build;
            }
        }
        $v = implode('.', $s);


        return $v;
    }

    /**
     * Indica si la instancia actual es un número de versión válido.
     *
     * Se considera válido si:
     * 1. Major o Minor es mayor a cero (0). No puede ser '0.0'.
     * 2. Build y Revision son nulos (no están definidos).
     * 3. Build está definido pero Revision no.
     * 4. Ambos están definidos, pero no poseen la parte de la cadena.
     * 5. Ambos están definidos, pero Build no posee la parte de cadena.
     * 6. Build está definido y tiene la cadena, pero Revision no está definido.
     * 7. Revision posee cadena, pero Build no.
     *
     * @return boolean Un valor que indica si la instancia actual es válida.
     * */
    public function isValid()
    {
        // Validación de Major y Minor:
        $r = ($this->Major > 0 or $this->Minor > 0); //#1
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

        // Validación de Build y Revision:
        if ($r) {
            $r = ($this->Build->IsNull() and $this->Revision->IsNull()); // #2
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

            if (!$r) {
                if ($this->Build->IsNotNull() and $this->Revision->IsNotNull()) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                    // Si ambos están definidos...

                    $r = (bool) ($this->Build->StringValue == ''); //#5

                    if (!$r) {
                        //#4
                        $r = (bool) (($this->Build->StringValue == '') and ($this->Revision->StringValue == ''));
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

                        if (!$r) {
                            if ($this->Build->StringValue != '') {
                                $r = $this->Revision->IsNull(); #6

                            }

                            if ($this->Revision->StringValue != '') {
                                $r = ($this->Build->StringValue == ''); #7

                            }
                        }
                    }
                } else {
                    $r = ($this->Build->IsNotNull() and $this->Revision->IsNull()); //#3
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                }
            }
        }

        return (bool) $r;
    }

    /**
     * Determina si el objeto $other especificado es igual a la instancia actual.
     *
     * @param Version $other El otro objeto a comparar.
     *
     * @return bool `true` si $other es igual esta instancia; caso contrario,
     *   `false`.
     * */
    public function equals($other)
    {
        if ($other instanceof Version) {
            if ($this->Major == $other->Major && $this->Minor == $other->Minor) {
                if ($this->Build->equals($other->Build)) {
                    if ($this->Revision->equals($other->Revision)) {
                        return true;
                    }
                }
            }
        }

        return false;
    }


    #region IComparable


    /**
     * Determina la posición relativa de esta instancia con respecto al objeto especificado.
     *
     * For types different than ``Version``:
     * - ``integer`` and ``null`` are always < 0;
     * - ``string`` and ``array`` are parsed and then evaluated (if is not parseable, always > 0);
     * - other types are always > 0
     *
     * @param Version|int|string|mixed $other
     *   The other object to compare with.
     *
     * @return integer|null
     *   Returns:
     *   - ``= 0`` if this instance is considered equivalent to $other;
     *   - ``> 0`` si esta instancia se considera mayor a $other;
     *   - ``< 0`` si esta instancia se considera menor a $other.
     *   - ``null`` if this instance can't be compared against $other .
     * @see Object::compare()
     * */
    public function compareTo($other)
    {
        $r = $this->equals($other) ? 0 : 9999;


        if (!($other instanceof Version)) {
            switch (typeof($other)->toString()) {

                case 'integer':
                case 'float':
                case 'double':
                case 'null':
                case 'NULL':
                    $r = 1; // Siempre es mayor a cualquier número o null
                    break;

                case 'string':
                case 'array':
                    // Se tratan de convertir las cadenas y arrays
                    try {
                        $tmp = Version::parse($other);
                        $r = $this->compareTo($tmp);
$a = "a";
$ab = "ab";
$abc = "abc";
                    } catch (InvalidArgumentException $e) {
                        // Siempre es mayor a strings o arrays que no se puedan convertir
                        $r = 1;
                    }
                    break;

                default:
                    // No se puede determinar comparando a otros objetos.
                    $r = null;
            }

            return $r;
        }

        if ($r != 0) {
            $r = $this->Major - $other->Major;

            if ($r == 0) {
                $r = $this->Minor - $other->Minor;

                if ($r == 0) {
                    $r = $this->Build->compareTo($other->Build);

                    if ($r == 0) {

                        $r = $this->Revision->compareTo($other->Revision);
                    }
                }
            }
        }

        return $r;
    }

    #endregion

}



Push — master ( 0f375a...9b86b0 )

Version C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

nelson6e65 / php_nml

Push — master ( 0f375a...9b86b0 )

Version C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like