HasWriteOnlyProperties::testWriteonlyPropertiesAreWritables() - Code Metrics - Inspection of "Improve `testReadonlyPropertiesAreReadables`test" - nelson6e65/php_nml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6446f...d11253 )

by Nelson

created 2017-10-20 01:57 UTC

testWriteonlyPropertiesAreWritables() A

↳ Parent: HasWriteOnlyProperties

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	3
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * PHP: Nelson Martell Library file
 *
 * Content:
 * - Trait definition
 *
 * Copyright © 2017 Nelson Martell (http://nelson6e65.github.io)
 *
 * Licensed under The MIT License (MIT)
 * For full copyright and license information, please see the LICENSE
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright 2017 Nelson Martell
 * @link      http://nelson6e65.github.io/php_nml/
 * @since     v0.7.0
 * @license   http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
 * */

namespace NelsonMartell\Test\Helpers;

use Cake\Utility\Inflector;
use NelsonMartell\Extensions\Text;
use NelsonMartell\IStrictPropertiesContainer;
use SebastianBergmann\Exporter\Exporter;

/**
 * Split of ImplementsIStrictPropertiesContainer, for classes implementing any write-only property.
 *
 * @author Nelson Martell <[email protected]>
 * */
trait HasWriteOnlyProperties
{
    /**
     * @returns IStrictPropertiesContainer
     */
    public abstract function testImplementsIStrictPropertiesContainerInterface($obj);


    public abstract function writeonlyPropertiesProvider();


    /**
     * @dataProvider writeonlyPropertiesProvider
     */
    public function testWriteonlyPropertiesAreWritables(
        IStrictPropertiesContainer $obj,
        $property,
        $value
    ) {
        $obj->$property = $value;
    }

    /**
     * @depends testWriteonlyPropertiesAreWritables
     * @dataProvider writeonlyPropertiesProvider
     * @expectedException \BadMethodCallException
     */
    public function testWriteonlyPropertiesAreNotReadables(
        IStrictPropertiesContainer $obj,
        $property,
        $value
    ) {
        $obj->$property = $value;
        $actual = $obj->$property;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php
2			/**
3			* PHP: Nelson Martell Library file
4			*
5			* Content:
6			* - Trait definition
7			*
8			* Copyright © 2017 Nelson Martell (http://nelson6e65.github.io)
9			*
10			* Licensed under The MIT License (MIT)
11			* For full copyright and license information, please see the LICENSE
12			* Redistributions of files must retain the above copyright notice.
13			*
14			* @copyright 2017 Nelson Martell
15			* @link http://nelson6e65.github.io/php_nml/
16			* @since v0.7.0
17			* @license http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
18			* */
19
20			namespace NelsonMartell\Test\Helpers;
21
22			use Cake\Utility\Inflector;
23			use NelsonMartell\Extensions\Text;
24			use NelsonMartell\IStrictPropertiesContainer;
25			use SebastianBergmann\Exporter\Exporter;
26
27			/**
28			* Split of ImplementsIStrictPropertiesContainer, for classes implementing any write-only property.
29			*
30			* @author Nelson Martell <[email protected]>
31			* */
32			trait HasWriteOnlyProperties
33			{
34			/**
35			* @returns IStrictPropertiesContainer
36			*/
37			public abstract function testImplementsIStrictPropertiesContainerInterface($obj);
			0 ignored issues – show Documentation introduced 2017-10-20 02:02 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
38
39			public abstract function writeonlyPropertiesProvider();
			0 ignored issues – show Documentation introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
40
41			/**
42			* @dataProvider writeonlyPropertiesProvider
43			*/
44			public function testWriteonlyPropertiesAreWritables(
45			IStrictPropertiesContainer $obj,
46			$property,
47			$value
48			) {
49			$obj->$property = $value;
50			}
51
52			/**
53			* @depends testWriteonlyPropertiesAreWritables
54			* @dataProvider writeonlyPropertiesProvider
55			* @expectedException \BadMethodCallException
56			*/
57			public function testWriteonlyPropertiesAreNotReadables(
58			IStrictPropertiesContainer $obj,
59			$property,
60			$value
61			) {
62			$obj->$property = $value;
63			$actual = $obj->$property;
			0 ignored issues – show Unused Code introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report `$actual` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Coding Style introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
64			}
65			}
66

nelson6e65 / php_nml

Push — master ( d6446f...d11253 )

testWriteonlyPropertiesAreWritables() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like