HasUnaccesibleProperties::testUnaccessiblePropertiesThrowsCatchableError() - Code Metrics - Inspection of "Improve `testReadonlyPropertiesAreReadables`test" - nelson6e65/php_nml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6446f...d11253 )

by Nelson

created 2017-10-20 01:57 UTC

testUnaccessiblePropertiesThrowsCatchableError() A

↳ Parent: HasUnaccesibleProperties

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	3
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * PHP: Nelson Martell Library file
 *
 * Content:
 * - Trait definition
 *
 * Copyright © 2016-2017 Nelson Martell (http://nelson6e65.github.io)
 *
 * Licensed under The MIT License (MIT)
 * For full copyright and license information, please see the LICENSE
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright 2016-2017 Nelson Martell
 * @link      http://nelson6e65.github.io/php_nml/
 * @since     v0.7.0
 * @license   http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
 * */

namespace NelsonMartell\Test\Helpers;

use Cake\Utility\Inflector;
use NelsonMartell\Extensions\Text;
use NelsonMartell\IStrictPropertiesContainer;
use SebastianBergmann\Exporter\Exporter;

/**
 * Split of ImplementsIStrictPropertiesContainer, for classes implementing any read-only property
 *
 * @author Nelson Martell <[email protected]>
 * */
trait HasUnaccesibleProperties
{
    /**
     * @returns IStrictPropertiesContainer
     */
    public abstract function testImplementsIStrictPropertiesContainerInterface($obj);


    public abstract function unaccesiblePropertiesProvider();


    /**
     * @dataProvider unaccesiblePropertiesProvider
     * @expectedException \BadMethodCallException
     */
    public function testUnaccessiblePropertiesThrowsCatchableError(
        IStrictPropertiesContainer $obj,
        $property,
        $value = null
    ) {

        if ($value === null) {
            // Getter exception
            $actual = $obj->$property;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            // Setter exception
            $obj->$property = $value;
        }
    }
}


1			<?php
2			/**
3			* PHP: Nelson Martell Library file
4			*
5			* Content:
6			* - Trait definition
7			*
8			* Copyright © 2016-2017 Nelson Martell (http://nelson6e65.github.io)
9			*
10			* Licensed under The MIT License (MIT)
11			* For full copyright and license information, please see the LICENSE
12			* Redistributions of files must retain the above copyright notice.
13			*
14			* @copyright 2016-2017 Nelson Martell
15			* @link http://nelson6e65.github.io/php_nml/
16			* @since v0.7.0
17			* @license http://www.opensource.org/licenses/mit-license.php The MIT License (MIT)
18			* */
19
20			namespace NelsonMartell\Test\Helpers;
21
22			use Cake\Utility\Inflector;
23			use NelsonMartell\Extensions\Text;
24			use NelsonMartell\IStrictPropertiesContainer;
25			use SebastianBergmann\Exporter\Exporter;
26
27			/**
28			* Split of ImplementsIStrictPropertiesContainer, for classes implementing any read-only property
29			*
30			* @author Nelson Martell <[email protected]>
31			* */
32			trait HasUnaccesibleProperties
33			{
34			/**
35			* @returns IStrictPropertiesContainer
36			*/
37			public abstract function testImplementsIStrictPropertiesContainerInterface($obj);
			0 ignored issues – show Documentation introduced 2017-10-20 02:02 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
38
39			public abstract function unaccesiblePropertiesProvider();
			0 ignored issues – show Documentation introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
40
41			/**
42			* @dataProvider unaccesiblePropertiesProvider
43			* @expectedException \BadMethodCallException
44			*/
45			public function testUnaccessiblePropertiesThrowsCatchableError(
46			IStrictPropertiesContainer $obj,
47			$property,
48			$value = null
49			) {
50
51			if ($value === null) {
52			// Getter exception
53			$actual = $obj->$property;
			0 ignored issues – show Unused Code introduced 2016-10-04 16:48 UTC by Report Bug Copy Issue Report `$actual` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
54			} else {
55			// Setter exception
56			$obj->$property = $value;
57			}
58			}
59			}
60

nelson6e65 / php_nml

Push — master ( d6446f...d11253 )

testUnaccessiblePropertiesThrowsCatchableError() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like