NelsonMartell\Extensions\Text::insert()

Complexity

Conditions	14
Paths	58

Size

Total Lines	58
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	35
CRAP Score	14.6137

Importance

Changes

0

<?php
    public static function insert(string $str, array $data, array $options = []): string
    {
        $defaults = [
            'before' => ':',
            'after'  => '',
            'escape' => '\\',
            'format' => null,
            'clean'  => false,
        ];
        $options += $defaults;
        $format   = $options['format'];
        $data     = $data;
        if (empty($data)) {
            return $options['clean'] ? static::cleanInsert($str, $options) : $str;
        }

        if (!isset($format)) {
            $format = sprintf(
                '/(?<!%s)%s%%s%s/',
                preg_quote($options['escape'], '/'),
                str_replace('%', '%%', preg_quote($options['before'], '/')),
                str_replace('%', '%%', preg_quote($options['after'], '/'))
            );
        }

        if (strpos($str, '?') !== false && is_numeric(key($data))) {
            $offset = 0;
            while (($pos = strpos($str, '?', $offset)) !== false) {

Variable assignment found within a condition. Did you mean to do a comparison ?

It seems like $str can also be of type array; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

                $val    = array_shift($data);
                $offset = $pos + strlen($val);
                $str    = substr_replace($str, $val, $pos, 1);
            }

            return $options['clean'] ? static::cleanInsert($str, $options) : $str;

It seems like $str can also be of type array; however, parameter $str of NelsonMartell\Extensions\Text::cleanInsert() does only seem to accept string, maybe add an additional type check?

        }

        $dataKeys = array_keys($data);
        $hashKeys = array_map('crc32', $dataKeys);
        /** @var array<string, string> $tempData */
        $tempData = array_combine($dataKeys, $hashKeys);
        krsort($tempData);

        foreach ($tempData as $key => $hashVal) {
            $key = sprintf($format, preg_quote($key, '/'));
            $str = preg_replace($key, $hashVal, $str);
        }
        /** @var array<string, mixed> $dataReplacements */
        $dataReplacements = array_combine($hashKeys, array_values($data));
        foreach ($dataReplacements as $tmpHash => $tmpValue) {
            $tmpValue = is_array($tmpValue) ? '' : $tmpValue;
            $str      = str_replace($tmpHash, $tmpValue, $str);
        }

        if (!isset($options['format']) && isset($options['before'])) {
            $str = str_replace($options['escape'] . $options['before'], $options['before'], $str);
        }

        return $options['clean'] ? static::cleanInsert($str, $options) : $str;
    }