neilherbertuk / modules

src/Traits/MakeController.php

<?php

namespace neilherbertuk\modules\Traits;

use Illuminate\Support\Facades\App;

trait MakeController{

    /**
     * @param $module
     * @param $filename
     */
    protected function createController($module, $filename)
    {
        $this->info("Creating a new Controller");

It seems like info() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->info("Creating $module:$filename Controller");
        $this->createControllersFolder($module);
        if (!file_exists(base_path() . "/app/Modules/" . $module . "/Controllers/" . $filename . ".php")) {

This line exceeds maximum limit of 100 characters; contains 107 characters

            file_put_contents(
                base_path() . "/app/Modules/" . $module . "/Controllers/" . $filename . ".php",
                $this->compileControllerStub($module, $filename)
            );
            (file_exists(base_path() . "/app/Modules/" . $module . "/Controllers/" . $filename . ".php") ? $this->info('Done'):$this->error('An error occurred'));

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This line exceeds maximum limit of 100 characters; contains 162 characters

            return;
        }
        $this->error("Controller already exists");
        return;
    }

    /**
     * @param $module
     */
    protected function createControllersFolder($module)
    {
        $this->createFolderInModule($module, "Controllers");

It seems like createFolderInModule() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param $moduleName
     * @param $className
     * @return mixed
     */
    protected function compileControllerStub($moduleName, $className)
    {
        $stub = __DIR__ . '/../Stubs/controller.plain.stub';

        if ($this->option('resource')) {

It seems like option() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $stub = __DIR__ . '/../Stubs/controller.stub';
        }

        return str_replace(
            ['DummyNamespace', 'DummyClass', 'DummyRootNamespaceHttp'],
            [App::getNamespace() . 'Modules\\' . $moduleName . '\Controllers', $className, App::getNamespace() .'Http'],

This line exceeds maximum limit of 100 characters; contains 120 characters

            file_get_contents($stub)
        );
    }

}