NeedleProject\LaravelRabbitMq\Command\BaseConsumerCommand

Complexity

Total Complexity

7

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

48.28%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getConsumer()	0	4	1
A	handle()	0	27	4
A	injectCliLogger()	0	15	2

<?php
namespace NeedleProject\LaravelRabbitMq\Command;

use Illuminate\Console\Command;
use Monolog\Handler\StreamHandler;
use Monolog\Logger;
use NeedleProject\LaravelRabbitMq\ConsumerInterface;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class BaseConsumerCommand
 *
 * @package NeedleProject\LaravelRabbitMq\Command
 * @author  Adrian Tilita <adrian@tilita.ro>
 */
class BaseConsumerCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'rabbitmq:consume {consumer} {--time=60} {--messages=100} {--memory=64}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Start consuming messages';

    /**
     * @param string $consumerAliasName
     * @return ConsumerInterface
     */
    protected function getConsumer(string $consumerAliasName): ConsumerInterface
    {
        return app()->makeWith(ConsumerInterface::class, [$consumerAliasName]);
    }

    /**
     * Execute the console command.
     * @return int
     */
    public function handle()
    {
        $messageCount = $this->input->getOption('messages');
        $waitTime = $this->input->getOption('time');
        $memoryLimit = $this->input->getOption('memory');
        $isVerbose = in_array(

$isVerbose is not used, you could remove the assignment.

            $this->output->getVerbosity(),
            [OutputInterface::VERBOSITY_VERBOSE, OutputInterface::VERBOSITY_VERY_VERBOSE]
        );

        /** @var ConsumerInterface $consumer */
        $consumer = $this->getConsumer($this->input->getArgument('consumer'));

It seems like $this->input->getArgument('consumer') targeting Symfony\Component\Console\Input\InputInterface::getArgument() can also be of type array<integer,string> or null; however, NeedleProject\LaravelRabbitMq\Command\BaseConsumerCommand::getConsumer() does only seem to accept string, maybe add an additional type check?

        if ($consumer instanceof LoggerAwareInterface) {
            try {
                $this->injectCliLogger($consumer);
            } catch (\Throwable $e) {
                // Do nothing, we cannot inject a STDOUT logger
            }
        }
        try {
            return $consumer->startConsuming($messageCount, $waitTime, $memoryLimit);
        } catch (\Throwable $e) {
            $consumer->stopConsuming();
            $this->output->error($e->getMessage());
            return -1;
        }
    }

    /**
     * Inject a stdout logger
     *
     * This is a "hackish" method because we handle a interface to deduce an implementation
     * that exposes certain methods.
     *
     * @todo - Find a better way to inject a CLI logger when running in verbose mode
     *
     * @param LoggerAwareInterface $consumerWithLogger
     * @throws \Exception
     */
    protected function injectCliLogger(LoggerAwareInterface $consumerWithLogger)
    {
        $stdHandler = new StreamHandler('php://stdout');
        $class = new \ReflectionClass(get_class($consumerWithLogger));
        $property = $class->getProperty('logger');
        $property->setAccessible(true);
        /** @var LoggerInterface $logger */
        $logger = $property->getValue($consumerWithLogger);
        if ($logger instanceof \Illuminate\Log\LogManager) {

The class Illuminate\Log\LogManager does not exist. Did you forget a USE statement, or did you not list all dependencies?

            /** @var Logger $logger */
            $logger = $logger->channel()->getLogger();

The method channel() does not seem to exist on object<Monolog\Logger>.

            $logger->pushHandler($stdHandler);
        }
        $property->setAccessible(false);
    }
}