Conditions | 13 |
Paths | 513 |
Total Lines | 135 |
Code Lines | 93 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
45 | public function createShipment(Parcel $parcel): stdClass |
||
46 | { |
||
47 | $writer = new XMLWriter; |
||
48 | $writer->openMemory(); |
||
49 | |||
50 | $writer->startElement('ns1:businessToClientMsgRequest'); |
||
51 | |||
52 | $writer->writeElement('partner', $this->username); |
||
53 | |||
54 | $writer->startElement('interchange'); |
||
55 | $writer->writeAttribute('msg_type', 'elsinfov1'); |
||
56 | |||
57 | $writer->startElement('header'); |
||
58 | $writer->writeAttribute('file_id', date("YmdHms")); |
||
59 | $writer->writeAttribute('sender_cd', $this->username); |
||
60 | $writer->endElement(); |
||
61 | |||
62 | $writer->startElement('item_list'); |
||
63 | |||
64 | $writer->startElement('item'); |
||
65 | $receiver = $parcel->getReceiver(); |
||
66 | |||
67 | $hasPickupPoint = $receiver->getPickupPoint() instanceof PickupPoint; |
||
68 | $pickupPoint = $receiver->getPickupPoint(); |
||
69 | |||
70 | if ($hasPickupPoint) { |
||
71 | if ($pickupPoint->isPostOffice()) { |
||
72 | $deliveryServiceCode = Service::POST_OFFICE(); |
||
73 | } else if ($pickupPoint->isTerminal()) { |
||
74 | $deliveryServiceCode = Service::TERMINAL(); |
||
75 | } else { |
||
76 | throw new \RuntimeException('Wrong PickupPoint provided'); |
||
77 | } |
||
78 | } else { |
||
79 | $deliveryServiceCode = in_array($receiver->getCountryCode(), ['LT', 'LV']) ? Service::COURIER_LT_LV() : Service::COURIER(); |
||
80 | } |
||
81 | |||
82 | $writer->writeAttribute('service', $deliveryServiceCode->getValue()); |
||
83 | |||
84 | if ($parcel->hasServices()) { |
||
85 | $writer->startElement('add_service'); |
||
86 | foreach ($parcel->getServices() as $service) { |
||
87 | $writer->startElement('option'); |
||
88 | $writer->writeAttribute('code', $service->getValue()); |
||
89 | $writer->endElement(); |
||
90 | } |
||
91 | $writer->endElement(); |
||
92 | } |
||
93 | |||
94 | $writer->startElement('measures'); |
||
95 | $writer->writeAttribute('weight', $parcel->getWeight()); |
||
96 | $writer->endElement(); |
||
97 | |||
98 | if ($parcel->getCodAmount()) { |
||
99 | $writer->startElement('monetary_values'); |
||
100 | |||
101 | $writer->startElement('values'); |
||
102 | $writer->writeAttribute('code', 'item_value'); |
||
103 | $writer->writeAttribute('amount', $parcel->getCodAmount()); |
||
104 | $writer->endElement(); |
||
105 | |||
106 | $writer->endElement(); |
||
107 | |||
108 | $writer->writeElement('account', $parcel->getBankAccount()); |
||
109 | } |
||
110 | |||
111 | if ($parcel->hasComment()) { |
||
112 | $writer->writeElement('comment', $parcel->getComment()); |
||
113 | } |
||
114 | |||
115 | $writer->writeElement('partnerId', $parcel->getPartnerId()); |
||
116 | |||
117 | $writer->startElement('receiverAddressee'); |
||
118 | $writer->writeElement('person_name', $receiver->getName()); |
||
119 | $writer->writeElement('mobile', $receiver->getPhone()); |
||
120 | if ($receiver->hasEmail()) { |
||
121 | $writer->writeElement('email', $receiver->getEmail()); |
||
122 | } |
||
123 | |||
124 | $writer->startElement('address'); |
||
125 | |||
126 | if ($hasPickupPoint) { |
||
127 | $writer->writeAttribute('offloadPostcode', $pickupPoint->getIdentifier()); |
||
128 | } else { |
||
129 | $writer->writeAttribute('postcode', $receiver->getPostCode()); |
||
130 | $writer->writeAttribute('deliverypoint', $receiver->getCity()); |
||
131 | $writer->writeAttribute('street', $receiver->getStreet()); |
||
132 | } |
||
133 | |||
134 | $writer->writeAttribute('country', $receiver->getCountryCode()); |
||
135 | $writer->endElement(); |
||
136 | |||
137 | $writer->endElement(); |
||
138 | |||
139 | $writer->startElement('returnAddressee'); |
||
140 | $returnAddress = $parcel->getReturnee(); |
||
141 | $writer->writeElement('person_name', $returnAddress->getName()); |
||
142 | $writer->writeElement('phone', $returnAddress->getPhone()); |
||
143 | if ($returnAddress->hasEmail()) { |
||
144 | $writer->writeElement('email', $returnAddress->getEmail()); |
||
145 | } |
||
146 | |||
147 | $writer->startElement('address'); |
||
148 | $writer->writeAttribute('postcode', $returnAddress->getPostCode()); |
||
149 | $writer->writeAttribute('deliverypoint', $returnAddress->getCity()); |
||
150 | $writer->writeAttribute('street', $returnAddress->getStreet()); |
||
151 | $writer->writeAttribute('country', $returnAddress->getCountryCode()); |
||
152 | $writer->endElement(); |
||
153 | $writer->endElement(); |
||
154 | |||
155 | $writer->startElement('onloadAddressee'); |
||
156 | $sender = $parcel->getSender(); |
||
157 | $writer->writeElement('person_name', $sender->getName()); |
||
158 | $writer->writeElement('phone', $sender->getPhone()); |
||
159 | if ($sender->hasEmail()) { |
||
160 | $writer->writeElement('email', $sender->getEmail()); |
||
161 | } |
||
162 | |||
163 | $writer->startElement('address'); |
||
164 | $writer->writeAttribute('postcode', $sender->getPostCode()); |
||
165 | $writer->writeAttribute('deliverypoint', $sender->getCity()); |
||
166 | $writer->writeAttribute('street', $sender->getStreet()); |
||
167 | $writer->writeAttribute('country', $sender->getCountryCode()); |
||
168 | $writer->endElement(); |
||
169 | $writer->endElement(); |
||
170 | |||
171 | $writer->endElement(); |
||
172 | |||
173 | $writer->endElement(); |
||
174 | |||
175 | $writer->endElement(); |
||
176 | $writer->endElement(); |
||
177 | |||
178 | return $this->getSoapClient()->businessToClientMsg( |
||
179 | new SoapVar($writer->outputMemory(), XSD_ANYXML) |
||
180 | ); |
||
296 |