neayi / insights

app/Http/Controllers/Auth/LoginController.php

<?php

namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Controller;
use App\Providers\RouteServiceProvider;
use App\Src\UseCases\Domain\Auth\LogUserFromSocialNetwork;
use Illuminate\Foundation\Auth\AuthenticatesUsers;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Illuminate\Support\Facades\Auth;
use Laravel\Socialite\Facades\Socialite;

class LoginController extends Controller
{
    use AuthenticatesUsers;

The trait Illuminate\Foundation\Auth\AuthenticatesUsers requires some properties which are not provided by App\Http\Controllers\Auth\LoginController: $maxAttempts, $decayMinutes

    protected $redirectTo = 'profile';

    public function __construct()
    {
        $this->middleware('guest')->except('logout');
    }

    public function showLoginForm(Request $request)
    {
        if($request->session()->has('should_attach_to_organization')) {
            session()->reflash();
        }

        if($request->has('wiki_callback')){
            session()->flash('wiki_callback', $request->input('wiki_callback'));
            session()->flash('wiki_token', $request->input('wiki_token'));
        }
        return view('public.auth.login');
    }

    public function logout(Request $request)
    {
        if($request->session()->has('should_attach_to_organization')) {
            $shouldAttach = $request->session()->get('should_attach_to_organization');
            $shouldAttachToken = $request->session()->get('should_attach_to_organization_token');
            $linkToRedirect = $request->session()->get('should_attach_to_organization_redirect');
            $userToRegister = $request->session()->get('user_to_register');
        }
        $this->guard()->logout();

        $request->session()->invalidate();

        $request->session()->regenerateToken();

        if(isset($shouldAttach)){
            $request->session()->flash('should_attach_to_organization', $shouldAttach);
            $request->session()->flash('should_attach_to_organization_token', $shouldAttachToken);

The variable $shouldAttachToken does not seem to be defined for all execution paths leading up to this point.

            $request->session()->flash('should_attach_to_organization_redirect', $linkToRedirect);

The variable $linkToRedirect does not seem to be defined for all execution paths leading up to this point.

            $request->session()->flash('user_to_register', $userToRegister);

The variable $userToRegister does not seem to be defined for all execution paths leading up to this point.

        }
        if ($response = $this->loggedOut($request)) {
            return $response;
        }

        return $request->wantsJson()
            ? new Response('', 204)
            : redirect('/');
    }

    protected function loggedOut(Request $request)
    {
        $request->session()->reflash();
        if($request->session()->has('should_attach_to_organization')){
            $linkToRedirect = $request->session()->get('should_attach_to_organization_redirect');
            return $request->wantsJson()
                ? new Response('', 204)
                : redirect($linkToRedirect);
        }
    }

    protected function authenticated(Request $request, $user)
    {
        if($user->context_id === null){
            return redirect()->route('wizard.profile');
        }

        if($request->session()->has('sso')){
            if(!$user->hasVerifiedEmail()){
                return redirect()->route('verification.notice');
            }
            $sso = $request->session()->get('sso');
            $sig = $request->session()->get('sig');
            return redirect('discourse/sso?sso='.$sso.'&sig='.$sig);
        }

        if($request->session()->has('wiki_callback')){
            $user->wiki_token = $request->session()->get('wiki_token');
            $user->save();
            $callback = urldecode($request->session()->get('wiki_callback'));

It seems like $request->session()->get('wiki_callback') can also be of type null; however, parameter $string of urldecode() does only seem to accept string, maybe add an additional type check?

            if(!$user->hasVerifiedEmail()){
                return redirect()->route('verification.notice');
            }
            return redirect($callback);
        }

        if($request->session()->has('should_attach_to_organization') && $request->session()->get('should_attach_to_organization') !== null){
            $token = $request->session()->get('should_attach_to_organization_token');
            $link = route('organization.invite.show').'?&token='.$token;
            return $request->wantsJson()
                ? new Response('', 204)
                : redirect($link);
        }
        return redirect()->route('show.profile');
    }

    public function redirectToProvider(string $provider)
    {
        if($provider === 'twitter'){
            config(['services.'.$provider.'.redirect' => env(strtoupper($provider).'_CALLBACK_LOGIN')]);
            return Socialite::driver($provider)->redirect();
        }

        config(['services.'.$provider.'.redirect' => env(strtoupper($provider).'_CALLBACK_LOGIN')]);
        return Socialite::driver($provider)->redirectUrl(config('services.'.$provider.'.redirect'))->redirect();

The method redirectUrl() does not exist on Laravel\Socialite\Contracts\Provider. Did you maybe mean redirect()?

    }

    public function handleProviderCallback(string $provider, LogUserFromSocialNetwork $logUserFromSocialNetwork)
    {
        config(['services.'.$provider.'.redirect' => env(strtoupper($provider).'_CALLBACK_LOGIN')]);
        $logUserFromSocialNetwork->log($provider);
        return $this->authenticated(request(), Auth::user());
    }
}