neayi / insights

app/Console/Commands/SyncUsersDiscourse.php

Spacing +11 added lines, -11 removed lines

@@ -38,8 +38,8 @@ 
             ->where('lastname', '<>', '')
             ->whereNotNull('email_verified_at')
             ->whereNull('sync_at_discourse')
-            ->chunkById(50, function ($items) use ($clients) {
-                foreach($items as $user) {
+            ->chunkById(50, function($items) use ($clients) {
+                foreach ($items as $user) {
                     $this->processOneUser($clients, $user);
                 }
             });
@@ -60,13 +60,13 @@ 
             $this->updateUserDetailsOnDiscourse($user);
             $user->sync_at_discourse = (new \DateTime())->format('Y-m-d H:i:s');
             $user->save();
-        } catch (\Throwable $e){
+        } catch (\Throwable $e) {
             if ($e->getCode() === 429) {
                 // Too many requests - just sleeping
                 $this->error('Too many requests - restarting in a minute....');
                 sleep(60);
             } else {
-                $message = 'Discourse sync failed for user : ' . $user->uuid . ' [' . $e->getCode() . '] ' . $e->getMessage();
+                $message = 'Discourse sync failed for user : '.$user->uuid.' ['.$e->getCode().'] '.$e->getMessage();
                 $this->error($message);
                 \Sentry\captureException($e);
             }
@@ -82,7 +82,7 @@ 
         $username = $this->formatUsername($user, $increment);
 
         $result = $this->forumApiClient->createUser($username, $user);
-        if($result['success'] === false){
+        if ($result['success'] === false) {
             if (!empty($result['errors']['email'])) {
                 return $this->updateUsernameFromDiscourse($user);
             }
@@ -121,7 +121,7 @@ 
             throw $th;
         }
 
-        if(empty($result['user'])){
+        if (empty($result['user'])) {
             throw new \Exception('Duplicate email not corresponding to existing user');
         }
         $user->discourse_id = $result['user']['id'];
@@ -145,7 +145,7 @@ 
     {
         $result = $this->forumApiClient->getUserByEmail($user->email);
 
-        if(empty($result[0]['email']) || strtolower($result[0]['email']) != strtolower($user->email)){
+        if (empty($result[0]['email']) || strtolower($result[0]['email']) != strtolower($user->email)) {
             throw new \Exception('Duplicate email not corresponding to existing user');
         }
 
@@ -162,7 +162,7 @@ 
     {
         try {
             $this->forumApiClient->updateEmail($user->discourse_username, $user->email);
-        }catch (\Throwable $e){
+        } catch (\Throwable $e) {
             $this->error('User email not updated on discourse with id : '.$user->discourse_username);
         }
 
@@ -180,7 +180,7 @@ 
 
         $result = $this->forumApiClient->updateUser($user, $newBio);
 
-        if($result['success'] === false){
+        if ($result['success'] === false) {
             $this->error('Not Updating bio : '.$result['message']);
             throw new \Exception($result['message']);
         }
@@ -198,11 +198,11 @@ 
      */
     public function formatUsername(User $user, int $increment): string
     {
-        $username = trim(substr((string)Str::of($user->fullname)->slug('.'), 0, 20), '.');
+        $username = trim(substr((string) Str::of($user->fullname)->slug('.'), 0, 20), '.');
         if (empty($username)) {
             throw new \Exception("Empty username", 55);
         }
 
-        return !empty($increment) ? $username . $increment : $username;
+        return !empty($increment) ? $username.$increment : $username;
     }
 }

app/Console/Commands/SyncDryPagesFromWiki.php

Spacing +3 added lines, -3 removed lines

@@ -27,16 +27,16 @@
             PageModel::query()
                 ->where('dry', true)
                 ->where('wiki', $wikiCode)
-                ->chunkById(50, function ($items, $count) use($client){
+                ->chunkById(50, function($items, $count) use($client){
                     $this->info(($count*50).' Pages');
                     $pages = $items->pluck('page_id')->toArray();
                     $content = $client->searchPagesById($pages);
                     $wikiPages = $content['query']['pages'];
 
-                    foreach($wikiPages as $page){
+                    foreach ($wikiPages as $page) {
                         $pageModel = PageModel::query()->where('page_id', $page['pageid'])->first();
 
-                        if(!isset($pageModel)){
+                        if (!isset($pageModel)) {
                             continue;
                         }
 

app/Console/Commands/ImportDepartmentFromWiki.php

Spacing +7 added lines, -7 removed lines

@@ -55,7 +55,7 @@ 
 
     private function handleDepartments($departments)
     {
-        foreach($departments as $department){
+        foreach ($departments as $department) {
             $key = key($department);
             $department = last($department)['printouts'];
 
@@ -65,7 +65,7 @@ 
             $iconUrlApi = str_replace(':file:', last($department['A une icone'])['fulltext'], $this->queryPictures);
 
             $characteristicModel = CharacteristicsModel::query()->where('code', $number)->first();
-            if(!isset($characteristicModel)){
+            if (!isset($characteristicModel)) {
                 $characteristicModel = new CharacteristicsModel();
             }
 
@@ -85,7 +85,7 @@ 
             $response = $this->httpClient->get(config('wiki.api_uri').$iconUrlApi);
             $content = json_decode($response->getBody()->getContents(), true);
             $picturesInfo = $content['query']['pages'];
-            foreach($picturesInfo as $picture) {
+            foreach ($picturesInfo as $picture) {
                 if (isset($picture['imageinfo']) && isset(last($picture['imageinfo'])['url'])) {
                     $characteristicModel->page_id = $picture['pageid'];
                     try {
@@ -96,13 +96,13 @@ 
 
                         $response = $this->httpClient->get($imageURL);
                         $content = $response->getBody()->getContents();
-                        $path = 'public/characteristics/' . $uuid . '.png';
-                        Storage::put('public/characteristics/' . $uuid . '.png', $content);
-                    }catch (ClientException $e){
+                        $path = 'public/characteristics/'.$uuid.'.png';
+                        Storage::put('public/characteristics/'.$uuid.'.png', $content);
+                    } catch (ClientException $e) {
                         $this->info('No icon for department : '.$number);
                         $path = '';
                     }
-                }else{
+                } else {
                     $this->info('No icon for department : '.$number);
                     $path = '';
                 }

app/Listeners/AddEmailToNewsletter.php

Spacing +2 added lines, -2 removed lines

@@ -28,12 +28,12 @@
         try {
             $this->sendingBlueService->addEmailToList($verified->user->email, $verified->user->lastname, $verified->user->firstname);
         } catch (\Throwable $e) {
-            Log::critical('Error when adding email to sending blue : ' . $verified->user->email);
+            Log::critical('Error when adding email to sending blue : '.$verified->user->email);
         }
         try {
             $this->mailerLiteService->addEmailToList($verified->user->email);
         } catch (\Exception $e) {
-            Log::critical('Error when adding email to mailerlite : ' . $verified->user->email);
+            Log::critical('Error when adding email to mailerlite : '.$verified->user->email);
         }
     }
 }

app/Listeners/SetUserToSyncOnDiscourse.php

Spacing +2 added lines, -2 removed lines

@@ -13,13 +13,13 @@
     {
         try {
             $user = $verified->user;
-            if(empty($user->firstname) || empty($user->lastname)){
+            if (empty($user->firstname) || empty($user->lastname)) {
                 return;
             }
 
             $user->sync_at_discourse = null;
             $user->save();
-        }catch (\Throwable $e){
+        } catch (\Throwable $e) {
             Log::emergency('Error when sync asking for user : '.$user->id);
             \Sentry\captureException($e);
         }

app/MailerLiteService.php

Spacing +2 added lines, -2 removed lines

@@ -30,9 +30,9 @@
                 'status' => self::STATUS
             ]);
 
-            Log::info('Email added to mailerlite : ' . $email);
+            Log::info('Email added to mailerlite : '.$email);
         } catch (\Exception $e) {
-            Log::critical('Error when adding email to mailerlite: ' . $email . ' - ' . $e->getMessage());
+            Log::critical('Error when adding email to mailerlite: '.$email.' - '.$e->getMessage());
             captureException($e);
         }
     }

app/Http/Middleware/Authenticate.php

Spacing +2 added lines, -2 removed lines

@@ -14,14 +14,14 @@
      */
     protected function redirectTo($request)
     {
-        if($request->has('sso')){
+        if ($request->has('sso')) {
             list(,$wikiCode,) = explode('/', $request->getRequestUri());
             session()->put('sso', $request->get('sso'));
             session()->put('sig', $request->get('sig'));
             session()->put('wikiCode', strtolower($wikiCode));
         }
 
-        if (! $request->expectsJson()) {
+        if (!$request->expectsJson()) {
             return route('login');
         }
     }

app/Http/Controllers/Auth/RegisterController.php

Spacing +10 added lines, -10 removed lines

@@ -30,14 +30,14 @@ 
     {
         $email = $firstname = $lastname = '';
 
-        if($request->session()->has('user_to_register')){
+        if ($request->session()->has('user_to_register')) {
             $user = $request->session()->get('user_to_register');
             $email = $user['email'];
             $firstname = $user['firstname'];
             $lastname = $user['lastname'];
         }
 
-        if($request->has('wiki_callback')){
+        if ($request->has('wiki_callback')) {
             session()->flash('wiki_callback', $request->input('wiki_callback'));
             session()->flash('wiki_token', $request->input('wiki_token'));
         }
@@ -85,8 +85,8 @@ 
 
         $user = Auth::user();
 
-        if($user->context_id === null) {
-            if($request->session()->has('wiki_token')) {
+        if ($user->context_id === null) {
+            if ($request->session()->has('wiki_token')) {
                 $user->wiki_token = $request->session()->get('wiki_token');
                 $user->save();
             }
@@ -97,7 +97,7 @@ 
         /**
          * should be deleted dead code ?
          */
-        if($request->session()->has('wiki_callback')){
+        if ($request->session()->has('wiki_callback')) {
             $user->wiki_token = $request->session()->get('wiki_token');
             $user->save();
             $callback = urldecode($request->session()->get('wiki_callback'));
@@ -109,11 +109,11 @@ 
 
     public function redirectToProvider(string $provider)
     {
-        if(request()->session()->has('wiki_token')) {
+        if (request()->session()->has('wiki_token')) {
             session()->reflash();
         }
         config(['services.'.$provider.'.redirect' => env(strtoupper($provider).'_CALLBACK')]);
-        if($provider === 'twitter'){
+        if ($provider === 'twitter') {
             return Socialite::driver($provider)->redirect();
         }
         return Socialite::driver($provider)->redirectUrl(config('services.'.$provider.'.redirect'))->redirect();
@@ -130,14 +130,14 @@ 
             $user->save();
             $this->guard()->login($user);
 
-            if($user->context_id !== null){
+            if ($user->context_id !== null) {
                 $user->wiki_token = $request->session()->get('wiki_token');
                 $user->save();
                 $callback = urldecode($request->session()->get('wiki_callback'));
                 return redirect($callback);
             }
 
-            if(session()->has('sso')){
+            if (session()->has('sso')) {
                 $sso = session()->get('sso');
                 $sig = session()->get('sig');
                 $wikiCode = session()->get('wikiCode');
@@ -146,7 +146,7 @@ 
             }
 
             return redirect()->route('wizard.profile');
-        }catch (ValidationException $e) {
+        } catch (ValidationException $e) {
             $attributes = $e->validator->attributes();
             $attributes['provider'] = $provider;
             return redirect()->route('register-social-network')

app/Http/Controllers/Auth/LoginController.php

Spacing +8 added lines, -8 removed lines

@@ -25,7 +25,7 @@ 
 
     public function showLoginForm(Request $request)
     {
-        if($request->has('wiki_callback')){
+        if ($request->has('wiki_callback')) {
             session()->flash('wiki_callback', $request->input('wiki_callback'));
             session()->flash('wiki_token', $request->input('wiki_token'));
         }
@@ -52,7 +52,7 @@ 
     protected function loggedOut(Request $request)
     {
         $request->session()->reflash();
-        if($request->session()->has('should_attach_to_organization')){
+        if ($request->session()->has('should_attach_to_organization')) {
             $linkToRedirect = $request->session()->get('should_attach_to_organization_redirect');
             return $request->wantsJson()
                 ? new Response('', 204)
@@ -68,12 +68,12 @@ 
             $user->save();
         }
 
-        if($user->context_id === null){
+        if ($user->context_id === null) {
             return redirect()->route('wizard.profile');
         }
 
-        if($request->session()->has('sso')){
-            if(!$user->hasVerifiedEmail()){
+        if ($request->session()->has('sso')) {
+            if (!$user->hasVerifiedEmail()) {
                 $request->session()->flash('from_forum', true);
                 return redirect()->route('email.verify');
             }
@@ -83,11 +83,11 @@ 
             return redirect($wikiCode.'/neayi/discourse/sso?sso='.$sso.'&sig='.$sig);
         }
 
-        if($request->session()->has('wiki_callback')){
+        if ($request->session()->has('wiki_callback')) {
             $user->wiki_token = $request->session()->get('wiki_token');
             $user->save();
             $callback = urldecode($request->session()->get('wiki_callback'));
-            if(!$user->hasVerifiedEmail()){
+            if (!$user->hasVerifiedEmail()) {
                 return redirect()->route('verification.notice');
             }
             return redirect($callback);
@@ -98,7 +98,7 @@ 
 
     public function redirectToProvider(string $provider)
     {
-        if($provider === 'twitter'){
+        if ($provider === 'twitter') {
             config(['services.'.$provider.'.redirect' => env(strtoupper($provider).'_CALLBACK_LOGIN')]);
             return Socialite::driver($provider)->redirect();
         }