Test Failed
Pull Request — master (#78)
by guillaume
08:09
created
app/Console/Commands/ImportDepartmentFromWiki.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 
51 51
     private function handleDepartments($departments)
52 52
     {
53
-        foreach($departments as $key => $department){
53
+        foreach ($departments as $key => $department) {
54 54
             $department = last($department)['printouts'];
55 55
 
56 56
             $climat = last($department['A un climat'])['fulltext'];
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             $iconUrlApi = str_replace(':file:', last($department['A une icone'])['fulltext'], $this->queryPictures);
60 60
 
61 61
             $characteristicModel = CharacteristicsModel::query()->where('code', $number)->first();
62
-            if(!isset($characteristicModel)){
62
+            if (!isset($characteristicModel)) {
63 63
                 $characteristicModel = new CharacteristicsModel();
64 64
             }
65 65
 
@@ -79,19 +79,19 @@  discard block
 block discarded – undo
79 79
             $response = $this->httpClient->get(config('wiki.api_uri').$iconUrlApi);
80 80
             $content = json_decode($response->getBody()->getContents(), true);
81 81
             $picturesInfo = $content['query']['pages'];
82
-            foreach($picturesInfo as $picture) {
82
+            foreach ($picturesInfo as $picture) {
83 83
                 if (isset($picture['imageinfo']) && isset(last($picture['imageinfo'])['url'])) {
84 84
                     $characteristicModel->page_id = $picture['pageid'];
85 85
                     try {
86 86
                         $response = $this->httpClient->get(last($picture['imageinfo'])['url']);
87 87
                         $content = $response->getBody()->getContents();
88
-                        $path = 'public/characteristics/' . $uuid . '.png';
89
-                        Storage::put('public/characteristics/' . $uuid . '.png', $content);
90
-                    }catch (ClientException $e){
88
+                        $path = 'public/characteristics/'.$uuid.'.png';
89
+                        Storage::put('public/characteristics/'.$uuid.'.png', $content);
90
+                    } catch (ClientException $e) {
91 91
                         $this->info('No icon for department : '.$number);
92 92
                         $path = '';
93 93
                     }
94
-                }else{
94
+                } else {
95 95
                     $this->info('No icon for department : '.$number);
96 96
                     $path = '';
97 97
                 }
Please login to merge, or discard this patch.
app/Console/Commands/ImportPagesWithIconAndTypeFromWiki.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
         $this->handlePages($pages);
40 40
         $continue = $content['query-continue-offset'] ?? null;
41 41
 
42
-        while($continue !== null && $continue !== ''){
42
+        while ($continue !== null && $continue !== '') {
43 43
             $this->info($continue);
44 44
 
45 45
             $pagesApiUri = config('wiki.api_uri').$queryPages.'|offset='.$continue;
@@ -65,23 +65,23 @@  discard block
 block discarded – undo
65 65
                 continue;
66 66
             }
67 67
 
68
-            if($icon !== false) {
68
+            if ($icon !== false) {
69 69
                 $picturesApiUri = config('wiki.api_uri').$this->queryPicture.$icon['fulltext'];
70 70
 
71 71
                 $response = $this->httpClient->get($picturesApiUri);
72 72
                 $content = json_decode($response->getBody()->getContents(), true);
73 73
                 $picturesInfo = $content['query']['pages'];
74
-                foreach($picturesInfo as $picture) {
74
+                foreach ($picturesInfo as $picture) {
75 75
                     if (isset(last($picture['imageinfo'])['url'])) {
76 76
                         try {
77 77
                             $response = $this->httpClient->get(last($picture['imageinfo'])['url']);
78 78
                             $content = $response->getBody()->getContents();
79
-                            $path = 'public/pages/' . $pageModel->id . '.png';
80
-                            Storage::put('public/pages/' . $pageModel->id . '.png', $content);
81
-                        }catch (ClientException $e){
79
+                            $path = 'public/pages/'.$pageModel->id.'.png';
80
+                            Storage::put('public/pages/'.$pageModel->id.'.png', $content);
81
+                        } catch (ClientException $e) {
82 82
                             $path = '';
83 83
                         }
84
-                    }else{
84
+                    } else {
85 85
                         $path = '';
86 86
                     }
87 87
                 }
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Context/Queries/SearchCharacteristics.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,10 +17,10 @@
 block discarded – undo
17 17
 
18 18
     public function execute(string $type, string $search):array
19 19
     {
20
-        if($type === 'farming') {
20
+        if ($type === 'farming') {
21 21
             $type = 'culture';
22 22
         }
23
-        if($type === 'croppingSystem') {
23
+        if ($type === 'croppingSystem') {
24 24
             $type = 'label';
25 25
         }
26 26
         return $this->pageRepository->search($type, $search);
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Ports/PageRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 
9 9
 interface PageRepository
10 10
 {
11
-    public function get(string $pageId):?Page;
11
+    public function get(string $pageId): ?Page;
12 12
     public function getByIds(array $pagesId):array;
13 13
     public function save(Page $page);
14 14
 }
Please login to merge, or discard this patch.
app/Src/UseCases/Infra/Sql/PageRepositorySql.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
     public function get(string $pageId): ?Page
15 15
     {
16 16
         $pageModel = PageModel::where('page_id', $pageId)->first();
17
-        if(!isset($pageModel)){
17
+        if (!isset($pageModel)) {
18 18
             return null;
19 19
         }
20 20
         return new Page($pageModel->page_id, $pageModel->dry);
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
     public function save(Page $page)
35 35
     {
36 36
         $pageModel = PageModel::where('page_id', $page->pageId())->first();
37
-        if(!isset($pageModel)){
37
+        if (!isset($pageModel)) {
38 38
             $pageModel = new PageModel();
39 39
         }
40 40
         $pageModel->page_id = $page->pageId();
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
45 45
     public function search(string $type, string $search):array
46 46
     {
47 47
         $pageModel = PageModel::query()
48
-            ->where('title','LIKE', '%'.$search.'%')
48
+            ->where('title', 'LIKE', '%'.$search.'%')
49 49
             ->where('type', $type)
50 50
             ->get();
51 51
 
52
-        if(!isset($pageModel)){
52
+        if (!isset($pageModel)) {
53 53
             return [];
54 54
         }
55 55
         return $pageModel->toArray();
Please login to merge, or discard this patch.
app/Src/UseCases/Infra/Sql/CharacteristicsRepositorySql.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -32,12 +32,12 @@  discard block
 block discarded – undo
32 32
         return $list->toArray();
33 33
     }
34 34
 
35
-    public function getByPageId(int $pageId):?Characteristic
35
+    public function getByPageId(int $pageId): ?Characteristic
36 36
     {
37 37
         $c = CharacteristicsModel::query()
38 38
             ->where('page_id', $pageId)
39 39
             ->first();
40
-        if(!isset($c)){
40
+        if (!isset($c)) {
41 41
             return null;
42 42
         }
43 43
         return $c->toDomain();
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      */
51 51
     public function add(array $cs)
52 52
     {
53
-        foreach ($cs as $c){
53
+        foreach ($cs as $c) {
54 54
             $cModel = new CharacteristicsModel();
55 55
             $cModel->fill($c);
56 56
             $cModel->save();
@@ -76,14 +76,14 @@  discard block
 block discarded – undo
76 76
     public function getBy(array $conditions): ?Characteristic
77 77
     {
78 78
         $characteristicModel = CharacteristicsModel::query()
79
-            ->when(isset($conditions['type']), function ($query) use($conditions){
79
+            ->when(isset($conditions['type']), function($query) use($conditions){
80 80
                 $query->where('type', $conditions['type']);
81 81
             })
82
-            ->when(isset($conditions['title']), function ($query) use($conditions){
82
+            ->when(isset($conditions['title']), function($query) use($conditions){
83 83
                 $query->where('code', $conditions['title']);
84 84
             })
85 85
             ->first();
86
-        if(!isset($characteristicModel)){
86
+        if (!isset($characteristicModel)) {
87 87
             return null;
88 88
         }
89 89
         return $characteristicModel->toDomain();
@@ -93,13 +93,13 @@  discard block
 block discarded – undo
93 93
     {
94 94
         $characteristicModel = CharacteristicsModel::query()
95 95
             ->where('type', $type)
96
-            ->where('pretty_page_label','LIKE', '%'.$search.'%')
96
+            ->where('pretty_page_label', 'LIKE', '%'.$search.'%')
97 97
             ->get();
98 98
 
99
-        if(!isset($characteristicModel)){
99
+        if (!isset($characteristicModel)) {
100 100
             return [];
101 101
         }
102
-        foreach ($characteristicModel as $characteristic){
102
+        foreach ($characteristicModel as $characteristic) {
103 103
             $characteristics[] = $characteristic->toArray();
104 104
         }
105 105
         return $characteristics ?? [];
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Context/UseCases/CreateCharacteristic.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     public function execute(string $id, string $type, string $title)
30 30
     {
31 31
         $characteristic = $this->characteristicRepository->getBy(['title' => $title, 'type' => $type]);
32
-        if(!isset($characteristic)){
32
+        if (!isset($characteristic)) {
33 33
             $characteristic = new Characteristic($id, $type, $title, false);
34 34
             $characteristic->create();
35 35
         }
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Context/Model/Characteristic.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 
32 32
     public function create(string $icon = null)
33 33
     {
34
-        if(isset($icon)){
34
+        if (isset($icon)) {
35 35
             copy(storage_path('app/'.$icon), storage_path('app/public/characteristics/'.$this->id.'.png'));
36 36
             $this->icon = 'public/characteristics/'.$this->id.'.png';
37 37
         }
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Context/Model/Page.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,17 +34,17 @@
 block discarded – undo
34 34
         return $this->pageId;
35 35
     }
36 36
 
37
-    public function title():?string
37
+    public function title(): ?string
38 38
     {
39 39
         return $this->title;
40 40
     }
41 41
 
42
-    public function type():?string
42
+    public function type(): ?string
43 43
     {
44 44
         return $this->type;
45 45
     }
46 46
 
47
-    public function icon():?string
47
+    public function icon(): ?string
48 48
     {
49 49
         return $this->icon;
50 50
     }
Please login to merge, or discard this patch.