neayi / insights

app/Console/Commands/SyncDryPagesFromWiki.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
     {
         $httpClient = new Client();
 
-        PageModel::query()->where('dry', true)->chunkById(50, function ($items, $count) use($httpClient){
+        PageModel::query()->where('dry', true)->chunkById(50, function($items, $count) use($httpClient){
             $this->info(($count*50).' Pages');
             $pages = $items->pluck('page_id')->toArray();
             $pagesApiUri = config('wiki.api_uri').$this->queryPages.implode('|', $pages);
@@ -32,7 +32,7 @@ 
             $content = json_decode($response->getBody()->getContents(), true);
             $wikiPages = $content['query']['pages'];
 
-            foreach($wikiPages as $page){
+            foreach ($wikiPages as $page) {
                 $pageModel = PageModel::query()->where('page_id', $page['pageid'])->first();
 
                 if (!isset($page['title']))

app/Src/UseCases/Infra/Sql/ReportingCharacteristicSql.php

Spacing +8 added lines, -8 removed lines

@@ -18,12 +18,12 @@ 
             ')
             ->join('users', 'users.id', 'interactions.user_id')
             ->join('contexts', 'users.context_id', 'contexts.id')
-            ->where(function ($query) use ($type){
-                $query->when($type === 'follow', function ($query) {
+            ->where(function($query) use ($type){
+                $query->when($type === 'follow', function($query) {
                     $query->where('follow', true);
                     $query->orWhere('done', true);
                 })
-                        ->when($type === 'do', function ($query) {
+                        ->when($type === 'do', function($query) {
                             $query->where('done', true);
                         });
             })
@@ -33,7 +33,7 @@ 
             ->get();
 
         $interactionsToReturn = [];
-        foreach($interactions as $interaction){
+        foreach ($interactions as $interaction) {
             $characteristicsModel = CharacteristicsModel::query()->where('code', $interaction->department)->first();
 
             // FIXME : This test is only necessary because corsica breaks the line above. When corsica is correctly handled,
@@ -58,12 +58,12 @@ 
             ->join('contexts', 'users.context_id', 'contexts.id')
             ->join('user_characteristics', 'user_characteristics.user_id', 'users.id')
             ->join('characteristics', 'characteristics.id', 'user_characteristics.characteristic_id')
-            ->where(function ($query) use ($type){
-                $query->when($type === 'follow', function ($query) {
+            ->where(function($query) use ($type){
+                $query->when($type === 'follow', function($query) {
                     $query->where('follow', true);
                     $query->orWhere('done', true);
                 })
-                        ->when($type === 'do', function ($query) {
+                        ->when($type === 'do', function($query) {
                             $query->where('done', true);
                         });
             })
@@ -76,7 +76,7 @@ 
             ->get();
 
         $characteristicsToReturn = [];
-        foreach($characteristicsCount as $characteristicCount){
+        foreach ($characteristicsCount as $characteristicCount) {
             $characteristic = CharacteristicsModel::query()->find($characteristicCount->characteristic_id);
             $characteristic->count = $characteristicCount->count;
             $c = $characteristic->toArray();

Braces +3 added lines, -2 removed lines

@@ -38,8 +38,9 @@
 
             // FIXME : This test is only necessary because corsica breaks the line above. When corsica is correctly handled,
             // we should remove the test for emptyness.
-            if (!empty($characteristicsModel))
-                $characteristicsModel->icon = route('api.icon.serve', ['id' => $characteristicsModel->uuid]);
+            if (!empty($characteristicsModel)) {
+                            $characteristicsModel->icon = route('api.icon.serve', ['id' => $characteristicsModel->uuid]);
+            }
 
             $interaction->departmentData = $characteristicsModel;
             $interactionsToReturn[] = $interaction->toArray();

app/Src/UseCases/Domain/User.php

Spacing +10 added lines, -10 removed lines

@@ -61,14 +61,14 @@ 
         return $this->firstname.' '.$this->lastname;
     }
 
-    public function organizationId():?string
+    public function organizationId(): ?string
     {
         return $this->organizationId;
     }
 
     public function provider(string $provider, string $providerId):bool
     {
-        if(isset($this->providers[$provider]) && $this->providers[$provider] == $providerId){
+        if (isset($this->providers[$provider]) && $this->providers[$provider] == $providerId) {
             return true;
         }
         return false;
@@ -87,8 +87,8 @@ 
 
     public function create(string $passwordHashed = null, Picture $picture = null)
     {
-        if(isset($picture)) {
-            $picture->resize('app/public/users/' . $this->id);
+        if (isset($picture)) {
+            $picture->resize('app/public/users/'.$this->id);
             $this->pathPicture = $picture->relativePath();
         }
         app(UserRepository::class)->add($this, $passwordHashed);
@@ -130,20 +130,20 @@ 
         $this->email = $email;
         $this->firstname = $firstname;
         $this->lastname = $lastname;
-        if($pathPicture !== "") {
+        if ($pathPicture !== "") {
             $picture = new Picture($pathPicture);
-            $picture->resize('app/public/users/' . $this->id . '.' . $ext);
-            $this->pathPicture = 'app/public/users/' . $this->id . '.' . $ext;
+            $picture->resize('app/public/users/'.$this->id.'.'.$ext);
+            $this->pathPicture = 'app/public/users/'.$this->id.'.'.$ext;
         }
         app(UserRepository::class)->update($this);
     }
 
     public function updateAvatar(string $pathPicture, string $ext = 'jpg')
     {
-        if($pathPicture !== "") {
+        if ($pathPicture !== "") {
             $picture = new Picture($pathPicture);
-            $picture->resize('app/public/users/' . $this->id . '.' . $ext);
-            $this->pathPicture = 'app/public/users/' . $this->id . '.' . $ext;
+            $picture->resize('app/public/users/'.$this->id.'.'.$ext);
+            $this->pathPicture = 'app/public/users/'.$this->id.'.'.$ext;
         }
         app(UserRepository::class)->update($this);
         return $this->pathPicture;

app/Src/UseCases/Domain/Ports/ContextRepository.php

Spacing +2 added lines, -2 removed lines

@@ -9,8 +9,8 @@
 
 interface ContextRepository
 {
-    public function getByUser(string $userId):?Context;
+    public function getByUser(string $userId): ?Context;
     public function add(Context $context, string $userId);
     public function update(Context $context, string $userId);
-    public function getByUserDto(string $userId):?ContextDto;
+    public function getByUserDto(string $userId): ?ContextDto;
 }

app/Src/UseCases/Domain/System/GetDepartmentFromPostalCodeImpl.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
         $content = json_decode($response->getBody()->getContents(), true);
 
         $features = $content['features'];
-        if(isset($features) && !empty($features)){
+        if (isset($features) && !empty($features)) {
             $feature = $features[0];
             $coordinates = $feature['geometry']['coordinates'];
             $departmentNumber = explode(',', $feature['properties']['context'])[0];

app/Src/UseCases/Infra/Sql/InteractionPageRepositorySql.php

Indentation +1 added lines, -1 removed lines

@@ -126,7 +126,7 @@
      * @param string|null $characteristicIdCroppingSystem
      * @return Paginator
      *
-    */
+     */
     public function getFollowersPage(int $pageId, string $type = 'follow', ?string $departmentNumber = null, ?string $characteristicId = null, ?string $characteristicIdCroppingSystem = null): Paginator
     {
         return  InteractionModel::query()

Spacing +15 added lines, -15 removed lines

@@ -25,7 +25,7 @@ 
             ->where('page_id', $interaction->pageId())
             ->first();
 
-        if($interactionModel === null) {
+        if ($interactionModel === null) {
             $interactionModel = new InteractionModel();
             $interactionModel->{$canInteract->key()} = isset($user->id) ? $user->id : $canInteract->identifier();
         }
@@ -37,7 +37,7 @@ 
 
     public function getByInteractUser(CanInteract $canInteract, int $pageId): ?Interaction
     {
-        if($canInteract->key() == 'user_id') {
+        if ($canInteract->key() == 'user_id') {
             $user = User::query()->where('uuid', $canInteract->identifier())->first();
         }
 
@@ -46,7 +46,7 @@ 
             ->where('page_id', $pageId)
             ->first();
 
-        if(!isset($interactionModel)){
+        if (!isset($interactionModel)) {
             return null;
         }
 
@@ -82,9 +82,9 @@ 
             ->orderBy('updated_at', 'desc')
             ->get();
 
-        foreach($interactionsModel as $interaction) {
+        foreach ($interactionsModel as $interaction) {
             $page = PageModel::query()->where('page_id', $interaction->page_id)->first();
-            if(!isset($page)){
+            if (!isset($page)) {
                 continue;
             }
             $applause = InteractionModel::query()->where('page_id', $interaction->page_id)->where('applause', true)->count();
@@ -107,7 +107,7 @@ 
             ->where('user_id', $user->id)
             ->where('done', true)
             ->get();
-        foreach ($records as $record){
+        foreach ($records as $record) {
             $practises[] = new PractiseVo(
                 $record->page_id,
                 $record->page->title ?? '',
@@ -131,18 +131,18 @@ 
     {
         return  InteractionModel::query()
             ->with('user.context')
-            ->where(function ($query) use ($type){
-                $query->when($type === 'follow', function ($query) {
+            ->where(function($query) use ($type){
+                $query->when($type === 'follow', function($query) {
                     $query->where('follow', true);
                     $query->orWhere('done', true);
                 })
-                ->when($type === 'do', function ($query) {
+                ->when($type === 'do', function($query) {
                     $query->where('done', true);
                 });
             })
-            ->when($characteristicId !== null, function ($query) use($characteristicId) {
+            ->when($characteristicId !== null, function($query) use($characteristicId) {
                 $characteristic = CharacteristicsModel::query()->where('uuid', $characteristicId)->first();
-                if(!isset($characteristic)){
+                if (!isset($characteristic)) {
                     return;
                 }
                 $query->whereRaw(
@@ -150,9 +150,9 @@ 
                     $characteristic->id
                 );
             })
-            ->when($characteristicIdCroppingSystem !== null, function ($query) use($characteristicIdCroppingSystem) {
+            ->when($characteristicIdCroppingSystem !== null, function($query) use($characteristicIdCroppingSystem) {
                 $characteristic = CharacteristicsModel::query()->where('uuid', $characteristicIdCroppingSystem)->first();
-                if(!isset($characteristic)){
+                if (!isset($characteristic)) {
                     return;
                 }
                 $query->whereRaw(
@@ -160,7 +160,7 @@ 
                     $characteristic->id
                 );
             })
-            ->when($departmentNumber !== null, function ($query) use($departmentNumber) {
+            ->when($departmentNumber !== null, function($query) use($departmentNumber) {
                 $query
                     ->join('users', 'users.id', 'interactions.user_id')
                     ->join('contexts', 'users.context_id', 'contexts.id')
@@ -170,7 +170,7 @@ 
             ->whereNotNull('interactions.user_id')
             ->orderBy('interactions.updated_at', 'desc')
             ->paginate()
-            ->through(function ($item){
+            ->through(function($item) {
                 return $item->user->context->toDto($item->user->uuid, $item->start_done_at ? $item->start_done_at->format('Y-m-d') : $item->done);
             })
         ;

app/Src/UseCases/Infra/Sql/Model/ContextModel.php

Spacing +2 added lines, -2 removed lines

@@ -25,12 +25,12 @@
 
     public function toDto(?string $userUid = null, $hasDone = false):ContextDto
     {
-        $characteristics = $this->user->characteristics()->get()->transform(function(CharacteristicsModel $item){
+        $characteristics = $this->user->characteristics()->get()->transform(function(CharacteristicsModel $item) {
             return $item->toDto();
         });
         $characteristicDepartment = CharacteristicsModel::query()->where('code', $this->department_number)->first();
 
-        if(isset($characteristicDepartment)){
+        if (isset($characteristicDepartment)) {
             $characteristics->push($characteristicDepartment->toDto());
         }
 

app/Src/UseCases/Domain/Context/Dto/ContextDto.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
         $this->postalCode = $postalCode;
         $this->department = $departmentNumber;
         $this->characteristics = $characteristics;
-        foreach($this->characteristics as $characteristic){
+        foreach ($this->characteristics as $characteristic) {
             $this->characteristicsByType[$characteristic->type()][] = $characteristic;
         }
         $this->description = $description;

app/Src/UseCases/Infra/Sql/CharacteristicsRepositorySql.php

Spacing +8 added lines, -8 removed lines

@@ -30,12 +30,12 @@ 
         return $list->toArray();
     }
 
-    public function getByPageId(int $pageId):?Characteristic
+    public function getByPageId(int $pageId): ?Characteristic
     {
         $c = CharacteristicsModel::query()
             ->where('page_id', $pageId)
             ->first();
-        if(!isset($c)){
+        if (!isset($c)) {
             return null;
         }
         return $c->toDomain();
@@ -61,14 +61,14 @@ 
     public function getBy(array $conditions): ?Characteristic
     {
         $characteristicModel = CharacteristicsModel::query()
-            ->when(isset($conditions['type']), function ($query) use($conditions){
+            ->when(isset($conditions['type']), function($query) use($conditions){
                 $query->where('type', $conditions['type']);
             })
-            ->when(isset($conditions['title']), function ($query) use($conditions){
+            ->when(isset($conditions['title']), function($query) use($conditions){
                 $query->where('code', $conditions['title']);
             })
             ->first();
-        if(!isset($characteristicModel)){
+        if (!isset($characteristicModel)) {
             return null;
         }
         return $characteristicModel->toDomain();
@@ -78,13 +78,13 @@ 
     {
         $characteristicModel = CharacteristicsModel::query()
             ->where('type', $type)
-            ->where('pretty_page_label','LIKE', '%'.$search.'%')
+            ->where('pretty_page_label', 'LIKE', '%'.$search.'%')
             ->get();
 
-        if(!isset($characteristicModel)){
+        if (!isset($characteristicModel)) {
             return [];
         }
-        foreach ($characteristicModel as $characteristic){
+        foreach ($characteristicModel as $characteristic) {
             $characteristics[] = $characteristic->toArray();
         }
         return $characteristics ?? [];