Completed
Pull Request — master (#78)
by guillaume
06:47
created
app/Src/UseCases/Domain/Context/Dto/PractiseVo.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
         $this->doneAt = $doneAt;
18 18
     }
19 19
 
20
-    public function doneAt():?\DateTime
20
+    public function doneAt(): ?\DateTime
21 21
     {
22 22
         return $this->doneAt;
23 23
     }
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Context/Dto/CharacteristicDto.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     public $type;
13 13
     public $icon;
14 14
 
15
-    public function __construct(string $uuid,  string $label, string $type, ?string $icon, $prettyLabel)
15
+    public function __construct(string $uuid, string $label, string $type, ?string $icon, $prettyLabel)
16 16
     {
17 17
         $this->uuid = $uuid;
18 18
         $this->label = $label;
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Context/Queries/GetLastWikiUserComments.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $userData = $user->toArray();
29 29
         $username = ucfirst($userData['firstname']).'_'.ucfirst($userData['lastname']);
30 30
         $comments = Cache::get("comments_".$userId);
31
-        if(isset($comments)){
31
+        if (isset($comments)) {
32 32
             return json_decode($comments, true);
33 33
         }
34 34
 
@@ -37,13 +37,13 @@  discard block
 block discarded – undo
37 37
         $comments = $content['query']['usercontribs'];
38 38
 
39 39
         $commentsToRetrieved = [];
40
-        foreach($comments as $comment){
41
-            if(!isset($commentsToRetrieved[$comment['pageid']])) {
40
+        foreach ($comments as $comment) {
41
+            if (!isset($commentsToRetrieved[$comment['pageid']])) {
42 42
                 $commentsToRetrieved[$comment['pageid']] = $comment;
43 43
             }
44 44
         }
45 45
 
46
-        foreach($commentsToRetrieved as $pageId => $commentToRetrieved){
46
+        foreach ($commentsToRetrieved as $pageId => $commentToRetrieved) {
47 47
             $response = $this->httpClient->get(config('wiki.api_uri').$this->commentEndPoint.$pageId);
48 48
             $content = json_decode($response->getBody()->getContents(), true);
49 49
             $commentsToRetrieved[$pageId] = array_merge($commentsToRetrieved[$pageId], $content['csquerycomment']);
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Context/Queries/GetUserPractises.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     {
20 20
         $practisesToReturn = [];
21 21
         $practises = $this->interactionsRepository->getDoneByUser($userId);
22
-        foreach ($practises as $practise){
22
+        foreach ($practises as $practise) {
23 23
             $year = $practise->doneAt()->format('Y');
24 24
             $practisesToReturn[$year][] = $practise->toArray();
25 25
         }
Please login to merge, or discard this patch.
app/Src/UseCases/Domain/Ports/CharacteristicsRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,6 +11,6 @@
 block discarded – undo
11 11
     public function getByType(string $type, bool $isMain):array;
12 12
     public function getAllByType(string $type):array;
13 13
     public function save(Characteristic $c);
14
-    public function getBy(array $conditions):?Characteristic;
14
+    public function getBy(array $conditions): ?Characteristic;
15 15
     public function search(string $type, string $search):array;
16 16
 }
Please login to merge, or discard this patch.
app/Src/UseCases/Infra/Sql/CharacteristicsRepositorySql.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
      */
40 40
     public function add(array $cs)
41 41
     {
42
-        foreach ($cs as $c){
42
+        foreach ($cs as $c) {
43 43
             $cModel = new CharacteristicsModel();
44 44
             $cModel->fill($c);
45 45
             $cModel->save();
@@ -64,13 +64,13 @@  discard block
 block discarded – undo
64 64
     public function getBy(array $conditions): ?Characteristic
65 65
     {
66 66
         $characteristicModel = CharacteristicsModel::query()
67
-            ->when(isset($conditions['type']), function ($query) use($conditions){
67
+            ->when(isset($conditions['type']), function($query) use($conditions){
68 68
                 $query->where('type', $conditions['type']);
69
-            })->when(isset($conditions['title']), function ($query) use($conditions){
69
+            })->when(isset($conditions['title']), function($query) use($conditions){
70 70
                 $query->where('code', $conditions['title']);
71 71
             })
72 72
             ->first();
73
-        if(!isset($characteristicModel)){
73
+        if (!isset($characteristicModel)) {
74 74
             return null;
75 75
         }
76 76
         return $characteristicModel->toDomain();
@@ -80,13 +80,13 @@  discard block
 block discarded – undo
80 80
     {
81 81
         $characteristicModel = CharacteristicsModel::query()
82 82
             ->where('type', $type)
83
-            ->where('pretty_page_label','LIKE', '%'.$search.'%')
83
+            ->where('pretty_page_label', 'LIKE', '%'.$search.'%')
84 84
             ->get();
85 85
 
86
-        if(!isset($characteristicModel)){
86
+        if (!isset($characteristicModel)) {
87 87
             return [];
88 88
         }
89
-        foreach ($characteristicModel as $characteristic){
89
+        foreach ($characteristicModel as $characteristic) {
90 90
             $characteristics[] = $characteristic->toArray();
91 91
         }
92 92
         return $characteristics ?? [];
Please login to merge, or discard this patch.