Conditions | 10 |
Paths | 256 |
Total Lines | 28 |
Code Lines | 19 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
37 | public function processWizard(Request $request, FillWikiUserProfile $fillWikiUserProfile) |
||
38 | { |
||
39 | $role = $request->input('role') !== null ? $request->input('role') : ''; |
||
40 | $firstname = $request->input('firstname') !== null ? $request->input('firstname') : ''; |
||
41 | $lastname = $request->input('lastname') !== null ? $request->input('lastname') : ''; |
||
42 | $postalCode = $request->input('postal_code') !== null ? $request->input('postal_code') : ''; |
||
43 | $email = $request->input('email') !== null ? $request->input('email') : ''; |
||
44 | $farmingType = $request->input('farming_type') !== null ? $request->input('farming_type') : []; |
||
45 | |||
46 | $fillWikiUserProfile->fill(Auth::user()->uuid, $role, $firstname, $lastname, $email, $postalCode, $farmingType); |
||
47 | |||
48 | if(Auth::user()->hasVerifiedEmail()) { |
||
49 | $user = Auth::user(); |
||
50 | if ($request->session()->has('wiki_callback')) { |
||
51 | $user->wiki_token = $request->session()->get('wiki_token'); |
||
52 | $user->save(); |
||
53 | $callback = urldecode($request->session()->get('wiki_callback')); |
||
|
|||
54 | return redirect($callback); |
||
55 | } |
||
56 | |||
57 | if($request->session()->has('sso')){ |
||
58 | $sso = $request->session()->get('sso'); |
||
59 | $sig = $request->session()->get('sig'); |
||
60 | return redirect('discourse/sso?sso='.$sso.'&sig='.$sig); |
||
61 | } |
||
62 | } |
||
63 | |||
64 | return redirect()->route('verification.notice'); |
||
65 | } |
||
67 |