TestsThatNeedsRules.__delete_rule() - Code Metrics - Inspection of "Simplify the code of some tests" - nbs-system/spike - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 809e83...65ac8a )

by -

created 2016-03-24 17:25 UTC

TestsThatNeedsRules.__delete_rule() A

↳ Parent: TestsThatNeedsRules

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	4
dl	0
loc	7
rs	9.2

# Something that is untested is broken.

import unittest

from spike.model.naxsi_rules import NaxsiRules
from spike.model import db

from spike import create_app


class TestsThatNeedsRules(unittest.TestCase):
    """ A simple calss that create a rule before running tests, and destroy destroy it when the tests are over. """
    def setUp(self):
        app = create_app()
        db.init_app(app)
        app.config['TESTING'] = True
        self.app = app.test_client()
        self.created_rules = list()
        self.__create_rule()

    def tearDown(self):
        self.__delete_rule()

    def __create_rule(self):
        """

        :return int: The id of the new rule
        """
        current_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
        current_sid = 1337 if current_sid is None else current_sid.sid + 1

        db.session.add(NaxsiRules(u'POUET', 'str:test', u'BODY', u'$SQL:8', current_sid, u'WEB_APPS',
                                  u'f hqewifueiwf hueiwhf uiewh fiewh fhw', '1', True, 1457101045))
        self.created_rules.append(current_sid)
        return int(current_sid)

    def __delete_rule(self, sid=None):
        if sid:
            db.session.delete(NaxsiRules.query.filter(sid == NaxsiRules.sid).first())
        for sid in self.created_rules:
            _rule = NaxsiRules.query.filter(sid == NaxsiRules.sid).first()
            if _rule:
                db.session.delete(_rule)

1			# Something that is untested is broken.
2
3			import unittest
4
5			from spike.model.naxsi_rules import NaxsiRules
6			from spike.model import db
7
8			from spike import create_app
9
10
11			class TestsThatNeedsRules(unittest.TestCase):
12			""" A simple calss that create a rule before running tests, and destroy destroy it when the tests are over. """
13			def setUp(self):
14			app = create_app()
15			db.init_app(app)
16			app.config['TESTING'] = True
17			self.app = app.test_client()
18			self.created_rules = list()
19			self.__create_rule()
20
21			def tearDown(self):
22			self.__delete_rule()
23
24			def __create_rule(self):
25			"""
26
27			:return int: The id of the new rule
28			"""
29			current_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
30			current_sid = 1337 if current_sid is None else current_sid.sid + 1
31
32			db.session.add(NaxsiRules(u'POUET', 'str:test', u'BODY', u'$SQL:8', current_sid, u'WEB_APPS',
33			u'f hqewifueiwf hueiwhf uiewh fiewh fhw', '1', True, 1457101045))
34			self.created_rules.append(current_sid)
35			return int(current_sid)
36
37			def __delete_rule(self, sid=None):
38			if sid:
39			db.session.delete(NaxsiRules.query.filter(sid == NaxsiRules.sid).first())
40			for sid in self.created_rules:
41			_rule = NaxsiRules.query.filter(sid == NaxsiRules.sid).first()
42			if _rule:
43			db.session.delete(_rule)

nbs-system / spike

Push — master ( 809e83...65ac8a )

TestsThatNeedsRules.__delete_rule() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like