FlaskrTestCase.test_new_rule() - Code Metrics - Inspection of "Add even more coverage" - nbs-system/spike - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e2d0e9...36ff9f )

by -

created 2016-03-05 18:34 UTC

FlaskrTestCase.test_new_rule() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	1

Metric	Value
cc	1
dl	0
loc	27
ccs	14
cts	14
cp	1
crap	1
rs	8.8571

from time import strftime, localtime
import re

from sqlalchemy.orm.exc import UnmappedInstanceError
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from spike import create_app
from spike.model import db
from spike.model.naxsi_rules import NaxsiRules
import unittest


class FlaskrTestCase(unittest.TestCase):
    def setUp(self):
        app = create_app()
        db.init_app(app)
        app.config['TESTING'] = True
        self.app = app.test_client()

    def tearDown(self):
        pass

    def __create_rule(self):
        """

        :return int: The id of the new rule
        """
        current_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
        current_sid = 1337 if current_sid is None else current_sid.sid + 1

        db.session.add(NaxsiRules(u'POUET', 'str:test', u'BODY', u'$SQL:8', current_sid, u'web_server.rules',
                                  u'f hqewifueiwf hueiwhf uiewh fiewh fhw', '1', True, 1457101045))
        self.sid_to_delete = current_sid
class Foo:
    def __init__(self, x=None):
        self.x = x
        return current_sid

    def __delete_rule(self, sid=None):
        sid = self.sid_to_delete if sid is None else sid
        try:
            db.session.delete(NaxsiRules.query.filter(sid == NaxsiRules.sid).first())
        except UnmappedInstanceError:  # who cares ?
try:
    raises_exception()
except:  # Could be removed
    pass
            pass

    def test_index(self):
        rv = self.app.get('/', follow_redirects=True)
        self.assertEqual(rv.status_code, 200)
        self.assertIn('<title>SPIKE! - WAF Rules Builder</title>', rv.data)
        self.assertTrue(re.search(r'<h2>Naxsi - Rules \( \d+ \)</h2>', rv.data) is not None)

    def test_new_rule(self):
        data = {
            'msg': 'this is a test message',
            'detection': 'DETECTION',
            'mz': 'BODY',
            'custom_mz_val': '',
            'negative': 'checked',
            'score_$SQL': 8,
            'score': '$SQL',
            'rmks': 'this is a test remark',
            'ruleset': 'scanner.rules'
        }
        rv = self.app.post('/rules/new', data=data, follow_redirects=True)
        _rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()

        self.assertIn(('<li> - OK: created %d : %s</li>' % (_rule.sid, _rule.msg)), rv.data)
        self.assertEqual(_rule.msg, data['msg'])
        self.assertEqual(_rule.detection, 'str:' + data['detection'])
        self.assertEqual(_rule.mz, data['mz'])
        self.assertEqual(_rule.score, data['score'] + ':' + str(data['score_$SQL']))
        self.assertEqual(_rule.rmks, data['rmks'])
        self.assertEqual(_rule.ruleset, data['ruleset'])

        rv = self.app.get('/rules/new')
        self.assertEqual(rv.status_code, 200)

        self.__delete_rule(_rule.sid)

    def test_del_rule(self):
        old_sid = self.__create_rule()

        db.session.add(NaxsiRules(u'POUET', 'str:test', u'BODY', u'$SQL:8', old_sid + 1, u'web_server.rules',
                                  u'f hqewifueiwf hueiwhf uiewh fiewh fhw', '1', True, 1457101045))
        rv = self.app.get('/rules/del/%d' % (old_sid + 1))
        self.assertEqual(rv.status_code, 302)

        _rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
        self.assertEqual(_rule.sid, old_sid)

        rv = self.app.get('/rules/del/%d' % (_rule.sid + 1))
        self.assertEqual(rv.status_code, 302)

        self.__delete_rule()

    def test_plain_rule(self):
        self.__create_rule()

        _rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
        rv = self.app.get('/rules/plain/%d' % _rule.sid)
        self.assertEqual(rv.status_code, 200)
        rdate = strftime("%F - %H:%M", localtime(float(str(_rule.timestamp))))
        rmks = "# ".join(_rule.rmks.strip().split("\n"))
        detect = _rule.detection.lower() if _rule.detection.startswith("str:") else _rule.detection
        negate = 'negative' if _rule.negative == 1 else ''
        expected = """
#
# sid: %s | date: %s
#
# %s
#
MainRule %s "%s" "msg:%s" "mz:%s" "s:%s" id:%s ;

""" % (_rule.sid, rdate, rmks, negate, detect, _rule.msg, _rule.mz, _rule.score, _rule.sid)
        self.assertEqual(expected, rv.data)

        rv = self.app.get('/rules/plain/%d' % (_rule.sid + 1))
        self.assertEqual(rv.status_code, 302)

        self.__delete_rule()

    def test_deact_rule(self):
        rv = self.app.get('/rules/deact/')
        self.assertEqual(rv.status_code, 404)
        self.__create_rule()
        non_existent_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first().sid + 1

        rv = self.app.get('/rules/deact/%d' % non_existent_sid)
        self.assertEqual(rv.status_code, 302)

        self.__delete_rule()




Push — master ( e2d0e9...36ff9f )

FlaskrTestCase.test_new_rule() B

Complexity

Size

Duplication

Code Coverage

1. Missing Dependencies

2. Missing init.py files

1	1	from time import strftime, localtime
2	1	import re
3
4	1	from sqlalchemy.orm.exc import UnmappedInstanceError
		0 ignored issues – show Configuration introduced 2016-03-04 16:38 UTC by Report Bug Copy Issue Report The import `sqlalchemy.orm.exc` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5
6	1	from spike import create_app
7	1	from spike.model import db
8	1	from spike.model.naxsi_rules import NaxsiRules
9	1	import unittest
10
11
12	1	class FlaskrTestCase(unittest.TestCase):
13	1	def setUp(self):
14	1	app = create_app()
15	1	db.init_app(app)
16	1	app.config['TESTING'] = True
17	1	self.app = app.test_client()
18
19	1	def tearDown(self):
20	1	pass
21
22	1	def __create_rule(self):
23		"""
24
25		:return int: The id of the new rule
26		"""
27	1	current_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
28	1	current_sid = 1337 if current_sid is None else current_sid.sid + 1
29
30	1	db.session.add(NaxsiRules(u'POUET', 'str:test', u'BODY', u'$SQL:8', current_sid, u'web_server.rules',
31		u'f hqewifueiwf hueiwhf uiewh fiewh fhw', '1', True, 1457101045))
32	1	self.sid_to_delete = current_sid
		0 ignored issues – show Coding Style introduced 2016-03-04 15:22 UTC by Report Bug Copy Issue Report The attribute `sid_to_delete` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
33	1	return current_sid
34
35	1	def __delete_rule(self, sid=None):
36	1	sid = self.sid_to_delete if sid is None else sid
37	1	try:
38	1	db.session.delete(NaxsiRules.query.filter(sid == NaxsiRules.sid).first())
39	1	except UnmappedInstanceError: # who cares ?
		0 ignored issues – show Unused Code introduced 2016-03-04 16:38 UTC by Report Bug Copy Issue Report This except handler seems to be unused and could be removed. Except handlers which only contain `pass` and do not have an `else` clause can usually simply be removed: try: raises_exception() except: # Could be removed pass Loading history...
40	1	pass
41
42	1	def test_index(self):
43	1	rv = self.app.get('/', follow_redirects=True)
44	1	self.assertEqual(rv.status_code, 200)
45	1	self.assertIn('<title>SPIKE! - WAF Rules Builder</title>', rv.data)
46	1	self.assertTrue(re.search(r'<h2>Naxsi - Rules \( \d+ \)</h2>', rv.data) is not None)
47
48	1	def test_new_rule(self):
49	1	data = {
50		'msg': 'this is a test message',
51		'detection': 'DETECTION',
52		'mz': 'BODY',
53		'custom_mz_val': '',
54		'negative': 'checked',
55		'score_$SQL': 8,
56		'score': '$SQL',
57		'rmks': 'this is a test remark',
58		'ruleset': 'scanner.rules'
59		}
60	1	rv = self.app.post('/rules/new', data=data, follow_redirects=True)
61	1	_rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
62
63	1	self.assertIn(('<li> - OK: created %d : %s</li>' % (_rule.sid, _rule.msg)), rv.data)
64	1	self.assertEqual(_rule.msg, data['msg'])
65	1	self.assertEqual(_rule.detection, 'str:' + data['detection'])
66	1	self.assertEqual(_rule.mz, data['mz'])
67	1	self.assertEqual(_rule.score, data['score'] + ':' + str(data['score_$SQL']))
68	1	self.assertEqual(_rule.rmks, data['rmks'])
69	1	self.assertEqual(_rule.ruleset, data['ruleset'])
70
71	1	rv = self.app.get('/rules/new')
72	1	self.assertEqual(rv.status_code, 200)
73
74	1	self.__delete_rule(_rule.sid)
75
76	1	def test_del_rule(self):
77	1	old_sid = self.__create_rule()
78
79	1	db.session.add(NaxsiRules(u'POUET', 'str:test', u'BODY', u'$SQL:8', old_sid + 1, u'web_server.rules',
80		u'f hqewifueiwf hueiwhf uiewh fiewh fhw', '1', True, 1457101045))
81	1	rv = self.app.get('/rules/del/%d' % (old_sid + 1))
82	1	self.assertEqual(rv.status_code, 302)
83
84	1	_rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
85	1	self.assertEqual(_rule.sid, old_sid)
86
87	1	rv = self.app.get('/rules/del/%d' % (_rule.sid + 1))
88	1	self.assertEqual(rv.status_code, 302)
89
90	1	self.__delete_rule()
91
92	1	def test_plain_rule(self):
93	1	self.__create_rule()
94
95	1	_rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
96	1	rv = self.app.get('/rules/plain/%d' % _rule.sid)
97	1	self.assertEqual(rv.status_code, 200)
98	1	rdate = strftime("%F - %H:%M", localtime(float(str(_rule.timestamp))))
99	1	rmks = "# ".join(_rule.rmks.strip().split("\n"))
100	1	detect = _rule.detection.lower() if _rule.detection.startswith("str:") else _rule.detection
101	1	negate = 'negative' if _rule.negative == 1 else ''
102	1	expected = """
103		#
104		# sid: %s \| date: %s
105		#
106		# %s
107		#
108		MainRule %s "%s" "msg:%s" "mz:%s" "s:%s" id:%s ;
109
110		""" % (_rule.sid, rdate, rmks, negate, detect, _rule.msg, _rule.mz, _rule.score, _rule.sid)
111	1	self.assertEqual(expected, rv.data)
112
113	1	rv = self.app.get('/rules/plain/%d' % (_rule.sid + 1))
114	1	self.assertEqual(rv.status_code, 302)
115
116	1	self.__delete_rule()
117
118	1	def test_deact_rule(self):
119	1	rv = self.app.get('/rules/deact/')
120	1	self.assertEqual(rv.status_code, 404)
121	1	self.__create_rule()
122	1	non_existent_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first().sid + 1
123
124	1	rv = self.app.get('/rules/deact/%d' % non_existent_sid)
125	1	self.assertEqual(rv.status_code, 302)
126
127	1	self.__delete_rule()
128
129
130

nbs-system / spike

Push — master ( e2d0e9...36ff9f )

FlaskrTestCase.test_new_rule() B

Complexity

Size

Duplication

Code Coverage

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files